Add dedicated bindings for the Hisilicon Kirin 960 USB OTG Syscon,
to fully document the block and also fix dtbs_check warning:
hi3660-hikey960.dtb: usb3_otg_bc@ff200000: compatible: ['syscon', 'simple-mfd'] is too short
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Cc: Jiaxun Yang <[email protected]>
---
.../hisilicon,hi3660-usb3-otg-bc.yaml | 46 +++++++++++++++++++
1 file changed, 46 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/hisilicon/hisilicon,hi3660-usb3-otg-bc.yaml
diff --git a/Documentation/devicetree/bindings/soc/hisilicon/hisilicon,hi3660-usb3-otg-bc.yaml b/Documentation/devicetree/bindings/soc/hisilicon/hisilicon,hi3660-usb3-otg-bc.yaml
new file mode 100644
index 000000000000..2e26637a4711
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/hisilicon/hisilicon,hi3660-usb3-otg-bc.yaml
@@ -0,0 +1,46 @@
+# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/hisilicon/hisilicon,hi3660-usb3-otg-bc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Hisilicon Kirin 960 USB OTG Syscon
+
+maintainers:
+ - Mauro Carvalho Chehab <[email protected]>
+
+properties:
+ compatible:
+ items:
+ - const: hisilicon,hi3660-usb3-otg-bc
+ - const: syscon
+ - const: simple-mfd
+
+ reg:
+ maxItems: 1
+
+ usb-phy:
+ $ref: /schemas/phy/hisilicon,hi3660-usb3.yaml
+ description: USB Phy node
+
+required:
+ - compatible
+ - reg
+ - usb-phy
+
+additionalProperties: false
+
+examples:
+ - |
+ syscon@ff200000 {
+ compatible = "hisilicon,hi3660-usb3-otg-bc", "syscon", "simple-mfd";
+ reg = <0xff200000 0x1000>;
+
+ usb-phy {
+ compatible = "hisilicon,hi3660-usb-phy";
+ #phy-cells = <0>;
+ hisilicon,pericrg-syscon = <&crg_ctrl>;
+ hisilicon,pctrl-syscon = <&pctrl>;
+ hisilicon,eye-diagram-param = <0x22466e4>;
+ };
+ };
--
2.43.0
Each syscon node must come with a dedicated/specific compatible, which
is also reported by dtbs_check:
hi3660-hikey960.dtb: usb3_otg_bc@ff200000: compatible: ['syscon', 'simple-mfd'] is too short
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Cc: Jiaxun Yang <[email protected]>
---
arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
index 7e137a884ae5..957a1b41f19b 100644
--- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
@@ -1161,7 +1161,7 @@ map1 {
};
usb3_otg_bc: usb3_otg_bc@ff200000 {
- compatible = "syscon", "simple-mfd";
+ compatible = "hisilicon,hi3660-usb3-otg-bc", "syscon", "simple-mfd";
reg = <0x0 0xff200000 0x0 0x1000>;
usb_phy: usb-phy {
--
2.43.0
On Sat, May 18, 2024 at 10:44:42PM +0200, Krzysztof Kozlowski wrote:
> Add dedicated bindings for the Hisilicon Kirin 960 USB OTG Syscon,
> to fully document the block and also fix dtbs_check warning:
> hi3660-hikey960.dtb: usb3_otg_bc@ff200000: compatible: ['syscon', 'simple-mfd'] is too short
> +title: Hisilicon Kirin 960 USB OTG Syscon
> + - const: hisilicon,hi3660-usb3-otg-bc
I know you got it from the node name, what does "bc" mean here?
Otherwise,
Reviewed-by: Conor Dooley <[email protected]>
Hi Conor,
On 2024/5/21 1:10, Conor Dooley wrote:
> On Sat, May 18, 2024 at 10:44:42PM +0200, Krzysztof Kozlowski wrote:
>> Add dedicated bindings for the Hisilicon Kirin 960 USB OTG Syscon,
>> to fully document the block and also fix dtbs_check warning:
>
>> hi3660-hikey960.dtb: usb3_otg_bc@ff200000: compatible: ['syscon', 'simple-mfd'] is too short
>
>> +title: Hisilicon Kirin 960 USB OTG Syscon
>> + - const: hisilicon,hi3660-usb3-otg-bc
>
> I know you got it from the node name, what does "bc" mean here?
I think it might be the USB Battery Charging Specification.
Best Regards,
Wei
> Otherwise,
> Reviewed-by: Conor Dooley <[email protected]>
>