2024-05-20 06:48:13

by Roshan Khatri

Subject: [PATCH] staging: rtl8712: Fix spelling mistakes in rtl871x_event.h

codespell reported misspelled joining in rtl871x_event.h. This patch
fixes the misspelled joining word.

Signed-off-by: Roshan Khatri <[email protected]>
---
drivers/staging/rtl8712/rtl871x_event.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8712/rtl871x_event.h b/drivers/staging/rtl8712/rtl871x_event.h
index 759a2d27d8f2..0cc780cf4341 100644
--- a/drivers/staging/rtl8712/rtl871x_event.h
+++ b/drivers/staging/rtl8712/rtl871x_event.h
@@ -37,7 +37,7 @@ struct surveydone_event {
};

/*
- * Used to report the link result of joinning the given bss
+ * Used to report the link result of joining the given bss
* join_res:
* -1: authentication fail
* -2: association fail
--
2.34.1

2024-05-20 18:39:38

by Philipp Hortmann

Subject: Re: [PATCH] staging: rtl8712: Fix spelling mistakes in rtl871x_event.h

On 5/20/24 08:47, Roshan Khatri wrote:
> codespell reported misspelled joining in rtl871x_event.h. This patch
> fixes the misspelled joining word.
>
> Signed-off-by: Roshan Khatri <[email protected]>
> ---
> drivers/staging/rtl8712/rtl871x_event.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_event.h b/drivers/staging/rtl8712/rtl871x_event.h
> index 759a2d27d8f2..0cc780cf4341 100644
> --- a/drivers/staging/rtl8712/rtl871x_event.h
> +++ b/drivers/staging/rtl8712/rtl871x_event.h
> @@ -37,7 +37,7 @@ struct surveydone_event {
> };
>
> /*
> - * Used to report the link result of joinning the given bss
> + * Used to report the link result of joining the given bss
> * join_res:
> * -1: authentication fail
> * -2: association fail

Hi Roshan,

Subject line looks good to me - but it is only one mistake and not mistakes.

Patch description: Omit what you are changing as this can be seen in the
change itself. Do only write why you are doing this.

You can find examples with
git log --grep=codespell
or
git log --grep=typo

If you send in a second version of this patch please use a change
history. Description from Dan under:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

This is just my opinion but often I am right. Any response from Greg is
binding.

Bye Philipp