2024-05-02 11:32:39

by Merlijn Wajer

Subject: No cpufreq entries with omap2plus_defconfig since "cpufreq: dt-platdev: Support building as module" (commit 3b062a08)

Hi,

I was looking at switching my Motorola Droid 4 phone from Linux 6.1 to
Linux 6.6, and it no longer gets any cpufreq entries on boot, and I
found cpufreq_dt was no longer loaded. I tried to force the issue by
modprobe it, but to no avail. The same issue occurs on the latest 6.9.

After a bit of digging it looks like the problem is that
cpufreq-dt-platdev can be built as a module and when this the case
(apparently the default), cpufreq_dt doesn't work. With the
omap2plus_defconfig, CONFIG_CPUFREQ_DT_PLATDEV is indeed set to module.

When I manually probe cpufreq-dt-platdev and cpufreq_dt, I get the
cpufreq_entries back.

Searching around I found this debian bug report [1] which just flips the
CONFIG_CPUFREQ_DT_PLATDEV back to '=y', but I think there might be a
deeper issue here.

Is there a way to define this relationship/dependency for cpufreq-dt, so
that it will automatically load this module?

Regards,
Merlijn

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050587

2024-05-20 07:19:33

by Viresh Kumar

Subject: Re: No cpufreq entries with omap2plus_defconfig since "cpufreq: dt-platdev: Support building as module" (commit 3b062a08)

On 02-05-24, 13:04, Merlijn Wajer wrote:
> Hi,
>
> I was looking at switching my Motorola Droid 4 phone from Linux 6.1 to Linux
> 6.6, and it no longer gets any cpufreq entries on boot, and I found
> cpufreq_dt was no longer loaded. I tried to force the issue by modprobe it,
> but to no avail. The same issue occurs on the latest 6.9.
>
> After a bit of digging it looks like the problem is that cpufreq-dt-platdev
> can be built as a module and when this the case (apparently the default),
> cpufreq_dt doesn't work. With the omap2plus_defconfig,
> CONFIG_CPUFREQ_DT_PLATDEV is indeed set to module.
>
> When I manually probe cpufreq-dt-platdev and cpufreq_dt, I get the
> cpufreq_entries back.
>
> Searching around I found this debian bug report [1] which just flips the
> CONFIG_CPUFREQ_DT_PLATDEV back to '=y', but I think there might be a deeper
> issue here.
>
> Is there a way to define this relationship/dependency for cpufreq-dt, so
> that it will automatically load this module?

Does this fix it for you ?

diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
index 100760259f70..bb48b674be5e 100644
--- a/drivers/cpufreq/cpufreq-dt-platdev.c
+++ b/drivers/cpufreq/cpufreq-dt-platdev.c
@@ -233,4 +233,5 @@ static int __init cpufreq_dt_platdev_init(void)
sizeof(struct cpufreq_dt_platform_data)));
}
core_initcall(cpufreq_dt_platdev_init);
+MODULE_ALIAS("platform:cpufreq-dt");
MODULE_LICENSE("GPL");

--
viresh