2024-05-21 13:29:06

by Pratik Farkase

Subject: [PATCH v3] dt-bindings: gpio: lsi,zevio-gpio: convert to dtschema

Convert Zevio GPIO Controller from text to dtschema.

Signed-off-by: Pratik Farkase <[email protected]>
---
Changes in v3:
- Updated relative path filename to match actual path filename
- Added `interrupts` property
Changes in v2:
- Renamed file from `gpio-zevio.yaml` to `lsi,zevio-gpio.yaml`
- Fixed the space indentation in example
---
---
.../devicetree/bindings/gpio/gpio-zevio.txt | 16 -------
.../bindings/gpio/lsi,zevio-gpio.yaml | 44 +++++++++++++++++++
2 files changed, 44 insertions(+), 16 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-zevio.txt
create mode 100644 Documentation/devicetree/bindings/gpio/lsi,zevio-gpio.yaml

diff --git a/Documentation/devicetree/bindings/gpio/gpio-zevio.txt b/Documentation/devicetree/bindings/gpio/gpio-zevio.txt
deleted file mode 100644
index a37bd9ae2730..000000000000
--- a/Documentation/devicetree/bindings/gpio/gpio-zevio.txt
+++ /dev/null
@@ -1,16 +0,0 @@
-Zevio GPIO controller
-
-Required properties:
-- compatible: Should be "lsi,zevio-gpio"
-- reg: Address and length of the register set for the device
-- #gpio-cells: Should be two. The first cell is the pin number and the
- second cell is used to specify optional parameters (currently unused).
-- gpio-controller: Marks the device node as a GPIO controller.
-
-Example:
- gpio: gpio@90000000 {
- compatible = "lsi,zevio-gpio";
- reg = <0x90000000 0x1000>;
- gpio-controller;
- #gpio-cells = <2>;
- };
diff --git a/Documentation/devicetree/bindings/gpio/lsi,zevio-gpio.yaml b/Documentation/devicetree/bindings/gpio/lsi,zevio-gpio.yaml
new file mode 100644
index 000000000000..37df0e6cfec5
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpio/lsi,zevio-gpio.yaml
@@ -0,0 +1,43 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/gpio/lsi,zevio-gpio.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Zevio GPIO controller
+
+maintainers:
+ - Pratik Farkase <[email protected]>
+
+properties:
+ compatible:
+ items:
+ - const: lsi,zevio-gpio
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ "#gpio-cells":
+ const: 2
+
+ gpio-controller: true
+
+required:
+ - compatible
+ - reg
+ - "#gpio-cells"
+ - gpio-controller
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ gpio@90000000 {
+ compatible = "lsi,zevio-gpio";
+ reg = <0x90000000 0x1000>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
--
2.34.1

2024-05-21 15:15:17

by Krzysztof Kozlowski

Subject: Re: [PATCH v3] dt-bindings: gpio: lsi,zevio-gpio: convert to dtschema

On 21/05/2024 15:28, Pratik Farkase wrote:
> Convert Zevio GPIO Controller from text to dtschema.
>
> Signed-off-by: Pratik Farkase <[email protected]>
> ---
> Changes in v3:
> - Updated relative path filename to match actual path filename
> - Added `interrupts` property

Why?

It wasn't present before, so please mention changes done during
conversion in the commit msg with short explanation why.


> Changes in v2:
> - Renamed file from `gpio-zevio.yaml` to `lsi,zevio-gpio.yaml`
> - Fixed the space indentation in example
> ---
> ---


Best regards,
Krzysztof