2024-05-22 03:55:40

by Wu Bo

Subject: [PATCH] scripts/gdb: fix symbol link when run make cmd out of tree

When running 'make scripts_gdb' command out of kernel source tree, the
symbol links gennerated under build-dir/scripts/gdb/linux is invalid.

$(srctree)/$(src) need to be replaced with $(src) since
commit b1992c3772e6 ("kbuild: use $(src) instead of $(srctree)/$(src)
for source directory")

Signed-off-by: Wu Bo <[email protected]>
---
scripts/gdb/linux/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/gdb/linux/Makefile b/scripts/gdb/linux/Makefile
index d77ad9079d0f..fcd32fcf3ae0 100644
--- a/scripts/gdb/linux/Makefile
+++ b/scripts/gdb/linux/Makefile
@@ -5,7 +5,7 @@ ifdef building_out_of_srctree
symlinks := $(patsubst $(src)/%,%,$(wildcard $(src)/*.py))

quiet_cmd_symlink = SYMLINK $@
- cmd_symlink = ln -fsn $(patsubst $(obj)/%,$(abspath $(srctree))/$(src)/%,$@) $@
+ cmd_symlink = ln -fsn $(patsubst $(obj)/%,$(abspath $(src))/%,$@) $@

always-y += $(symlinks)
$(addprefix $(obj)/, $(symlinks)): FORCE
--
2.25.1

2024-05-22 10:39:25

by Masahiro Yamada

Subject: Re: [PATCH] scripts/gdb: fix symbol link when run make cmd out of tree

On Wed, May 22, 2024 at 12:55 PM Wu Bo <[email protected]> wrote:
>
> When running 'make scripts_gdb' command out of kernel source tree, the
> symbol links gennerated under build-dir/scripts/gdb/linux is invalid.
>
> $(srctree)/$(src) need to be replaced with $(src) since
> commit b1992c3772e6 ("kbuild: use $(src) instead of $(srctree)/$(src)
> for source directory")
>
> Signed-off-by: Wu Bo <[email protected]>
> ---


This was fixed in today's linux-next.

commit ab32efe0e2b6ab01ba079995071da8d587c976cc
Author: Douglas Anderson <[email protected]>
Date: Mon May 20 12:56:52 2024 -0700

kbuild: scripts/gdb: Replace missed $(srctree)/$(src) w/ $(src)





--
Best Regards
Masahiro Yamada