2024-05-24 03:24:12

by Bjorn Andersson

[permalink] [raw]
Subject: [PATCH] firmware: qcom: uefisecapp: Allow on X1E devices

From: Bjorn Andersson <[email protected]>

As with previous platforms, qseecom and the uefisecapp provides access
to EFI variables. Add X1E CRD and QCP devices to the allowlist.

Signed-off-by: Bjorn Andersson <[email protected]>
---
Only tested on CRD
---
drivers/firmware/qcom/qcom_scm.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c
index 68f4df7e6c3c..1be5374cd3c9 100644
--- a/drivers/firmware/qcom/qcom_scm.c
+++ b/drivers/firmware/qcom/qcom_scm.c
@@ -1649,6 +1649,8 @@ static const struct of_device_id qcom_scm_qseecom_allowlist[] __maybe_unused = {
{ .compatible = "lenovo,flex-5g" },
{ .compatible = "lenovo,thinkpad-x13s", },
{ .compatible = "qcom,sc8180x-primus" },
+ { .compatible = "qcom,x1e80100-crd" },
+ { .compatible = "qcom,x1e80100-qcp" },
{ }
};


---
base-commit: 3689b0ef08b70e4e03b82ebd37730a03a672853a
change-id: 20240523-x1e-efivarfs-73e01de5b993

Best regards,
--
Bjorn Andersson <[email protected]>



2024-05-24 15:47:24

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH] firmware: qcom: uefisecapp: Allow on X1E devices

On 24.05.2024 5:28 AM, Bjorn Andersson wrote:
> From: Bjorn Andersson <[email protected]>
>
> As with previous platforms, qseecom and the uefisecapp provides access
> to EFI variables. Add X1E CRD and QCP devices to the allowlist.
>
> Signed-off-by: Bjorn Andersson <[email protected]>
> ---
> Only tested on CRD
> ---

The QCP is happy too

Reviewed-by: Konrad Dybcio <[email protected]>
Tested-by: Konrad Dybcio <[email protected]>

Konrad

2024-05-27 03:01:53

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH] firmware: qcom: uefisecapp: Allow on X1E devices


On Thu, 23 May 2024 20:28:41 -0700, Bjorn Andersson wrote:
> As with previous platforms, qseecom and the uefisecapp provides access
> to EFI variables. Add X1E CRD and QCP devices to the allowlist.
>
>

Applied, thanks!

[1/1] firmware: qcom: uefisecapp: Allow on X1E devices
commit: 9e7b5b4f5ec4e8f677ea17f72355ca1f1fd4e5a0

Best regards,
--
Bjorn Andersson <[email protected]>