2024-05-23 13:30:06

by Chao Yu

Subject: [PATCH] f2fs: fix to force buffered IO on inline_data inode

It will return all zero data when DIO reading from inline_data inode, it
is because f2fs_iomap_begin() assign iomap->type w/ IOMAP_HOLE incorrectly
for this case.

We can let iomap framework handle inline data via assigning iomap->type
and iomap->inline_data correctly, however, it will be a little bit
complicated when handling race case in between direct IO and buffered IO.

So, let's force to use buffered IO to fix this issue.

Cc: [email protected]
Reported-by: Barry Song <[email protected]>
Signed-off-by: Chao Yu <[email protected]>
---
fs/f2fs/file.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index db6236f27852..e038910ad1e5 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -851,6 +851,8 @@ static bool f2fs_force_buffered_io(struct inode *inode, int rw)
return true;
if (f2fs_compressed_file(inode))
return true;
+ if (f2fs_has_inline_data(inode))
+ return true;

/* disallow direct IO if any of devices has unaligned blksize */
if (f2fs_is_multi_device(sbi) && !sbi->aligned_blksize)
--
2.40.1

2024-06-12 15:59:06

by patchwork-bot+f2fs

Subject: Re: [f2fs-dev] [PATCH] f2fs: fix to force buffered IO on inline_data inode

Hello:

This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:

On Thu, 23 May 2024 21:29:48 +0800 you wrote:
> It will return all zero data when DIO reading from inline_data inode, it
> is because f2fs_iomap_begin() assign iomap->type w/ IOMAP_HOLE incorrectly
> for this case.
>
> We can let iomap framework handle inline data via assigning iomap->type
> and iomap->inline_data correctly, however, it will be a little bit
> complicated when handling race case in between direct IO and buffered IO.
>
> [...]

Here is the summary with links:
- [f2fs-dev] f2fs: fix to force buffered IO on inline_data inode
https://git.kernel.org/jaegeuk/f2fs/c/5c8764f8679e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html