2024-05-24 03:56:08

by Roshan Khatri

[permalink] [raw]
Subject: [PATCH v2] staging: rtl8192e: Fix spelling mistakes in rtllib_softmac.c

This patch corrects some misspellings to increase code readability and
searching.

Signed-off-by: Roshan Khatri <[email protected]>
---
drivers/staging/rtl8192e/rtllib_softmac.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
index 97fdca828da7..0fc97c868f81 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -421,7 +421,7 @@ static void rtllib_softmac_scan_syncro(struct rtllib_device *ieee)
* So we switch to MAC80211_LINKED_SCANNING to remember
* that we are still logically linked (not interested in
* new network events, despite for updating the net list,
- * but we are temporarly 'unlinked' as the driver shall
+ * but we are temporarily 'unlinked' as the driver shall
* not filter RX frames and the channel is changing.
* So the only situation in which are interested is to check
* if the state become LINKED because of the #1 situation
@@ -934,7 +934,7 @@ static void rtllib_associate_abort(struct rtllib_device *ieee)

ieee->associate_seq++;

- /* don't scan, and avoid to have the RX path possibily
+ /* don't scan, and avoid to have the RX path possibly
* try again to associate. Even do not react to AUTH or
* ASSOC response. Just wait for the retry wq to be scheduled.
* Here we will check if there are good nets to associate
@@ -1359,7 +1359,7 @@ static short rtllib_sta_ps_sleep(struct rtllib_device *ieee, u64 *time)
return 0;
timeout = ieee->current_network.beacon_interval;
ieee->current_network.dtim_data = RTLLIB_DTIM_INVALID;
- /* there's no need to nofity AP that I find you buffered
+ /* there's no need to notify AP that I find you buffered
* with broadcast packet
*/
if (dtim & (RTLLIB_DTIM_UCAST & ieee->ps))
@@ -1806,7 +1806,7 @@ void rtllib_softmac_xmit(struct rtllib_txb *txb, struct rtllib_device *ieee)

spin_lock_irqsave(&ieee->lock, flags);

- /* called with 2nd parm 0, no tx mgmt lock required */
+ /* called with 2nd param 0, no tx mgmt lock required */
rtllib_sta_wakeup(ieee, 0);

/* update the tx status */
--
2.34.1



2024-05-24 04:02:30

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v2] staging: rtl8192e: Fix spelling mistakes in rtllib_softmac.c

On Fri, May 24, 2024 at 09:40:24AM +0545, Roshan Khatri wrote:
> This patch corrects some misspellings to increase code readability and
> searching.
>
> Signed-off-by: Roshan Khatri <[email protected]>
> ---
> drivers/staging/rtl8192e/rtllib_softmac.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
> index 97fdca828da7..0fc97c868f81 100644
> --- a/drivers/staging/rtl8192e/rtllib_softmac.c
> +++ b/drivers/staging/rtl8192e/rtllib_softmac.c
> @@ -421,7 +421,7 @@ static void rtllib_softmac_scan_syncro(struct rtllib_device *ieee)
> * So we switch to MAC80211_LINKED_SCANNING to remember
> * that we are still logically linked (not interested in
> * new network events, despite for updating the net list,
> - * but we are temporarly 'unlinked' as the driver shall
> + * but we are temporarily 'unlinked' as the driver shall
> * not filter RX frames and the channel is changing.
> * So the only situation in which are interested is to check
> * if the state become LINKED because of the #1 situation
> @@ -934,7 +934,7 @@ static void rtllib_associate_abort(struct rtllib_device *ieee)
>
> ieee->associate_seq++;
>
> - /* don't scan, and avoid to have the RX path possibily
> + /* don't scan, and avoid to have the RX path possibly
> * try again to associate. Even do not react to AUTH or
> * ASSOC response. Just wait for the retry wq to be scheduled.
> * Here we will check if there are good nets to associate
> @@ -1359,7 +1359,7 @@ static short rtllib_sta_ps_sleep(struct rtllib_device *ieee, u64 *time)
> return 0;
> timeout = ieee->current_network.beacon_interval;
> ieee->current_network.dtim_data = RTLLIB_DTIM_INVALID;
> - /* there's no need to nofity AP that I find you buffered
> + /* there's no need to notify AP that I find you buffered
> * with broadcast packet
> */
> if (dtim & (RTLLIB_DTIM_UCAST & ieee->ps))
> @@ -1806,7 +1806,7 @@ void rtllib_softmac_xmit(struct rtllib_txb *txb, struct rtllib_device *ieee)
>
> spin_lock_irqsave(&ieee->lock, flags);
>
> - /* called with 2nd parm 0, no tx mgmt lock required */
> + /* called with 2nd param 0, no tx mgmt lock required */
> rtllib_sta_wakeup(ieee, 0);
>
> /* update the tx status */
> --
> 2.34.1
>
>

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/process/submitting-patches.rst for what
needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot