2024-05-25 17:39:32

by Bjorn Andersson

Subject: [PATCH] arm64: dts: qcom: sc8180x: Fix LLCC reg property again

From: Bjorn Andersson <[email protected]>

Commit '74cf6675c35e ("arm64: dts: qcom: sc8180x: Fix LLCC reg
property")' transitioned the SC8180X LLCC node to describe each memory
region individually, but did not include all the regions.

The result is that Linux fails to find the last regions, so extend the
definition to cover all the blocks.

This also corrects the related DeviceTree validation error.

Fixes: 74cf6675c35e ("arm64: dts: qcom: sc8180x: Fix LLCC reg property")
Signed-off-by: Bjorn Andersson <[email protected]>
---
arch/arm64/boot/dts/qcom/sc8180x.dtsi | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
index 067712310560..581a70c34fd2 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
@@ -2647,11 +2647,14 @@ usb_sec_dpphy: dp-phy@88ef200 {

system-cache-controller@9200000 {
compatible = "qcom,sc8180x-llcc";
- reg = <0 0x09200000 0 0x50000>, <0 0x09280000 0 0x50000>,
- <0 0x09300000 0 0x50000>, <0 0x09380000 0 0x50000>,
- <0 0x09600000 0 0x50000>;
+ reg = <0 0x09200000 0 0x58000>, <0 0x09280000 0 0x58000>,
+ <0 0x09300000 0 0x58000>, <0 0x09380000 0 0x58000>,
+ <0 0x09400000 0 0x58000>, <0 0x09480000 0 0x58000>,
+ <0 0x09500000 0 0x58000>, <0 0x09580000 0 0x58000>,
+ <0 0x09600000 0 0x58000>;
reg-names = "llcc0_base", "llcc1_base", "llcc2_base",
- "llcc3_base", "llcc_broadcast_base";
+ "llcc3_base", "llcc4_base", "llcc5_base",
+ "llcc6_base", "llcc7_base", "llcc_broadcast_base";
interrupts = <GIC_SPI 582 IRQ_TYPE_LEVEL_HIGH>;
};


---
base-commit: 3689b0ef08b70e4e03b82ebd37730a03a672853a
change-id: 20240525-sc8180x-llcc-reg-fixup-7762256e8e5e

Best regards,
--
Bjorn Andersson <[email protected]>

2024-05-25 20:11:04

by Dmitry Baryshkov

Subject: Re: [PATCH] arm64: dts: qcom: sc8180x: Fix LLCC reg property again

On Sat, May 25, 2024 at 10:44:11AM -0700, Bjorn Andersson wrote:
> From: Bjorn Andersson <[email protected]>
>
> Commit '74cf6675c35e ("arm64: dts: qcom: sc8180x: Fix LLCC reg
> property")' transitioned the SC8180X LLCC node to describe each memory
> region individually, but did not include all the regions.
>
> The result is that Linux fails to find the last regions, so extend the
> definition to cover all the blocks.
>
> This also corrects the related DeviceTree validation error.
>
> Fixes: 74cf6675c35e ("arm64: dts: qcom: sc8180x: Fix LLCC reg property")
> Signed-off-by: Bjorn Andersson <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sc8180x.dtsi | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>

Reviewed-by: Dmitry Baryshkov <[email protected]>

--
With best wishes
Dmitry

2024-05-27 03:01:45

by Bjorn Andersson

Subject: Re: [PATCH] arm64: dts: qcom: sc8180x: Fix LLCC reg property again

On Sat, 25 May 2024 10:44:11 -0700, Bjorn Andersson wrote:
> Commit '74cf6675c35e ("arm64: dts: qcom: sc8180x: Fix LLCC reg
> property")' transitioned the SC8180X LLCC node to describe each memory
> region individually, but did not include all the regions.
>
> The result is that Linux fails to find the last regions, so extend the
> definition to cover all the blocks.
>
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: sc8180x: Fix LLCC reg property again
commit: 3df1627d8370a9c420b49743976b3eeba32afbbc

Best regards,
--
Bjorn Andersson <[email protected]>