2024-05-25 02:43:09

by kernel test robot

[permalink] [raw]
Subject: Re: [PATCH 10/13] mm/memory-failure: move some function declarations into internal.h

Hi Miaohe,

kernel test robot noticed the following build errors:

[auto build test ERROR on akpm-mm/mm-everything]
[also build test ERROR on linus/master next-20240523]
[cannot apply to v6.9]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Miaohe-Lin/mm-memory-failure-simplify-put_ref_page/20240524-171903
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20240524091310.1430048-11-linmiaohe%40huawei.com
patch subject: [PATCH 10/13] mm/memory-failure: move some function declarations into internal.h
config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20240525/[email protected]/config)
compiler: powerpc64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240525/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

drivers/vfio/vfio_iommu_spapr_tce.c: In function 'tce_page_is_contained':
>> drivers/vfio/vfio_iommu_spapr_tce.c:195:16: error: implicit declaration of function 'page_shift'; did you mean 'page_size'? [-Werror=implicit-function-declaration]
195 | return page_shift(compound_head(page)) >= it_page_shift;
| ^~~~~~~~~~
| page_size
cc1: some warnings being treated as errors
--
arch/powerpc/mm/book3s64/iommu_api.c: In function 'mm_iommu_do_alloc':
>> arch/powerpc/mm/book3s64/iommu_api.c:155:45: error: implicit declaration of function 'page_shift'; did you mean 'page_size'? [-Werror=implicit-function-declaration]
155 | pageshift = page_shift(compound_head(page));
| ^~~~~~~~~~
| page_size
cc1: some warnings being treated as errors
--
drivers/net/ethernet/ibm/ehea/ehea_qmr.c: In function 'ehea_is_hugepage':
>> drivers/net/ethernet/ibm/ehea/ehea_qmr.c:676:13: error: implicit declaration of function 'page_shift'; did you mean 'page_size'? [-Werror=implicit-function-declaration]
676 | if (page_shift(pfn_to_page(pfn)) != EHEA_HUGEPAGESHIFT)
| ^~~~~~~~~~
| page_size
cc1: some warnings being treated as errors


vim +195 drivers/vfio/vfio_iommu_spapr_tce.c

2157e7b82f3b81 Alexey Kardashevskiy 2015-06-05 179
c10c21efa4bcca Alexey Kardashevskiy 2018-12-19 180 static bool tce_page_is_contained(struct mm_struct *mm, unsigned long hpa,
94ad9338109fe9 Matthew Wilcox (Oracle 2019-09-23 181) unsigned int it_page_shift)
e432bc7e15d802 Alexey Kardashevskiy 2015-06-05 182 {
c10c21efa4bcca Alexey Kardashevskiy 2018-12-19 183 struct page *page;
c10c21efa4bcca Alexey Kardashevskiy 2018-12-19 184 unsigned long size = 0;
c10c21efa4bcca Alexey Kardashevskiy 2018-12-19 185
94ad9338109fe9 Matthew Wilcox (Oracle 2019-09-23 186) if (mm_iommu_is_devmem(mm, hpa, it_page_shift, &size))
94ad9338109fe9 Matthew Wilcox (Oracle 2019-09-23 187) return size == (1UL << it_page_shift);
c10c21efa4bcca Alexey Kardashevskiy 2018-12-19 188
c10c21efa4bcca Alexey Kardashevskiy 2018-12-19 189 page = pfn_to_page(hpa >> PAGE_SHIFT);
e432bc7e15d802 Alexey Kardashevskiy 2015-06-05 190 /*
e432bc7e15d802 Alexey Kardashevskiy 2015-06-05 191 * Check that the TCE table granularity is not bigger than the size of
e432bc7e15d802 Alexey Kardashevskiy 2015-06-05 192 * a page we just found. Otherwise the hardware can get access to
e432bc7e15d802 Alexey Kardashevskiy 2015-06-05 193 * a bigger memory chunk that it should.
e432bc7e15d802 Alexey Kardashevskiy 2015-06-05 194 */
94ad9338109fe9 Matthew Wilcox (Oracle 2019-09-23 @195) return page_shift(compound_head(page)) >= it_page_shift;
e432bc7e15d802 Alexey Kardashevskiy 2015-06-05 196 }
e432bc7e15d802 Alexey Kardashevskiy 2015-06-05 197

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki