Hi,
this is a new spin on the irqsteer bindings adding power-dmain support.
Thanks for the previous feedback. This v4 adds imx8mp specific compatible
to support power-domain.
Best regards,
Alexander
Changes in v4:
* Added imx8mp-specific compatible
* Restrict power-domains on non-imx8mp or non-imx8qxp SoCs
* Added patch for imx8mp.dtsi adjusting compatible
Alexander Stein (2):
dt-bindings: interrupt-controller: fsl,irqsteer: Add imx8mp/imx8qxp
support
arm64: dts: imx8mp: Add imx8mp-specific irqsteer compatible
.../interrupt-controller/fsl,irqsteer.yaml | 23 ++++++++++++++++++-
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
2 files changed, 23 insertions(+), 2 deletions(-)
--
2.34.1
Some SoC like i.MX8MP or i.MX8QXP use a power-domain for this IP. Add
SoC-specific compatibles, which also requires a power-domain.
Signed-off-by: Alexander Stein <[email protected]>
---
.../interrupt-controller/fsl,irqsteer.yaml | 23 ++++++++++++++++++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
index 20ad4ad82ad64..924995191404b 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
@@ -14,7 +14,10 @@ properties:
oneOf:
- const: fsl,imx-irqsteer
- items:
- - const: fsl,imx8m-irqsteer
+ - enum:
+ - fsl,imx8m-irqsteer
+ - fsl,imx8mp-irqsteer
+ - fsl,imx8qxp-irqsteer
- const: fsl,imx-irqsteer
reg:
@@ -42,6 +45,9 @@ properties:
clock-names:
const: ipg
+ power-domains:
+ maxItems: 1
+
interrupt-controller: true
"#interrupt-cells":
@@ -70,6 +76,21 @@ required:
- fsl,channel
- fsl,num-irqs
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - fsl,imx8mp-irqsteer
+ - fsl,imx8qxp-irqsteer
+ then:
+ required:
+ - power-domains
+ else:
+ properties:
+ power-domains: false
+
additionalProperties: false
examples:
--
2.34.1
i.MX8MP irqsteer has power-domain support, so use a dedicated compatible.
Signed-off-by: Alexander Stein <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index 8eb9f24007d00..fdaf7d5314384 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -1996,7 +1996,7 @@ hdmi_blk_ctrl: blk-ctrl@32fc0000 {
};
irqsteer_hdmi: interrupt-controller@32fc2000 {
- compatible = "fsl,imx-irqsteer";
+ compatible = "fsl,imx8mp-irqsteer", "fsl,imx-irqsteer";
reg = <0x32fc2000 0x1000>;
interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>;
interrupt-controller;
--
2.34.1
On Mon, 27 May 2024 10:34:01 +0200, Alexander Stein wrote:
> Some SoC like i.MX8MP or i.MX8QXP use a power-domain for this IP. Add
> SoC-specific compatibles, which also requires a power-domain.
>
> Signed-off-by: Alexander Stein <[email protected]>
> ---
> .../interrupt-controller/fsl,irqsteer.yaml | 23 ++++++++++++++++++-
> 1 file changed, 22 insertions(+), 1 deletion(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml:85:17: [warning] wrong indentation: expected 14 but found 16 (indentation)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
On Mon, May 27, 2024 at 10:34:01AM +0200, Alexander Stein wrote:
> Some SoC like i.MX8MP or i.MX8QXP use a power-domain for this IP. Add
> SoC-specific compatibles, which also requires a power-domain.
>
> Signed-off-by: Alexander Stein <[email protected]>
With the indentation fixed
Reviewed-by: Conor Dooley <[email protected]>
Cheers,
Conor.