2024-05-27 10:56:46

by Thorsten Blum

Subject: [PATCH net] net: smc91x: Remove commented out code

Remove commented out code

Signed-off-by: Thorsten Blum <[email protected]>
---
drivers/net/ethernet/smsc/smc91x.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c
index 78ff3af7911a..907498848028 100644
--- a/drivers/net/ethernet/smsc/smc91x.c
+++ b/drivers/net/ethernet/smsc/smc91x.c
@@ -1574,12 +1574,8 @@ smc_ethtool_set_link_ksettings(struct net_device *dev,
(cmd->base.port != PORT_TP && cmd->base.port != PORT_AUI))
return -EINVAL;

-// lp->port = cmd->base.port;
lp->ctl_rfduplx = cmd->base.duplex == DUPLEX_FULL;

-// if (netif_running(dev))
-// smc_set_port(dev);
-
ret = 0;
}

--
2.45.1

2024-05-28 13:37:32

by Paolo Abeni

Subject: Re: [PATCH net] net: smc91x: Remove commented out code

Hi,

On Mon, 2024-05-27 at 12:55 +0200, Thorsten Blum wrote:
> Remove commented out code
>
> Signed-off-by: Thorsten Blum <[email protected]>
> ---
> drivers/net/ethernet/smsc/smc91x.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c
> index 78ff3af7911a..907498848028 100644
> --- a/drivers/net/ethernet/smsc/smc91x.c
> +++ b/drivers/net/ethernet/smsc/smc91x.c
> @@ -1574,12 +1574,8 @@ smc_ethtool_set_link_ksettings(struct net_device *dev,
> (cmd->base.port != PORT_TP && cmd->base.port != PORT_AUI))
> return -EINVAL;
>
> -// lp->port = cmd->base.port;
> lp->ctl_rfduplx = cmd->base.duplex == DUPLEX_FULL;
>
> -// if (netif_running(dev))
> -// smc_set_port(dev);
> -
> ret = 0;
> }
>
This is net-next material, please re-submit targeting the correct tree
in the subj prefix.

Thanks

Paolo

2024-05-29 12:28:34

by Thorsten Blum

Subject: Re: [PATCH net] net: smc91x: Remove commented out code

On 28. May 2024, at 15:36, Paolo Abeni <[email protected]> wrote:
> This is net-next material, please re-submit targeting the correct tree
> in the subj prefix.

Hi Paolo, I resubmitted the patch [1] with the correct prefix.

Thanks,
Thorsten

[1] https://lore.kernel.org/linux-kernel/[email protected]/