Hi,
this is a new spin on the irqsteer bindings adding power-dmain support.
Thanks for the previous feedback.
Best regards,
Alexander
Changes in v5:
* Fixed indentation
* Added Conor's R-b
Changes in v4:
* Added imx8mp-specific compatible
* Restrict power-domains on non-imx8mp or non-imx8qxp SoCs
* Added patch for imx8mp.dtsi adjusting compatible
Alexander Stein (2):
dt-bindings: interrupt-controller: fsl,irqsteer: Add imx8mp/imx8qxp
support
arm64: dts: imx8mp: Add imx8mp-specific irqsteer compatible
.../interrupt-controller/fsl,irqsteer.yaml | 23 ++++++++++++++++++-
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
2 files changed, 23 insertions(+), 2 deletions(-)
--
2.34.1
Some SoC like i.MX8MP or i.MX8QXP use a power-domain for this IP. Add
SoC-specific compatibles, which also requires a power-domain.
Signed-off-by: Alexander Stein <[email protected]>
Reviewed-by: Conor Dooley <[email protected]>
---
.../interrupt-controller/fsl,irqsteer.yaml | 23 ++++++++++++++++++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
index 20ad4ad82ad64..aae676ba30edc 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
@@ -14,7 +14,10 @@ properties:
oneOf:
- const: fsl,imx-irqsteer
- items:
- - const: fsl,imx8m-irqsteer
+ - enum:
+ - fsl,imx8m-irqsteer
+ - fsl,imx8mp-irqsteer
+ - fsl,imx8qxp-irqsteer
- const: fsl,imx-irqsteer
reg:
@@ -42,6 +45,9 @@ properties:
clock-names:
const: ipg
+ power-domains:
+ maxItems: 1
+
interrupt-controller: true
"#interrupt-cells":
@@ -70,6 +76,21 @@ required:
- fsl,channel
- fsl,num-irqs
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - fsl,imx8mp-irqsteer
+ - fsl,imx8qxp-irqsteer
+ then:
+ required:
+ - power-domains
+ else:
+ properties:
+ power-domains: false
+
additionalProperties: false
examples:
--
2.34.1
i.MX8MP irqsteer has power-domain support, so use a dedicated compatible.
Signed-off-by: Alexander Stein <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index 8eb9f24007d00..fdaf7d5314384 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -1996,7 +1996,7 @@ hdmi_blk_ctrl: blk-ctrl@32fc0000 {
};
irqsteer_hdmi: interrupt-controller@32fc2000 {
- compatible = "fsl,imx-irqsteer";
+ compatible = "fsl,imx8mp-irqsteer", "fsl,imx-irqsteer";
reg = <0x32fc2000 0x1000>;
interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>;
interrupt-controller;
--
2.34.1
Hi,
Am Dienstag, 28. Mai 2024, 09:11:41 CEST schrieb Alexander Stein:
> i.MX8MP irqsteer has power-domain support, so use a dedicated compatible.
>
> Signed-off-by: Alexander Stein <[email protected]>
> ---
> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index 8eb9f24007d00..fdaf7d5314384 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -1996,7 +1996,7 @@ hdmi_blk_ctrl: blk-ctrl@32fc0000 {
> };
>
> irqsteer_hdmi: interrupt-controller@32fc2000 {
> - compatible = "fsl,imx-irqsteer";
> + compatible = "fsl,imx8mp-irqsteer", "fsl,imx-irqsteer";
> reg = <0x32fc2000 0x1000>;
> interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-controller;
>
Any feedback on this?
Thanks,
Alexander
--
TQ-Systems GmbH | M?hlstra?e 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht M?nchen, HRB 105018
Gesch?ftsf?hrer: Detlef Schneider, R?diger Stahl, Stefan Schneider
http://www.tq-group.com/
On Tue, 28 May 2024 09:11:40 +0200, Alexander Stein wrote:
> Some SoC like i.MX8MP or i.MX8QXP use a power-domain for this IP. Add
> SoC-specific compatibles, which also requires a power-domain.
>
> Signed-off-by: Alexander Stein <[email protected]>
> Reviewed-by: Conor Dooley <[email protected]>
> ---
> .../interrupt-controller/fsl,irqsteer.yaml | 23 ++++++++++++++++++-
> 1 file changed, 22 insertions(+), 1 deletion(-)
>
Applied, thanks!
On Tue, May 28, 2024 at 09:11:41AM +0200, Alexander Stein wrote:
> i.MX8MP irqsteer has power-domain support, so use a dedicated compatible.
>
> Signed-off-by: Alexander Stein <[email protected]>
Applied, thanks!