2024-05-28 23:18:06

by Dr. David Alan Gilbert

Subject: [PATCH] soc/fsl/qbman: remove unused struct 'cgr_comp'

From: "Dr. David Alan Gilbert" <[email protected]>

'cgr_comp' has been unused since
commit 96f413f47677 ("soc/fsl/qbman: fix issue in
qman_delete_cgr_safe()").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
drivers/soc/fsl/qbman/qman.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c
index 7e9074519ad2..4dc8aba33d9b 100644
--- a/drivers/soc/fsl/qbman/qman.c
+++ b/drivers/soc/fsl/qbman/qman.c
@@ -2546,11 +2546,6 @@ int qman_delete_cgr(struct qman_cgr *cgr)
}
EXPORT_SYMBOL(qman_delete_cgr);

-struct cgr_comp {
- struct qman_cgr *cgr;
- struct completion completion;
-};
-
static void qman_delete_cgr_smp_call(void *p)
{
qman_delete_cgr((struct qman_cgr *)p);
--
2.45.1

2024-05-30 14:59:20

by Sean Anderson

Subject: Re: [PATCH] soc/fsl/qbman: remove unused struct 'cgr_comp'

On 5/28/24 19:11, [email protected] wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> 'cgr_comp' has been unused since
> commit 96f413f47677 ("soc/fsl/qbman: fix issue in
> qman_delete_cgr_safe()").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>
> ---
> drivers/soc/fsl/qbman/qman.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c
> index 7e9074519ad2..4dc8aba33d9b 100644
> --- a/drivers/soc/fsl/qbman/qman.c
> +++ b/drivers/soc/fsl/qbman/qman.c
> @@ -2546,11 +2546,6 @@ int qman_delete_cgr(struct qman_cgr *cgr)
> }
> EXPORT_SYMBOL(qman_delete_cgr);
>
> -struct cgr_comp {
> - struct qman_cgr *cgr;
> - struct completion completion;
> -};
> -
> static void qman_delete_cgr_smp_call(void *p)
> {
> qman_delete_cgr((struct qman_cgr *)p);

Reviewed-by: Sean Anderson <[email protected]>