2024-05-29 08:49:07

by Christian Brauner

[permalink] [raw]
Subject: Re: [PATCH] statx: Update offset commentary for struct statx

On Wed, May 29, 2024 at 08:17:25AM +0000, John Garry wrote:
> In commit 2a82bb02941f ("statx: stx_subvol"), a new member was added to
> struct statx, but the offset comment was not correct. Update it.
>
> Signed-off-by: John Garry <[email protected]>
>
> diff --git a/include/uapi/linux/stat.h b/include/uapi/linux/stat.h
> index 67626d535316..95770941ee2c 100644
> --- a/include/uapi/linux/stat.h
> +++ b/include/uapi/linux/stat.h
> @@ -126,8 +126,8 @@ struct statx {
> __u64 stx_mnt_id;
> __u32 stx_dio_mem_align; /* Memory buffer alignment for direct I/O */
> __u32 stx_dio_offset_align; /* File offset alignment for direct I/O */
> - __u64 stx_subvol; /* Subvolume identifier */
> /* 0xa0 */
> + __u64 stx_subvol; /* Subvolume identifier */
> __u64 __spare3[11]; /* Spare space for future expansion */
> /* 0x100 */
> };
> --
> 2.31.1
>

Thanks, applied.
But note that your patch format seems to have tripped b4. I had to apply
it manually.


2024-05-29 20:03:38

by Konstantin Ryabitsev

[permalink] [raw]
Subject: Re: [PATCH] statx: Update offset commentary for struct statx

On Wed, May 29, 2024 at 10:42:48AM GMT, Christian Brauner wrote:
> But note that your patch format seems to have tripped b4. I had to apply
> it manually.

Looks like it was some mail relay that QP-encoded DKIM headers.
I've committed a fix for it.

Cheers,
-K