2024-05-29 17:53:26

by Dr. David Alan Gilbert

Subject: [PATCH] thermal: int3403: remove unused struct 'int3403_performance_state'

From: "Dr. David Alan Gilbert" <[email protected]>

'int3403_performance_state' has never been used since the original
commit 4384b8fe162d ("Thermal: introduce int3403 thermal driver").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
.../thermal/intel/int340x_thermal/int3403_thermal.c | 11 -----------
1 file changed, 11 deletions(-)

diff --git a/drivers/thermal/intel/int340x_thermal/int3403_thermal.c b/drivers/thermal/intel/int340x_thermal/int3403_thermal.c
index 86901f9f54d8..c094a422ded3 100644
--- a/drivers/thermal/intel/int340x_thermal/int3403_thermal.c
+++ b/drivers/thermal/intel/int340x_thermal/int3403_thermal.c
@@ -25,17 +25,6 @@ struct int3403_sensor {
struct int34x_thermal_zone *int340x_zone;
};

-struct int3403_performance_state {
- u64 performance;
- u64 power;
- u64 latency;
- u64 linear;
- u64 control;
- u64 raw_performace;
- char *raw_unit;
- int reserved;
-};
-
struct int3403_cdev {
struct thermal_cooling_device *cdev;
unsigned long max_state;
--
2.45.1

2024-05-30 07:21:12

by Zhang, Rui

Subject: Re: [PATCH] thermal: int3403: remove unused struct 'int3403_performance_state'

On Wed, 2024-05-29 at 18:53 +0100, [email protected] wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> 'int3403_performance_state' has never been used since the original
> commit 4384b8fe162d ("Thermal: introduce int3403 thermal driver").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>

Acked-by: Zhang Rui <[email protected]>


> ---
>  .../thermal/intel/int340x_thermal/int3403_thermal.c   | 11 ---------
> --
>  1 file changed, 11 deletions(-)
>
> diff --git a/drivers/thermal/intel/int340x_thermal/int3403_thermal.c
> b/drivers/thermal/intel/int340x_thermal/int3403_thermal.c
> index 86901f9f54d8..c094a422ded3 100644
> --- a/drivers/thermal/intel/int340x_thermal/int3403_thermal.c
> +++ b/drivers/thermal/intel/int340x_thermal/int3403_thermal.c
> @@ -25,17 +25,6 @@ struct int3403_sensor {
>         struct int34x_thermal_zone *int340x_zone;
>  };
>  
> -struct int3403_performance_state {
> -       u64 performance;
> -       u64 power;
> -       u64 latency;
> -       u64 linear;
> -       u64 control;
> -       u64 raw_performace;
> -       char *raw_unit;
> -       int reserved;
> -};
> -
>  struct int3403_cdev {
>         struct thermal_cooling_device *cdev;
>         unsigned long max_state;

2024-06-07 19:25:36

by Rafael J. Wysocki

Subject: Re: [PATCH] thermal: int3403: remove unused struct 'int3403_performance_state'

On Thu, May 30, 2024 at 9:21 AM Zhang, Rui <[email protected]> wrote:
>
> On Wed, 2024-05-29 at 18:53 +0100, [email protected] wrote:
> > From: "Dr. David Alan Gilbert" <[email protected]>
> >
> > 'int3403_performance_state' has never been used since the original
> > commit 4384b8fe162d ("Thermal: introduce int3403 thermal driver").
> >
> > Remove it.
> >
> > Signed-off-by: Dr. David Alan Gilbert <[email protected]>
>
> Acked-by: Zhang Rui <[email protected]>

Applied as 6.11 material, thanks!

> > ---
> > .../thermal/intel/int340x_thermal/int3403_thermal.c | 11 ---------
> > --
> > 1 file changed, 11 deletions(-)
> >
> > diff --git a/drivers/thermal/intel/int340x_thermal/int3403_thermal.c
> > b/drivers/thermal/intel/int340x_thermal/int3403_thermal.c
> > index 86901f9f54d8..c094a422ded3 100644
> > --- a/drivers/thermal/intel/int340x_thermal/int3403_thermal.c
> > +++ b/drivers/thermal/intel/int340x_thermal/int3403_thermal.c
> > @@ -25,17 +25,6 @@ struct int3403_sensor {
> > struct int34x_thermal_zone *int340x_zone;
> > };
> >
> > -struct int3403_performance_state {
> > - u64 performance;
> > - u64 power;
> > - u64 latency;
> > - u64 linear;
> > - u64 control;
> > - u64 raw_performace;
> > - char *raw_unit;
> > - int reserved;
> > -};
> > -
> > struct int3403_cdev {
> > struct thermal_cooling_device *cdev;
> > unsigned long max_state;
>