2024-05-30 05:21:31

by Duoming Zhou

Subject: [PATCH net] ax25: Replace kfree() in ax25_dev_free() with ax25_dev_put()

The object "ax25_dev" is managed by reference counting. Thus it should
not be directly released by kfree(), replace with ax25_dev_put().

Fixes: d01ffb9eee4a ("ax25: add refcount in ax25_dev to avoid UAF bugs")
Suggested-by: Dan Carpenter <[email protected]>
Signed-off-by: Duoming Zhou <[email protected]>
---
net/ax25/ax25_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ax25/ax25_dev.c b/net/ax25/ax25_dev.c
index 742d7c68e7e..9efd6690b34 100644
--- a/net/ax25/ax25_dev.c
+++ b/net/ax25/ax25_dev.c
@@ -196,7 +196,7 @@ void __exit ax25_dev_free(void)
list_for_each_entry_safe(s, n, &ax25_dev_list, list) {
netdev_put(s->dev, &s->dev_tracker);
list_del(&s->list);
- kfree(s);
+ ax25_dev_put(s);
}
spin_unlock_bh(&ax25_dev_lock);
}
--
2.17.1

2024-05-30 05:23:38

by Dan Carpenter

Subject: Re: [PATCH net] ax25: Replace kfree() in ax25_dev_free() with ax25_dev_put()

On Thu, May 30, 2024 at 01:17:33PM +0800, Duoming Zhou wrote:
> The object "ax25_dev" is managed by reference counting. Thus it should
> not be directly released by kfree(), replace with ax25_dev_put().
>
> Fixes: d01ffb9eee4a ("ax25: add refcount in ax25_dev to avoid UAF bugs")
> Suggested-by: Dan Carpenter <[email protected]>
> Signed-off-by: Duoming Zhou <[email protected]>

Thanks!

Reviewed-by: Dan Carpenter <[email protected]>

regards,
dan carpenter

2024-06-01 23:00:47

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net] ax25: Replace kfree() in ax25_dev_free() with ax25_dev_put()

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

On Thu, 30 May 2024 13:17:33 +0800 you wrote:
> The object "ax25_dev" is managed by reference counting. Thus it should
> not be directly released by kfree(), replace with ax25_dev_put().
>
> Fixes: d01ffb9eee4a ("ax25: add refcount in ax25_dev to avoid UAF bugs")
> Suggested-by: Dan Carpenter <[email protected]>
> Signed-off-by: Duoming Zhou <[email protected]>
>
> [...]

Here is the summary with links:
- [net] ax25: Replace kfree() in ax25_dev_free() with ax25_dev_put()
https://git.kernel.org/netdev/net/c/166fcf86cd34

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html