2024-05-30 13:26:42

by Dr. David Alan Gilbert

[permalink] [raw]
Subject: [PATCH v2 0/3] Dead structs in media/platform

From: "Dr. David Alan Gilbert" <[email protected]>

Clean out a bunch of dead structs in media/platform.
Build tested only.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>

v2:
Removed tegra_vde_h264_frame declaration in header
Typo in first subject line

Dr. David Alan Gilbert (3):
media: amphion: remove unused struct 'vpu_malone_frame_buffer'
media: m2m-deinterlace: remove unused struct 'vb2_dc_conf'
media: tegra-vde: remove unused struct 'tegra_vde_h264_frame'

drivers/media/platform/amphion/vpu_malone.c | 5 -----
drivers/media/platform/m2m-deinterlace.c | 4 ----
drivers/media/platform/nvidia/tegra-vde/h264.c | 5 -----
drivers/media/platform/nvidia/tegra-vde/vde.h | 1 -
4 files changed, 15 deletions(-)

--
2.45.1



2024-05-30 13:26:53

by Dr. David Alan Gilbert

[permalink] [raw]
Subject: [PATCH v2 1/3] media: amphion: remove unused struct 'vpu_malone_frame_buffer'

From: "Dr. David Alan Gilbert" <[email protected]>

'vpu_malone_frame_buffer' has been unused since the original
commit 145e936380ed ("media: amphion: implement malone decoder rpc
interface").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
drivers/media/platform/amphion/vpu_malone.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/media/platform/amphion/vpu_malone.c b/drivers/media/platform/amphion/vpu_malone.c
index d3425de7bccd..4769c053c6c2 100644
--- a/drivers/media/platform/amphion/vpu_malone.c
+++ b/drivers/media/platform/amphion/vpu_malone.c
@@ -207,11 +207,6 @@ struct vpu_malone_dbglog_desc {
u32 reserved;
};

-struct vpu_malone_frame_buffer {
- u32 addr;
- u32 size;
-};
-
struct vpu_malone_udata {
u32 base;
u32 total_size;
--
2.45.1


2024-05-30 13:26:55

by Dr. David Alan Gilbert

[permalink] [raw]
Subject: [PATCH v2 2/3] media: m2m-deinterlace: remove unused struct 'vb2_dc_conf'

From: "Dr. David Alan Gilbert" <[email protected]>

'vb2_dc_conf' has been unused since the original
commit 8f0755c06b90 ("[media] media: Add mem2mem deinterlacing driver").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
drivers/media/platform/m2m-deinterlace.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/media/platform/m2m-deinterlace.c b/drivers/media/platform/m2m-deinterlace.c
index 96b35a5d6174..5adcef80c698 100644
--- a/drivers/media/platform/m2m-deinterlace.c
+++ b/drivers/media/platform/m2m-deinterlace.c
@@ -724,10 +724,6 @@ static const struct v4l2_ioctl_ops deinterlace_ioctl_ops = {
/*
* Queue operations
*/
-struct vb2_dc_conf {
- struct device *dev;
-};
-
static int deinterlace_queue_setup(struct vb2_queue *vq,
unsigned int *nbuffers, unsigned int *nplanes,
unsigned int sizes[], struct device *alloc_devs[])
--
2.45.1


2024-05-30 13:27:12

by Dr. David Alan Gilbert

[permalink] [raw]
Subject: [PATCH v2 3/3] media: tegra-vde: remove unused struct 'tegra_vde_h264_frame'

From: "Dr. David Alan Gilbert" <[email protected]>

'tegra_vde_h264_frame' has been unused since
commit 313db7d235a0 ("media: staging: tegra-vde: Remove legacy UAPI
support").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
drivers/media/platform/nvidia/tegra-vde/h264.c | 5 -----
drivers/media/platform/nvidia/tegra-vde/vde.h | 1 -
2 files changed, 6 deletions(-)

diff --git a/drivers/media/platform/nvidia/tegra-vde/h264.c b/drivers/media/platform/nvidia/tegra-vde/h264.c
index cfea5572a1b8..d8812fc06c67 100644
--- a/drivers/media/platform/nvidia/tegra-vde/h264.c
+++ b/drivers/media/platform/nvidia/tegra-vde/h264.c
@@ -19,11 +19,6 @@
#define FLAG_B_FRAME 0x1
#define FLAG_REFERENCE 0x2

-struct tegra_vde_h264_frame {
- unsigned int frame_num;
- unsigned int flags;
-};
-
struct tegra_vde_h264_decoder_ctx {
unsigned int dpb_frames_nb;
unsigned int dpb_ref_frames_with_earlier_poc_nb;
diff --git a/drivers/media/platform/nvidia/tegra-vde/vde.h b/drivers/media/platform/nvidia/tegra-vde/vde.h
index 0fbb1f3d2c88..b2890484b7c3 100644
--- a/drivers/media/platform/nvidia/tegra-vde/vde.h
+++ b/drivers/media/platform/nvidia/tegra-vde/vde.h
@@ -47,7 +47,6 @@ struct iommu_group;
struct iommu_domain;
struct reset_control;
struct dma_buf_attachment;
-struct tegra_vde_h264_frame;
struct tegra_vde_h264_decoder_ctx;

struct tegra_video_frame {
--
2.45.1


2024-05-30 14:59:48

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH v2 3/3] media: tegra-vde: remove unused struct 'tegra_vde_h264_frame'

On Thu May 30, 2024 at 3:26 PM CEST, wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> 'tegra_vde_h264_frame' has been unused since
> commit 313db7d235a0 ("media: staging: tegra-vde: Remove legacy UAPI
> support").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>
> ---
> drivers/media/platform/nvidia/tegra-vde/h264.c | 5 -----
> drivers/media/platform/nvidia/tegra-vde/vde.h | 1 -
> 2 files changed, 6 deletions(-)

Not that you really need it, but since I'm here:

Acked-by: Thierry Reding <[email protected]>


Attachments:
signature.asc (849.00 B)

2024-05-30 15:29:02

by Dr. David Alan Gilbert

[permalink] [raw]
Subject: Re: [PATCH v2 3/3] media: tegra-vde: remove unused struct 'tegra_vde_h264_frame'

* Thierry Reding ([email protected]) wrote:
> On Thu May 30, 2024 at 3:26 PM CEST, wrote:
> > From: "Dr. David Alan Gilbert" <[email protected]>
> >
> > 'tegra_vde_h264_frame' has been unused since
> > commit 313db7d235a0 ("media: staging: tegra-vde: Remove legacy UAPI
> > support").
> >
> > Remove it.
> >
> > Signed-off-by: Dr. David Alan Gilbert <[email protected]>
> > ---
> > drivers/media/platform/nvidia/tegra-vde/h264.c | 5 -----
> > drivers/media/platform/nvidia/tegra-vde/vde.h | 1 -
> > 2 files changed, 6 deletions(-)
>
> Not that you really need it, but since I'm here:
>
> Acked-by: Thierry Reding <[email protected]>

Thanks!

Dave


--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/