2024-05-30 16:56:05

by Hari Nagalla

Subject: [PATCH v2] dt-bindings: remoteproc: k3-dsp: correct optional sram properties for AM62A SoCs

The C7xv-dsp on AM62A have 32KB L1 I-cache and a 64KB L1 D-cache. It
does not have an addressable l1dram . So, remove this optional sram
property from the bindings to fix device tree build warnings.

Signed-off-by: Hari Nagalla <[email protected]>
---
Changes from v1 to v2:
*) Kept back memory-regions property, as it is unrelated to this patch
correcting the sram property for AM62A C7xv-dsp nodes.

DT binding check log:
https://paste.sr.ht/~hnagalla/cb26237560a572a17c0874b687353e00b400285a

v1: https://lore.kernel.org/all/[email protected]/

.../bindings/remoteproc/ti,k3-dsp-rproc.yaml | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
index 9768db8663eb..771cfceb5458 100644
--- a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
@@ -111,7 +111,6 @@ else:
properties:
compatible:
enum:
- - ti,am62a-c7xv-dsp
- ti,j721e-c71-dsp
- ti,j721s2-c71-dsp
then:
@@ -124,6 +123,20 @@ else:
items:
- const: l2sram
- const: l1dram
+ else:
+ if:
+ properties:
+ compatible:
+ enum:
+ - ti,am62a-c7xv-dsp
+ then:
+ properties:
+ reg:
+ items:
+ - description: Address and Size of the L2 SRAM internal memory region
+ reg-names:
+ items:
+ - const: l2sram

required:
- compatible
--
2.34.1

2024-05-31 08:30:31

by Krzysztof Kozlowski

Subject: Re: [PATCH v2] dt-bindings: remoteproc: k3-dsp: correct optional sram properties for AM62A SoCs

On 30/05/2024 18:48, Hari Nagalla wrote:
> The C7xv-dsp on AM62A have 32KB L1 I-cache and a 64KB L1 D-cache. It
> does not have an addressable l1dram . So, remove this optional sram
> property from the bindings to fix device tree build warnings.
>
> Signed-off-by: Hari Nagalla <[email protected]>
> ---
> Changes from v1 to v2:
> *) Kept back memory-regions property, as it is unrelated to this patch
> correcting the sram property for AM62A C7xv-dsp nodes.
>
> DT binding check log:
> https://paste.sr.ht/~hnagalla/cb26237560a572a17c0874b687353e00b400285a
>
> v1: https://lore.kernel.org/all/[email protected]/
>
> .../bindings/remoteproc/ti,k3-dsp-rproc.yaml | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> index 9768db8663eb..771cfceb5458 100644
> --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> @@ -111,7 +111,6 @@ else:
> properties:
> compatible:
> enum:
> - - ti,am62a-c7xv-dsp
> - ti,j721e-c71-dsp
> - ti,j721s2-c71-dsp
> then:
> @@ -124,6 +123,20 @@ else:
> items:
> - const: l2sram
> - const: l1dram
> + else:
> + if:

Please use allOf (move top one to bottom) and define separate ifs for
each variant instead of nesting them.

Best regards,
Krzysztof