2024-05-31 10:46:54

by Thorsten Blum

Subject: [RESEND PATCH] accel/habanalabs/gaudi2: Use kvfree() for memory allocated with kvcalloc()

Use kvfree() to fix the following Coccinelle/coccicheck warning reported
by kfree_mismatch.cocci:

WARNING kvmalloc is used to allocate this memory at line 10398

Signed-off-by: Thorsten Blum <[email protected]>
---
drivers/accel/habanalabs/gaudi2/gaudi2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/accel/habanalabs/gaudi2/gaudi2.c b/drivers/accel/habanalabs/gaudi2/gaudi2.c
index fa1c4feb9f89..8024047962ec 100644
--- a/drivers/accel/habanalabs/gaudi2/gaudi2.c
+++ b/drivers/accel/habanalabs/gaudi2/gaudi2.c
@@ -10489,7 +10489,7 @@ static int gaudi2_memset_device_memory(struct hl_device *hdev, u64 addr, u64 siz
(u64 *)(lin_dma_pkts_arr), DEBUGFS_WRITE64);
WREG32(sob_addr, 0);

- kfree(lin_dma_pkts_arr);
+ kvfree(lin_dma_pkts_arr);

return rc;
}
--
2.45.1

2024-05-31 12:23:54

by Tomer Tayar

Subject: Re: [RESEND PATCH] accel/habanalabs/gaudi2: Use kvfree() for memory allocated with kvcalloc()

On 31/05/2024 13:46, Thorsten Blum wrote:
> Use kvfree() to fix the following Coccinelle/coccicheck warning reported
> by kfree_mismatch.cocci:
>
> WARNING kvmalloc is used to allocate this memory at line 10398
>
> Signed-off-by: Thorsten Blum <[email protected]>

Reviewed-by: Tomer Tayar <[email protected]>

> ---
> drivers/accel/habanalabs/gaudi2/gaudi2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accel/habanalabs/gaudi2/gaudi2.c b/drivers/accel/habanalabs/gaudi2/gaudi2.c
> index fa1c4feb9f89..8024047962ec 100644
> --- a/drivers/accel/habanalabs/gaudi2/gaudi2.c
> +++ b/drivers/accel/habanalabs/gaudi2/gaudi2.c
> @@ -10489,7 +10489,7 @@ static int gaudi2_memset_device_memory(struct hl_device *hdev, u64 addr, u64 siz
> (u64 *)(lin_dma_pkts_arr), DEBUGFS_WRITE64);
> WREG32(sob_addr, 0);
>
> - kfree(lin_dma_pkts_arr);
> + kvfree(lin_dma_pkts_arr);
>
> return rc;
> }