2024-05-25 23:25:45

by Dr. David Alan Gilbert

[permalink] [raw]
Subject: [PATCH] can: mscan: remove unused struct 'mscan_state'

From: "Dr. David Alan Gilbert" <[email protected]>

'mscan_state' is unused since the original
commit afa17a500a36 ("net/can: add driver for mscan family &
mpc52xx_mscan").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
drivers/net/can/mscan/mscan.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/net/can/mscan/mscan.c b/drivers/net/can/mscan/mscan.c
index a6829cdc0e81..8c2a7bc64d3d 100644
--- a/drivers/net/can/mscan/mscan.c
+++ b/drivers/net/can/mscan/mscan.c
@@ -34,12 +34,6 @@ static const struct can_bittiming_const mscan_bittiming_const = {
.brp_inc = 1,
};

-struct mscan_state {
- u8 mode;
- u8 canrier;
- u8 cantier;
-};
-
static enum can_state state_map[] = {
CAN_STATE_ERROR_ACTIVE,
CAN_STATE_ERROR_WARNING,
--
2.45.1



2024-05-31 15:40:53

by Simon Horman

[permalink] [raw]
Subject: Re: [PATCH] can: mscan: remove unused struct 'mscan_state'

On Sun, May 26, 2024 at 12:25:09AM +0100, [email protected] wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> 'mscan_state' is unused since the original
> commit afa17a500a36 ("net/can: add driver for mscan family &
> mpc52xx_mscan").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>

Reviewed-by: Simon Horman <[email protected]>


2024-06-03 10:58:24

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH] can: mscan: remove unused struct 'mscan_state'


> 'mscan_state' is unused since the original
> commit afa17a500a36 ("net/can: add driver for mscan family &
> mpc52xx_mscan").
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>

Wow, that driver was a long time ago. Thanks for the flashback :)

Reviewed-by: Wolfram Sang <[email protected]>


Attachments:
(No filename) (350.00 B)
signature.asc (849.00 B)
Download all attachments