2024-06-02 01:32:21

by Jeff Johnson

Subject: [PATCH] samples: kprobes: add missing MODULE_DESCRIPTION() macros

make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in samples/kprobes/kprobe_example.o
WARNING: modpost: missing MODULE_DESCRIPTION() in samples/kprobes/kretprobe_example.o

Add the missing invocations of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <[email protected]>
---
samples/kprobes/kprobe_example.c | 1 +
samples/kprobes/kretprobe_example.c | 1 +
2 files changed, 2 insertions(+)

diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c
index ef44c614c6d9..53ec6c8b8c40 100644
--- a/samples/kprobes/kprobe_example.c
+++ b/samples/kprobes/kprobe_example.c
@@ -125,4 +125,5 @@ static void __exit kprobe_exit(void)

module_init(kprobe_init)
module_exit(kprobe_exit)
+MODULE_DESCRIPTION("sample kernel module showing the use of kprobes");
MODULE_LICENSE("GPL");
diff --git a/samples/kprobes/kretprobe_example.c b/samples/kprobes/kretprobe_example.c
index ed79fd3d48fb..65d6dcafd742 100644
--- a/samples/kprobes/kretprobe_example.c
+++ b/samples/kprobes/kretprobe_example.c
@@ -104,4 +104,5 @@ static void __exit kretprobe_exit(void)

module_init(kretprobe_init)
module_exit(kretprobe_exit)
+MODULE_DESCRIPTION("sample kernel module showing the use of return probes");
MODULE_LICENSE("GPL");

---
base-commit: b050496579632f86ee1ef7e7501906db579f3457
change-id: 20240601-md-samples-kprobes-efb32cbcc8dd

2024-06-02 02:30:40

by Masami Hiramatsu

Subject: Re: [PATCH] samples: kprobes: add missing MODULE_DESCRIPTION() macros

On Sat, 1 Jun 2024 18:31:55 -0700
Jeff Johnson <[email protected]> wrote:

> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in samples/kprobes/kprobe_example.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in samples/kprobes/kretprobe_example.o
>
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>

OK, these are also good to me too.

Thanks,

> Signed-off-by: Jeff Johnson <[email protected]>
> ---
> samples/kprobes/kprobe_example.c | 1 +
> samples/kprobes/kretprobe_example.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c
> index ef44c614c6d9..53ec6c8b8c40 100644
> --- a/samples/kprobes/kprobe_example.c
> +++ b/samples/kprobes/kprobe_example.c
> @@ -125,4 +125,5 @@ static void __exit kprobe_exit(void)
>
> module_init(kprobe_init)
> module_exit(kprobe_exit)
> +MODULE_DESCRIPTION("sample kernel module showing the use of kprobes");
> MODULE_LICENSE("GPL");
> diff --git a/samples/kprobes/kretprobe_example.c b/samples/kprobes/kretprobe_example.c
> index ed79fd3d48fb..65d6dcafd742 100644
> --- a/samples/kprobes/kretprobe_example.c
> +++ b/samples/kprobes/kretprobe_example.c
> @@ -104,4 +104,5 @@ static void __exit kretprobe_exit(void)
>
> module_init(kretprobe_init)
> module_exit(kretprobe_exit)
> +MODULE_DESCRIPTION("sample kernel module showing the use of return probes");
> MODULE_LICENSE("GPL");
>
> ---
> base-commit: b050496579632f86ee1ef7e7501906db579f3457
> change-id: 20240601-md-samples-kprobes-efb32cbcc8dd
>


--
Masami Hiramatsu (Google) <[email protected]>