2024-06-03 12:49:24

by Dmitry Baryshkov

Subject: [PATCH] arm64: dts: qcom: qrb4210-rb2: make L9A always-on

The L9A regulator is used to further control voltage regulators on the
board. Make sure that is stays always on to prevent undervolting some of
the volage rails.

Fixes: 8d58a8c0d930 ("arm64: dts: qcom: Add base qrb4210-rb2 board dts")
Signed-off-by: Dmitry Baryshkov <[email protected]>
---
arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
index 2c39bb1b97db..e0c14d23b909 100644
--- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
+++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
@@ -403,6 +403,8 @@ vreg_l9a_1p8: l9 {
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
regulator-allow-set-load;
+ regulator-always-on;
+ regulator-boot-on;
};

vreg_l10a_1p8: l10 {

---
base-commit: 0e1980c40b6edfa68b6acf926bab22448a6e40c9
change-id: 20240603-rb2-l9a-aon-d1292bad5aaa

Best regards,
--
Dmitry Baryshkov <[email protected]>

2024-06-03 23:01:20

by Bryan O'Donoghue

Subject: Re: [PATCH] arm64: dts: qcom: qrb4210-rb2: make L9A always-on

On 03/06/2024 13:49, Dmitry Baryshkov wrote:
> The L9A regulator is used to further control voltage regulators on the
> board. Make sure that is stays always on to prevent undervolting some of
> the volage rails.
>
> Fixes: 8d58a8c0d930 ("arm64: dts: qcom: Add base qrb4210-rb2 board dts")
> Signed-off-by: Dmitry Baryshkov <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> index 2c39bb1b97db..e0c14d23b909 100644
> --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> @@ -403,6 +403,8 @@ vreg_l9a_1p8: l9 {
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> regulator-allow-set-load;
> + regulator-always-on;
> + regulator-boot-on;
> };
>
> vreg_l10a_1p8: l10 {
>
> ---
> base-commit: 0e1980c40b6edfa68b6acf926bab22448a6e40c9
> change-id: 20240603-rb2-l9a-aon-d1292bad5aaa
>
> Best regards,

It'd be nice to have some more detail on which rails and the further
side effects, in a V2 if you're of a mind to do so.

Either way.

Reviewed-by: Bryan O'Donoghue <[email protected]>