2024-06-04 14:38:07

by Jeff Johnson

Subject: [PATCH] HID: lg-g15: add missing MODULE_DESCRIPTION() macro

make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-lg-g15.o

Add the missing invocation of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <[email protected]>
---
drivers/hid/hid-lg-g15.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/hid/hid-lg-g15.c b/drivers/hid/hid-lg-g15.c
index acbec1dcf196..53e7b90f9cc3 100644
--- a/drivers/hid/hid-lg-g15.c
+++ b/drivers/hid/hid-lg-g15.c
@@ -954,4 +954,5 @@ static struct hid_driver lg_g15_driver = {
module_hid_driver(lg_g15_driver);

MODULE_AUTHOR("Hans de Goede <[email protected]>");
+MODULE_DESCRIPTION("HID driver for gaming keys on Logitech gaming keyboards");
MODULE_LICENSE("GPL");

---
base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
change-id: 20240604-md-hid-lg-g15-e4a106ba126b

2024-06-04 15:19:20

by Hans de Goede

Subject: Re: [PATCH] HID: lg-g15: add missing MODULE_DESCRIPTION() macro

Hi,

On 6/4/24 4:33 PM, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-lg-g15.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <[email protected]>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <[email protected]>

Regards,

Hans



> ---
> drivers/hid/hid-lg-g15.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/hid-lg-g15.c b/drivers/hid/hid-lg-g15.c
> index acbec1dcf196..53e7b90f9cc3 100644
> --- a/drivers/hid/hid-lg-g15.c
> +++ b/drivers/hid/hid-lg-g15.c
> @@ -954,4 +954,5 @@ static struct hid_driver lg_g15_driver = {
> module_hid_driver(lg_g15_driver);
>
> MODULE_AUTHOR("Hans de Goede <[email protected]>");
> +MODULE_DESCRIPTION("HID driver for gaming keys on Logitech gaming keyboards");
> MODULE_LICENSE("GPL");
>
> ---
> base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
> change-id: 20240604-md-hid-lg-g15-e4a106ba126b
>

2024-06-06 09:00:40

by Benjamin Tissoires

Subject: Re: [PATCH] HID: lg-g15: add missing MODULE_DESCRIPTION() macro

On Tue, 04 Jun 2024 07:33:01 -0700, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-lg-g15.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
>

Applied to hid/hid.git (for-6.11/module-description), thanks!

[1/1] HID: lg-g15: add missing MODULE_DESCRIPTION() macro
https://git.kernel.org/hid/hid/c/e52a7d0562d8

Cheers,
--
Benjamin Tissoires <[email protected]>