2024-06-04 08:10:22

by Li zeming

Subject: [PATCH] irq: chip: Optimize the irq_set_irq_type function code

Optimize the position of ret and remove initialization assignments,
making the function look more aesthetically pleasing internally.

Signed-off-by: Li zeming <[email protected]>
---
kernel/irq/chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index dc94e0bf2c94..1ce3d29abc90 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -64,9 +64,9 @@ EXPORT_SYMBOL(irq_set_chip);
*/
int irq_set_irq_type(unsigned int irq, unsigned int type)
{
+ int ret;
unsigned long flags;
struct irq_desc *desc = irq_get_desc_buslock(irq, &flags, IRQ_GET_DESC_CHECK_GLOBAL);
- int ret = 0;

if (!desc)
return -EINVAL;
--
2.18.2

2024-06-04 17:52:34

by Thomas Gleixner

Subject: Re: [PATCH] irq: chip: Optimize the irq_set_irq_type function code

On Tue, Jun 04 2024 at 16:09, Li zeming wrote:
> Optimize the position of ret and remove initialization assignments,
> making the function look more aesthetically pleasing internally.

And thereby violating the coding style guide of the tip tree:
Documentation/processs/maintainers-tip.rst

Which also contains a guide how to select the subject prefix.

Thanks,

tglx