2024-06-04 13:17:47

by Charles Keepax

[permalink] [raw]
Subject: [PATCH] spi: cs42l43: Correct SPI root clock speed

The root clock is actually 49.152MHz not 40MHz, as it is derived from
the primary audio clock, update the driver to match. This error can
cause the actual clock rate to be higher than the requested clock rate
on the SPI bus.

Fixes: ef75e767167a ("spi: cs42l43: Add SPI controller support")
Signed-off-by: Charles Keepax <[email protected]>
---
drivers/spi/spi-cs42l43.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-cs42l43.c b/drivers/spi/spi-cs42l43.c
index 9d747ea69926..902a0734cc36 100644
--- a/drivers/spi/spi-cs42l43.c
+++ b/drivers/spi/spi-cs42l43.c
@@ -26,7 +26,7 @@
#include <linux/units.h>

#define CS42L43_FIFO_SIZE 16
-#define CS42L43_SPI_ROOT_HZ (40 * HZ_PER_MHZ)
+#define CS42L43_SPI_ROOT_HZ 49152000
#define CS42L43_SPI_MAX_LENGTH 65532

enum cs42l43_spi_cmd {
--
2.39.2



2024-06-04 20:38:43

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] spi: cs42l43: Correct SPI root clock speed

On Tue, 04 Jun 2024 14:17:04 +0100, Charles Keepax wrote:
> The root clock is actually 49.152MHz not 40MHz, as it is derived from
> the primary audio clock, update the driver to match. This error can
> cause the actual clock rate to be higher than the requested clock rate
> on the SPI bus.
>
>

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: cs42l43: Correct SPI root clock speed
commit: 4eecb644b8b82f5279a348f6ebe77e3d6e5b1b05

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark