2024-06-04 23:39:55

by Nathan Morrisson

Subject: [PATCH] arm64: defconfig: Enable TI LP873X PMIC

Enable the TI LP873X PMIC configs.

Signed-off-by: Nathan Morrisson <[email protected]>
---
arch/arm64/configs/defconfig | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 57a9abe78ee4..24ea62a8fdbf 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -745,6 +745,7 @@ CONFIG_MFD_SEC_CORE=y
CONFIG_MFD_SL28CPLD=y
CONFIG_RZ_MTU3=y
CONFIG_MFD_TI_AM335X_TSCADC=m
+CONFIG_MFD_TI_LP873X=y
CONFIG_MFD_TPS65219=y
CONFIG_MFD_TPS6594_I2C=m
CONFIG_MFD_ROHM_BD718XX=y
@@ -760,6 +761,7 @@ CONFIG_REGULATOR_FAN53555=y
CONFIG_REGULATOR_GPIO=y
CONFIG_REGULATOR_HI6421V530=y
CONFIG_REGULATOR_HI655X=y
+CONFIG_REGULATOR_LP873X=y
CONFIG_REGULATOR_MAX77620=y
CONFIG_REGULATOR_MAX8973=y
CONFIG_REGULATOR_MAX20411=m
--
2.25.1

2024-06-05 07:15:22

by Krzysztof Kozlowski

Subject: Re: [PATCH] arm64: defconfig: Enable TI LP873X PMIC

On 05/06/2024 01:38, Nathan Morrisson wrote:
> Enable the TI LP873X PMIC configs.

Why? No user of this, sorry. Please explain in commit msg why this
should be done, e.g. which upstream user needs it.

>
> Signed-off-by: Nathan Morrisson <[email protected]>
> ---
> arch/arm64/configs/defconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 57a9abe78ee4..24ea62a8fdbf 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -745,6 +745,7 @@ CONFIG_MFD_SEC_CORE=y
> CONFIG_MFD_SL28CPLD=y
> CONFIG_RZ_MTU3=y
> CONFIG_MFD_TI_AM335X_TSCADC=m
> +CONFIG_MFD_TI_LP873X=y

Why this cannot be m?

> CONFIG_MFD_TPS65219=y
> CONFIG_MFD_TPS6594_I2C=m
> CONFIG_MFD_ROHM_BD718XX=y
> @@ -760,6 +761,7 @@ CONFIG_REGULATOR_FAN53555=y
> CONFIG_REGULATOR_GPIO=y
> CONFIG_REGULATOR_HI6421V530=y
> CONFIG_REGULATOR_HI655X=y
> +CONFIG_REGULATOR_LP873X=y

Why this cannot be m?

> CONFIG_REGULATOR_MAX77620=y
> CONFIG_REGULATOR_MAX8973=y
> CONFIG_REGULATOR_MAX20411=m

Best regards,
Krzysztof

2024-06-06 23:38:21

by Nathan Morrisson

Subject: Re: [PATCH] arm64: defconfig: Enable TI LP873X PMIC

On 6/5/24 12:15 AM, Krzysztof Kozlowski wrote:
> On 05/06/2024 01:38, Nathan Morrisson wrote:
>> Enable the TI LP873X PMIC configs.
> Why? No user of this, sorry. Please explain in commit msg why this
> should be done, e.g. which upstream user needs it.

This will be used by the phytec am642-phyboard-electra, but the patch
[1] has not been accepted yet. I will fix the other issues in a v2 as well.


[1]
https://lore.kernel.org/lkml/[email protected]/


Regards,

Nathan

>
>> Signed-off-by: Nathan Morrisson <[email protected]>
>> ---
>> arch/arm64/configs/defconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>> index 57a9abe78ee4..24ea62a8fdbf 100644
>> --- a/arch/arm64/configs/defconfig
>> +++ b/arch/arm64/configs/defconfig
>> @@ -745,6 +745,7 @@ CONFIG_MFD_SEC_CORE=y
>> CONFIG_MFD_SL28CPLD=y
>> CONFIG_RZ_MTU3=y
>> CONFIG_MFD_TI_AM335X_TSCADC=m
>> +CONFIG_MFD_TI_LP873X=y
> Why this cannot be m?
>
>> CONFIG_MFD_TPS65219=y
>> CONFIG_MFD_TPS6594_I2C=m
>> CONFIG_MFD_ROHM_BD718XX=y
>> @@ -760,6 +761,7 @@ CONFIG_REGULATOR_FAN53555=y
>> CONFIG_REGULATOR_GPIO=y
>> CONFIG_REGULATOR_HI6421V530=y
>> CONFIG_REGULATOR_HI655X=y
>> +CONFIG_REGULATOR_LP873X=y
> Why this cannot be m?
>
>> CONFIG_REGULATOR_MAX77620=y
>> CONFIG_REGULATOR_MAX8973=y
>> CONFIG_REGULATOR_MAX20411=m
> Best regards,
> Krzysztof
>