2024-06-05 08:25:54

by Abel Vesa

[permalink] [raw]
Subject: [PATCH v2] dt-bindings: PCI: qcom: x1e80100: Make the MHI reg region mandatory

All PCIe controllers found on X1E80100 have MHI register region.
So change the schema to reflect that.

Fixes: 692eadd51698 ("dt-bindings: PCI: qcom: Document the X1E80100 PCIe Controller")
Signed-off-by: Abel Vesa <[email protected]>
---
Note that this patch will trigger an MHI reg region
warning until the following patch will also be merged:

https://lore.kernel.org/all/[email protected]/
---
Changes in v2:
- Dropped the vddpe supply change as that will have to be reworked
in a different way, maybe on multiple platforms.
- Added SoC name to the subject line
- Link to v1: https://lore.kernel.org/r/[email protected]
---
Documentation/devicetree/bindings/pci/qcom,pcie-x1e80100.yaml | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-x1e80100.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-x1e80100.yaml
index 1074310a8e7a..a9db0a231563 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie-x1e80100.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie-x1e80100.yaml
@@ -19,11 +19,10 @@ properties:
const: qcom,pcie-x1e80100

reg:
- minItems: 5
+ minItems: 6
maxItems: 6

reg-names:
- minItems: 5
items:
- const: parf # Qualcomm specific registers
- const: dbi # DesignWare PCIe registers

---
base-commit: d97496ca23a2d4ee80b7302849404859d9058bcd
change-id: 20240604-x1e80100-pci-bindings-fix-196925d15260

Best regards,
--
Abel Vesa <[email protected]>



2024-06-05 08:27:30

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2] dt-bindings: PCI: qcom: x1e80100: Make the MHI reg region mandatory

On 05/06/2024 10:19, Abel Vesa wrote:
> All PCIe controllers found on X1E80100 have MHI register region.
> So change the schema to reflect that.
>
> Fixes: 692eadd51698 ("dt-bindings: PCI: qcom: Document the X1E80100 PCIe Controller")
> Signed-off-by: Abel Vesa <[email protected]>
> ---
> Note that this patch will trigger an MHI reg region
> warning until the following patch will also be merged:
>
> https://lore.kernel.org/all/[email protected]/
> ---
> Changes in v2:
> - Dropped the vddpe supply change as that will have to be reworked
> in a different way, maybe on multiple platforms.
> - Added SoC name to the subject line
> - Link to v1: https://lore.kernel.org/r/[email protected]
> ---

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof


2024-06-05 08:30:26

by Manivannan Sadhasivam

[permalink] [raw]
Subject: Re: [PATCH v2] dt-bindings: PCI: qcom: x1e80100: Make the MHI reg region mandatory

On Wed, Jun 05, 2024 at 11:19:01AM +0300, Abel Vesa wrote:
> All PCIe controllers found on X1E80100 have MHI register region.
> So change the schema to reflect that.
>
> Fixes: 692eadd51698 ("dt-bindings: PCI: qcom: Document the X1E80100 PCIe Controller")
> Signed-off-by: Abel Vesa <[email protected]>

Reviewed-by: Manivannan Sadhasivam <[email protected]>

- Mani

> ---
> Note that this patch will trigger an MHI reg region
> warning until the following patch will also be merged:
>
> https://lore.kernel.org/all/[email protected]/
> ---
> Changes in v2:
> - Dropped the vddpe supply change as that will have to be reworked
> in a different way, maybe on multiple platforms.
> - Added SoC name to the subject line
> - Link to v1: https://lore.kernel.org/r/[email protected]
> ---
> Documentation/devicetree/bindings/pci/qcom,pcie-x1e80100.yaml | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-x1e80100.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-x1e80100.yaml
> index 1074310a8e7a..a9db0a231563 100644
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie-x1e80100.yaml
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-x1e80100.yaml
> @@ -19,11 +19,10 @@ properties:
> const: qcom,pcie-x1e80100
>
> reg:
> - minItems: 5
> + minItems: 6
> maxItems: 6
>
> reg-names:
> - minItems: 5
> items:
> - const: parf # Qualcomm specific registers
> - const: dbi # DesignWare PCIe registers
>
> ---
> base-commit: d97496ca23a2d4ee80b7302849404859d9058bcd
> change-id: 20240604-x1e80100-pci-bindings-fix-196925d15260
>
> Best regards,
> --
> Abel Vesa <[email protected]>
>

--
மணிவண்ணன் சதாசிவம்

2024-06-05 14:02:10

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v2] dt-bindings: PCI: qcom: x1e80100: Make the MHI reg region mandatory


On Wed, 05 Jun 2024 11:19:01 +0300, Abel Vesa wrote:
> All PCIe controllers found on X1E80100 have MHI register region.
> So change the schema to reflect that.
>
> Fixes: 692eadd51698 ("dt-bindings: PCI: qcom: Document the X1E80100 PCIe Controller")
> Signed-off-by: Abel Vesa <[email protected]>
> ---
> Note that this patch will trigger an MHI reg region
> warning until the following patch will also be merged:
>
> https://lore.kernel.org/all/[email protected]/
> ---
> Changes in v2:
> - Dropped the vddpe supply change as that will have to be reworked
> in a different way, maybe on multiple platforms.
> - Added SoC name to the subject line
> - Link to v1: https://lore.kernel.org/r/[email protected]
> ---
> Documentation/devicetree/bindings/pci/qcom,pcie-x1e80100.yaml | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>

Reviewed-by: Rob Herring (Arm) <[email protected]>