2024-06-06 08:09:42

by Jai Luthra

[permalink] [raw]
Subject: [PATCH v2 0/7] arm64: dts: ti: McASP fixes

Drop McASP AFIFOs for all AM62 based platforms, as the extra buffering
is not needed with BCDMA already having internal buffering.

Also fix the pinmux for McASP1 on AM62P.

Signed-off-by: Jai Luthra <[email protected]>
---
Changes in v2:
- Drop [tx|rx]-num-evt properties instead of setting to 0
- Add Fixes tag for am625-phyboard-lyra-rdk
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Jai Luthra (7):
arm64: dts: ti: k3-am62x: Drop McASP AFIFOs
arm64: dts: ti: k3-am62a7: Drop McASP AFIFOs
arm64: dts: ti: k3-am62p5: Drop McASP AFIFOs
arm64: dts: ti: k3-am625-beagleplay: Drop McASP AFIFOs
arm64: dts: ti: k3-am62-verdin: Drop McASP AFIFOs
arm64: dts: ti: k3-am625-phyboard-lyra-rdk: Drop McASP AFIFOs
arm64: dts: ti: k3-am62p5-sk: Fix pinmux for McASP1 TX

arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi | 4 ----
arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts | 2 --
arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts | 2 --
arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 2 --
arch/arm64/boot/dts/ti/k3-am62p5-sk.dts | 4 +---
arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 2 --
6 files changed, 1 insertion(+), 15 deletions(-)
---
base-commit: d97496ca23a2d4ee80b7302849404859d9058bcd
change-id: 20240604-mcasp_fifo_drop-683bc3412262

Best regards,
--
Jai Luthra <[email protected]>



2024-06-06 08:10:08

by Jai Luthra

[permalink] [raw]
Subject: [PATCH v2 1/7] arm64: dts: ti: k3-am62x: Drop McASP AFIFOs

McASP AFIFOs are not necessary with UDMA-P/BCDMA as there is buffering
on the DMA IP. Drop these for better audio latency.

Fixes: b94b43715e91 ("arm64: dts: ti: Enable audio on SK-AM62(-LP)")
Signed-off-by: Jai Luthra <[email protected]>
---
arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
index 3c45782ab2b7..63b4e88e3a94 100644
--- a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
@@ -504,8 +504,6 @@ &mcasp1 {
0 0 0 0
0 0 0 0
>;
- tx-num-evt = <32>;
- rx-num-evt = <32>;
};

&dss {

--
2.43.0


2024-06-06 08:10:08

by Jai Luthra

[permalink] [raw]
Subject: [PATCH v2 5/7] arm64: dts: ti: k3-am62-verdin: Drop McASP AFIFOs

McASP AFIFOs are not necessary with UDMA-P/BCDMA as there is buffering
on the DMA IP. Drop these for better audio latency.

Fixes: 316b80246b16 ("arm64: dts: ti: add verdin am62")
Acked-by: Francesco Dolcini <[email protected]>
Signed-off-by: Jai Luthra <[email protected]>
---
arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi | 4 ----
1 file changed, 4 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi b/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
index 2038c5e04639..359f53f3e019 100644
--- a/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
@@ -1364,8 +1364,6 @@ &mcasp0 {
0 0 0 0
>;
tdm-slots = <2>;
- rx-num-evt = <32>;
- tx-num-evt = <32>;
#sound-dai-cells = <0>;
status = "disabled";
};
@@ -1382,8 +1380,6 @@ &mcasp1 {
0 0 0 0
>;
tdm-slots = <2>;
- rx-num-evt = <32>;
- tx-num-evt = <32>;
#sound-dai-cells = <0>;
status = "disabled";
};

--
2.43.0


2024-06-06 08:10:31

by Jai Luthra

[permalink] [raw]
Subject: [PATCH v2 4/7] arm64: dts: ti: k3-am625-beagleplay: Drop McASP AFIFOs

McASP AFIFOs are not necessary with UDMA-P/BCDMA as there is buffering
on the DMA IP. Drop these for better audio latency.

Fixes: 1f7226a5e52c ("arm64: dts: ti: k3-am625-beagleplay: Add HDMI support")
Signed-off-by: Jai Luthra <[email protected]>
---
arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
index 18e3070a8683..70de288d728e 100644
--- a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
+++ b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
@@ -924,6 +924,4 @@ &mcasp1 {
0 0 0 0
0 0 0 0
>;
- tx-num-evt = <32>;
- rx-num-evt = <32>;
};

--
2.43.0


2024-06-06 08:11:07

by Jai Luthra

[permalink] [raw]
Subject: [PATCH v2 6/7] arm64: dts: ti: k3-am625-phyboard-lyra-rdk: Drop McASP AFIFOs

McASP AFIFOs are not necessary with UDMA-P/BCDMA as there is buffering
on the DMA IP. Drop these for better audio latency.

Fixes: 28c0cf16b308 ("arm64: dts: ti: k3-am625-phyboard-lyra-rdk: Add Audio Codec")
Signed-off-by: Jai Luthra <[email protected]>
---
arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts b/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts
index 50d2573c840e..6c24e4d39ee8 100644
--- a/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-rdk.dts
@@ -441,8 +441,6 @@ &mcasp2 {
0 0 0 0
0 0 0 0
>;
- tx-num-evt = <32>;
- rx-num-evt = <32>;
status = "okay";
};


--
2.43.0


2024-06-06 08:15:58

by Jai Luthra

[permalink] [raw]
Subject: [PATCH v2 3/7] arm64: dts: ti: k3-am62p5: Drop McASP AFIFOs

McASP AFIFOs are not necessary with UDMA-P/BCDMA as there is buffering
on the DMA IP. Drop these for better audio latency.

Fixes: c00504ea42c0 ("arm64: dts: ti: k3-am62p5-sk: Updates for SK EVM")
Signed-off-by: Jai Luthra <[email protected]>
---
arch/arm64/boot/dts/ti/k3-am62p5-sk.dts | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
index 6e7234659111..78d4d44e8bd4 100644
--- a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
@@ -549,8 +549,6 @@ &mcasp1 {
0 0 0 0
0 0 0 0
>;
- tx-num-evt = <32>;
- rx-num-evt = <32>;
};

&fss {

--
2.43.0


2024-06-06 08:17:18

by Jai Luthra

[permalink] [raw]
Subject: [PATCH v2 7/7] arm64: dts: ti: k3-am62p5-sk: Fix pinmux for McASP1 TX

On SK-AM62P, McASP1 uses two pins for communicating with the codec over
I2S protocol. One of these pins (AXR0) is used for audio playback (TX)
so the direction of the pin should be OUTPUT.

Fixes: c00504ea42c0 ("arm64: dts: ti: k3-am62p5-sk: Updates for SK EVM")
Signed-off-by: Jai Luthra <[email protected]>
---
arch/arm64/boot/dts/ti/k3-am62p5-sk.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
index 78d4d44e8bd4..fb980d46e304 100644
--- a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
@@ -207,7 +207,7 @@ main_mcasp1_pins_default: main-mcasp1-default-pins {
pinctrl-single,pins = <
AM62PX_IOPAD(0x0090, PIN_INPUT, 2) /* (U24) GPMC0_BE0n_CLE.MCASP1_ACLKX */
AM62PX_IOPAD(0x0098, PIN_INPUT, 2) /* (AA24) GPMC0_WAIT0.MCASP1_AFSX */
- AM62PX_IOPAD(0x008c, PIN_INPUT, 2) /* (T25) GPMC0_WEn.MCASP1_AXR0 */
+ AM62PX_IOPAD(0x008c, PIN_OUTPUT, 2) /* (T25) GPMC0_WEn.MCASP1_AXR0 */
AM62PX_IOPAD(0x0084, PIN_INPUT, 2) /* (R25) GPMC0_ADVn_ALE.MCASP1_AXR2 */
>;
};

--
2.43.0


2024-06-13 08:48:42

by Vignesh Raghavendra

[permalink] [raw]
Subject: Re: [PATCH v2 0/7] arm64: dts: ti: McASP fixes

Hi Jai Luthra,

On Thu, 06 Jun 2024 13:37:39 +0530, Jai Luthra wrote:
> Drop McASP AFIFOs for all AM62 based platforms, as the extra buffering
> is not needed with BCDMA already having internal buffering.
>
> Also fix the pinmux for McASP1 on AM62P.
>
>

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

[1/7] arm64: dts: ti: k3-am62x: Drop McASP AFIFOs
commit: 6ee3ca0ec7fabc63603afdb3485da04164dc8747
[2/7] arm64: dts: ti: k3-am62a7: Drop McASP AFIFOs
commit: a931b81072921a11d5bb8e8201b6228b791d40a9
[3/7] arm64: dts: ti: k3-am62p5: Drop McASP AFIFOs
commit: d3fe4b4e2e44de64ed1f1585151bf4a3627adbaf
[4/7] arm64: dts: ti: k3-am625-beagleplay: Drop McASP AFIFOs
commit: 3b4a03357aee07a32a44a49bb6a71f5e82b1ecc1
[5/7] arm64: dts: ti: k3-am62-verdin: Drop McASP AFIFOs
commit: fb01352801f08740e9f37cbd71f73866c7044927
[6/7] arm64: dts: ti: k3-am625-phyboard-lyra-rdk: Drop McASP AFIFOs
commit: 554dd562a5f2f5d7e838f7b229a1c612275678db
[7/7] arm64: dts: ti: k3-am62p5-sk: Fix pinmux for McASP1 TX
commit: e96e36ce1fdcf08a70e3f09cbe2da02b073c58ac

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Vignesh