When sending patch authored by someone else to stable, it is quite easy for
the sender to forget adding the Developer's Certification of Origin (DCO,
i.e. Signed-off-by). Mention DCO explicilty so senders are less likely to
forget to do so and cause another round-trip.
Add a label in submitting-patches.rst so we can directly link to the DCO
section.
Link: https://lore.kernel.org/stable/2024051500-underage-unfixed-5d28@gregkh/
Signed-off-by: Shung-Hsi Yu <[email protected]>
---
Documentation/process/stable-kernel-rules.rst | 4 ++++
Documentation/process/submitting-patches.rst | 1 +
2 files changed, 5 insertions(+)
diff --git a/Documentation/process/stable-kernel-rules.rst b/Documentation/process/stable-kernel-rules.rst
index daa542988095..a8fecc5f681c 100644
--- a/Documentation/process/stable-kernel-rules.rst
+++ b/Documentation/process/stable-kernel-rules.rst
@@ -168,6 +168,10 @@ If the submitted patch deviates from the original upstream patch (for example
because it had to be adjusted for the older API), this must be very clearly
documented and justified in the patch description.
+Be sure to also include a :ref:`Developer's Certificate of Origin
+<sign_your_work>` (i.e. ``Signed-off-by``) when sending patches that you did
+not author yourself.
+
Following the submission
------------------------
diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
index 66029999b587..98f1c8d8b429 100644
--- a/Documentation/process/submitting-patches.rst
+++ b/Documentation/process/submitting-patches.rst
@@ -394,6 +394,7 @@ e-mail discussions.
``git send-email`` will do this for you automatically.
+.. _sign_your_work:
Sign your work - the Developer's Certificate of Origin
------------------------------------------------------
--
2.45.1
On 06/06/2024 07:43, Shung-Hsi Yu wrote:
> When sending patch authored by someone else to stable, it is quite easy for
> the sender to forget adding the Developer's Certification of Origin (DCO,
> i.e. Signed-off-by). Mention DCO explicilty so senders are less likely to
s/explicilty/explicitly/
> forget to do so and cause another round-trip.
>
> Add a label in submitting-patches.rst so we can directly link to the DCO
> section.
>
> Link: https://lore.kernel.org/stable/2024051500-underage-unfixed-5d28@gregkh/
Is "Link:" right here? I'd prefer to see something like "For example see
..." added to the first paragraph so it's explicit that this is a link
to an example of this issue.
Thanks,
--
Paul Barker
On Thu, Jun 06, 2024 at 09:21:39AM GMT, Paul Barker wrote:
> On 06/06/2024 07:43, Shung-Hsi Yu wrote:
> > When sending patch authored by someone else to stable, it is quite easy for
> > the sender to forget adding the Developer's Certification of Origin (DCO,
> > i.e. Signed-off-by). Mention DCO explicilty so senders are less likely to
>
> s/explicilty/explicitly/
>
> > forget to do so and cause another round-trip.
> >
> > Add a label in submitting-patches.rst so we can directly link to the DCO
> > section.
> >
> > Link: https://lore.kernel.org/stable/2024051500-underage-unfixed-5d28@gregkh/
>
> Is "Link:" right here? I'd prefer to see something like "For example see
> ..." added to the first paragraph so it's explicit that this is a link
> to an example of this issue.
Thanks for the feedback. Yes that is better. Will clarify that, fix
typo, and slighly edit patch 1 as suggested.
Shung-Hsi