There is no need to explicitly configure the gas measurement
registers every time a gas measurement takes place. These are
initial configurations which are written in the beginning and
they are not changed throughout the lifetime of the driver.
If in the future, the device starts to support multiple
configuration profiles with variable heater duration and
heater temperature, then they could become members of
the ->read_avail().
Signed-off-by: Vasileios Amoiridis <[email protected]>
---
drivers/iio/chemical/bme680_core.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/iio/chemical/bme680_core.c b/drivers/iio/chemical/bme680_core.c
index 1cf375904b8d..76b96993120f 100644
--- a/drivers/iio/chemical/bme680_core.c
+++ b/drivers/iio/chemical/bme680_core.c
@@ -683,13 +683,6 @@ static int bme680_read_gas(struct bme680_data *data,
u16 adc_gas_res, gas_regs_val;
u8 gas_range;
- /* Set heater settings */
- ret = bme680_gas_config(data);
- if (ret < 0) {
- dev_err(dev, "failed to set gas config\n");
- return ret;
- }
-
/* set forced mode to trigger measurement */
ret = bme680_set_mode(data, true);
if (ret < 0)
--
2.25.1
On Thu, 6 Jun 2024 23:23:11 +0200
Vasileios Amoiridis <[email protected]> wrote:
> There is no need to explicitly configure the gas measurement
> registers every time a gas measurement takes place. These are
> initial configurations which are written in the beginning and
> they are not changed throughout the lifetime of the driver.
>
> If in the future, the device starts to support multiple
> configuration profiles with variable heater duration and
> heater temperature, then they could become members of
> the ->read_avail().
Similar oddly short line wrap. Fix them all up for v3.
Thanks
Jonathan
>
> Signed-off-by: Vasileios Amoiridis <[email protected]>
> ---
> drivers/iio/chemical/bme680_core.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/iio/chemical/bme680_core.c b/drivers/iio/chemical/bme680_core.c
> index 1cf375904b8d..76b96993120f 100644
> --- a/drivers/iio/chemical/bme680_core.c
> +++ b/drivers/iio/chemical/bme680_core.c
> @@ -683,13 +683,6 @@ static int bme680_read_gas(struct bme680_data *data,
> u16 adc_gas_res, gas_regs_val;
> u8 gas_range;
>
> - /* Set heater settings */
> - ret = bme680_gas_config(data);
> - if (ret < 0) {
> - dev_err(dev, "failed to set gas config\n");
> - return ret;
> - }
> -
> /* set forced mode to trigger measurement */
> ret = bme680_set_mode(data, true);
> if (ret < 0)