Enable MCP23S08 I/O expanders to manage Ethernet PHY
reset in STM32MP135F-DK board.
Signed-off-by: Christophe Roullier <[email protected]>
---
arch/arm/configs/multi_v7_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 86bf057ac3663..9758f3d41ad70 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -469,6 +469,7 @@ CONFIG_SPI_XILINX=y
CONFIG_SPI_SPIDEV=y
CONFIG_SPMI=y
CONFIG_PINCTRL_AS3722=y
+CONFIG_PINCTRL_MCP23S08=y
CONFIG_PINCTRL_MICROCHIP_SGPIO=y
CONFIG_PINCTRL_OCELOT=y
CONFIG_PINCTRL_PALMAS=y
--
2.25.1
On 10/06/2024 10:06, Christophe Roullier wrote:
> Enable MCP23S08 I/O expanders to manage Ethernet PHY
> reset in STM32MP135F-DK board.
>
> Signed-off-by: Christophe Roullier <[email protected]>
> ---
> arch/arm/configs/multi_v7_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index 86bf057ac3663..9758f3d41ad70 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -469,6 +469,7 @@ CONFIG_SPI_XILINX=y
> CONFIG_SPI_SPIDEV=y
> CONFIG_SPMI=y
> CONFIG_PINCTRL_AS3722=y
> +CONFIG_PINCTRL_MCP23S08=y
This is not an on-SoC pinctrl, so it should be module (=m).
Best regards,
Krzysztof
Hi Krzysztof,
On 6/10/24 10:09, Krzysztof Kozlowski wrote:
> On 10/06/2024 10:06, Christophe Roullier wrote:
>> Enable MCP23S08 I/O expanders to manage Ethernet PHY
>> reset in STM32MP135F-DK board.
>>
>> Signed-off-by: Christophe Roullier <[email protected]>
>> ---
>> arch/arm/configs/multi_v7_defconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
>> index 86bf057ac3663..9758f3d41ad70 100644
>> --- a/arch/arm/configs/multi_v7_defconfig
>> +++ b/arch/arm/configs/multi_v7_defconfig
>> @@ -469,6 +469,7 @@ CONFIG_SPI_XILINX=y
>> CONFIG_SPI_SPIDEV=y
>> CONFIG_SPMI=y
>> CONFIG_PINCTRL_AS3722=y
>> +CONFIG_PINCTRL_MCP23S08=y
> This is not an on-SoC pinctrl, so it should be module (=m).
The stmmac is in built-in, if IO-Expander (MCP23S08) is on module, we
have huge of message during kernel boot
because stmmac driver is deferred several times. (need to wait that
module are ready)
Thanks
>
> Best regards,
> Krzysztof
>
On 10/06/2024 10:14, Christophe ROULLIER wrote:
>>> @@ -469,6 +469,7 @@ CONFIG_SPI_XILINX=y
>>> CONFIG_SPI_SPIDEV=y
>>> CONFIG_SPMI=y
>>> CONFIG_PINCTRL_AS3722=y
>>> +CONFIG_PINCTRL_MCP23S08=y
>> This is not an on-SoC pinctrl, so it should be module (=m).
>
> The stmmac is in built-in, if IO-Expander (MCP23S08) is on module, we
> have huge of message during kernel boot
>
> because stmmac driver is deferred several times. (need to wait that
> module are ready)
Which is normal and not a reason to change defconfig. It it was a
problem, you should solve it not in defconfig but in kernel. That's just
defconfig, an example, reference or debugging tool if you wish, so
fixing issue here is not a fix at all.
Best regards,
Krzysztof
On 6/10/24 14:27, Krzysztof Kozlowski wrote:
> On 10/06/2024 10:14, Christophe ROULLIER wrote:
>>>> @@ -469,6 +469,7 @@ CONFIG_SPI_XILINX=y
>>>> CONFIG_SPI_SPIDEV=y
>>>> CONFIG_SPMI=y
>>>> CONFIG_PINCTRL_AS3722=y
>>>> +CONFIG_PINCTRL_MCP23S08=y
>>> This is not an on-SoC pinctrl, so it should be module (=m).
>> The stmmac is in built-in, if IO-Expander (MCP23S08) is on module, we
>> have huge of message during kernel boot
>>
>> because stmmac driver is deferred several times. (need to wait that
>> module are ready)
> Which is normal and not a reason to change defconfig. It it was a
> problem, you should solve it not in defconfig but in kernel. That's just
> defconfig, an example, reference or debugging tool if you wish, so
> fixing issue here is not a fix at all.
Ok so it will not be possible to boot in NFS mode
>
> Best regards,
> Krzysztof
>
On 10/06/2024 14:52, Christophe ROULLIER wrote:
>
> On 6/10/24 14:27, Krzysztof Kozlowski wrote:
>> On 10/06/2024 10:14, Christophe ROULLIER wrote:
>>>>> @@ -469,6 +469,7 @@ CONFIG_SPI_XILINX=y
>>>>> CONFIG_SPI_SPIDEV=y
>>>>> CONFIG_SPMI=y
>>>>> CONFIG_PINCTRL_AS3722=y
>>>>> +CONFIG_PINCTRL_MCP23S08=y
>>>> This is not an on-SoC pinctrl, so it should be module (=m).
>>> The stmmac is in built-in, if IO-Expander (MCP23S08) is on module, we
>>> have huge of message during kernel boot
>>>
>>> because stmmac driver is deferred several times. (need to wait that
>>> module are ready)
>> Which is normal and not a reason to change defconfig. It it was a
>> problem, you should solve it not in defconfig but in kernel. That's just
>> defconfig, an example, reference or debugging tool if you wish, so
>> fixing issue here is not a fix at all.
> Ok so it will not be possible to boot in NFS mode
Why? You need to fix your initrd, not change defconfig. We all work with
initrds and modules are not a problem at all.
Really, this is jut a defconfig, not a distro config! And even distro
config would make it a module...
Best regards,
Krzysztof