2024-06-12 13:41:23

by Andreas Kemnade

Subject: [PATCH -next] dt-bindings: mfd: twl: Fix example

Fix example to also conform to rules specified in the separate
not-included gpadc binding.

Fixes: 62e4f3396197 ("dt-bindings: regulator: twl-regulator: convert to yaml")
Signed-off-by: Andreas Kemnade <[email protected]>
---
Documentation/devicetree/bindings/mfd/ti,twl.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/mfd/ti,twl.yaml b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
index 2cbdd238f48f..e94b0fd7af0f 100644
--- a/Documentation/devicetree/bindings/mfd/ti,twl.yaml
+++ b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
@@ -225,6 +225,7 @@ examples:
gpadc {
compatible = "ti,twl6030-gpadc";
interrupts = <6>;
+ #io-channel-cells = <1>;
};

rtc {
--
2.39.2

2024-06-12 14:07:59

by Lee Jones

Subject: Re: [PATCH -next] dt-bindings: mfd: twl: Fix example

On Wed, 12 Jun 2024, Andreas Kemnade wrote:

> Fix example to also conform to rules specified in the separate
> not-included gpadc binding.
>
> Fixes: 62e4f3396197 ("dt-bindings: regulator: twl-regulator: convert to yaml")

If this was applied via Regulator, that's where the fix will need to go.

Acked-by: Lee Jones <[email protected]>

> Signed-off-by: Andreas Kemnade <[email protected]>
> ---
> Documentation/devicetree/bindings/mfd/ti,twl.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/ti,twl.yaml b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> index 2cbdd238f48f..e94b0fd7af0f 100644
> --- a/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> +++ b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> @@ -225,6 +225,7 @@ examples:
> gpadc {
> compatible = "ti,twl6030-gpadc";
> interrupts = <6>;
> + #io-channel-cells = <1>;
> };
>
> rtc {
> --
> 2.39.2
>

--
Lee Jones [李琼斯]

2024-06-13 06:37:09

by Krzysztof Kozlowski

Subject: Re: [PATCH -next] dt-bindings: mfd: twl: Fix example

On 12/06/2024 15:40, Andreas Kemnade wrote:
> Fix example to also conform to rules specified in the separate
> not-included gpadc binding.
>
> Fixes: 62e4f3396197 ("dt-bindings: regulator: twl-regulator: convert to yaml")
> Signed-off-by: Andreas Kemnade <[email protected]>
> ---
> Documentation/devicetree/bindings/mfd/ti,twl.yaml | 1 +

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2024-06-13 14:38:32

by Rob Herring (Arm)

Subject: Re: [PATCH -next] dt-bindings: mfd: twl: Fix example

On Wed, Jun 12, 2024 at 03:40:39PM +0200, Andreas Kemnade wrote:
> Fix example to also conform to rules specified in the separate
> not-included gpadc binding.
>
> Fixes: 62e4f3396197 ("dt-bindings: regulator: twl-regulator: convert to yaml")

Reported-by: Rob Herring (Arm) <[email protected]>

> Signed-off-by: Andreas Kemnade <[email protected]>
> ---
> Documentation/devicetree/bindings/mfd/ti,twl.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/ti,twl.yaml b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> index 2cbdd238f48f..e94b0fd7af0f 100644
> --- a/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> +++ b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> @@ -225,6 +225,7 @@ examples:
> gpadc {
> compatible = "ti,twl6030-gpadc";
> interrupts = <6>;
> + #io-channel-cells = <1>;
> };
>
> rtc {
> --
> 2.39.2
>