2024-06-12 15:39:28

by Kanak Shilledar

Subject: [PATCH v3] dt-bindings: serial: vt8500-uart: convert to json-schema

Convert the VIA VT8500 and WonderMedia WM8xxx UART Controller to
newer DT schema. Created DT schema based on the .txt file which had
`compatible`, `reg`, `interrupts` and `clocks` as required properties.

Additions to the original binding
- changed the file name from vt8500-uart to via,vt8500-uart.yaml
- removed unnecessary alias from the example.

Signed-off-by: Kanak Shilledar <[email protected]>
---
Changes in v3:
- Removed Rob and myself from maintainers and added Alexey.
- Fixed commit message which mentioned "greg and jiri as maintainers".
- Elaborated changelog for v2.
Changes in v2:
- Rebased changes
- Changed maintainers to have Rob and remove Greg and Jiri. VT8500 is
orphaned according to the maintainers file.
- Replaced `compatible` property description with comments.
---
.../bindings/serial/via,vt8500-uart.yaml | 46 +++++++++++++++++++
.../bindings/serial/vt8500-uart.txt | 27 -----------
2 files changed, 46 insertions(+), 27 deletions(-)
create mode 100644 Documentation/devicetree/bindings/serial/via,vt8500-uart.yaml
delete mode 100644 Documentation/devicetree/bindings/serial/vt8500-uart.txt

diff --git a/Documentation/devicetree/bindings/serial/via,vt8500-uart.yaml b/Documentation/devicetree/bindings/serial/via,vt8500-uart.yaml
new file mode 100644
index 000000000000..9c6819241a49
--- /dev/null
+++ b/Documentation/devicetree/bindings/serial/via,vt8500-uart.yaml
@@ -0,0 +1,46 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/serial/via,vt8500-uart.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: VIA VT8500 and WonderMedia WM8xxx UART Controller
+
+maintainers:
+ - Alexey Charkov <[email protected]>
+
+allOf:
+ - $ref: serial.yaml
+
+properties:
+ compatible:
+ enum:
+ - via,vt8500-uart # up to WM8850/WM8950
+ - wm,wm8880-uart # for WM8880 and later
+
+ clocks:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ reg:
+ maxItems: 1
+
+required:
+ - compatible
+ - clocks
+ - interrupts
+ - reg
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ serial@d8200000 {
+ compatible = "via,vt8500-uart";
+ reg = <0xd8200000 0x1040>;
+ interrupts = <32>;
+ clocks = <&clkuart0>;
+ };
diff --git a/Documentation/devicetree/bindings/serial/vt8500-uart.txt b/Documentation/devicetree/bindings/serial/vt8500-uart.txt
deleted file mode 100644
index 2b64e6107fb3..000000000000
--- a/Documentation/devicetree/bindings/serial/vt8500-uart.txt
+++ /dev/null
@@ -1,27 +0,0 @@
-* VIA VT8500 and WonderMedia WM8xxx UART Controller
-
-Required properties:
-- compatible: should be "via,vt8500-uart" (for VIA/WonderMedia chips up to and
- including WM8850/WM8950), or "wm,wm8880-uart" (for WM8880 and later)
-
-- reg: base physical address of the controller and length of memory mapped
- region.
-
-- interrupts: hardware interrupt number
-
-- clocks: shall be the input parent clock phandle for the clock. This should
- be the 24Mhz reference clock.
-
-Aliases may be defined to ensure the correct ordering of the uarts.
-
-Example:
- aliases {
- serial0 = &uart0;
- };
-
- uart0: serial@d8200000 {
- compatible = "via,vt8500-uart";
- reg = <0xd8200000 0x1040>;
- interrupts = <32>;
- clocks = <&clkuart0>;
- };
--
2.45.2

2024-06-13 05:14:11

by Alexey Charkov

Subject: Re: [PATCH v3] dt-bindings: serial: vt8500-uart: convert to json-schema

Hi Kanak,

Thank you for reworking this one.

On Wed, Jun 12, 2024 at 7:39 PM Kanak Shilledar
<[email protected]> wrote:
>
> Convert the VIA VT8500 and WonderMedia WM8xxx UART Controller to
> newer DT schema. Created DT schema based on the .txt file which had
> `compatible`, `reg`, `interrupts` and `clocks` as required properties.
>
> Additions to the original binding
> - changed the file name from vt8500-uart to via,vt8500-uart.yaml
> - removed unnecessary alias from the example.
>
> Signed-off-by: Kanak Shilledar <[email protected]>

Acked-by: Alexey Charkov <[email protected]>

Best regards,
Alexey

2024-06-13 19:24:54

by Rob Herring (Arm)

Subject: Re: [PATCH v3] dt-bindings: serial: vt8500-uart: convert to json-schema

On Wed, 12 Jun 2024 21:08:43 +0530, Kanak Shilledar wrote:
> Convert the VIA VT8500 and WonderMedia WM8xxx UART Controller to
> newer DT schema. Created DT schema based on the .txt file which had
> `compatible`, `reg`, `interrupts` and `clocks` as required properties.
>
> Additions to the original binding
> - changed the file name from vt8500-uart to via,vt8500-uart.yaml
> - removed unnecessary alias from the example.
>
> Signed-off-by: Kanak Shilledar <[email protected]>
> ---
> Changes in v3:
> - Removed Rob and myself from maintainers and added Alexey.
> - Fixed commit message which mentioned "greg and jiri as maintainers".
> - Elaborated changelog for v2.
> Changes in v2:
> - Rebased changes
> - Changed maintainers to have Rob and remove Greg and Jiri. VT8500 is
> orphaned according to the maintainers file.
> - Replaced `compatible` property description with comments.
> ---
> .../bindings/serial/via,vt8500-uart.yaml | 46 +++++++++++++++++++
> .../bindings/serial/vt8500-uart.txt | 27 -----------
> 2 files changed, 46 insertions(+), 27 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/serial/via,vt8500-uart.yaml
> delete mode 100644 Documentation/devicetree/bindings/serial/vt8500-uart.txt
>

Reviewed-by: Rob Herring (Arm) <[email protected]>