2024-06-12 16:27:59

by Dongliang Mu

Subject: [PATCH] docs/zh_CN: Update dev-tools/index.rst

Update to commit 8c88bc5b489e ("docs: dev-tools: Add UAPI checker
documentation")

Signed-off-by: Dongliang Mu <[email protected]>
---
Documentation/translations/zh_CN/dev-tools/index.rst | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Documentation/translations/zh_CN/dev-tools/index.rst b/Documentation/translations/zh_CN/dev-tools/index.rst
index fa900f5beb68..c540e4a7d5db 100644
--- a/Documentation/translations/zh_CN/dev-tools/index.rst
+++ b/Documentation/translations/zh_CN/dev-tools/index.rst
@@ -20,18 +20,22 @@ Documentation/translations/zh_CN/dev-tools/testing-overview.rst

testing-overview
sparse
+ kcov
gcov
kasan
- kcov
ubsan
kmemleak
gdb-kernel-debugging

Todolist:

+ - checkpatch
- coccinelle
+ - kmsan
- kcsan
- kfence
- kgdb
- kselftest
- kunit/index
+ - ktap
+ - checkuapi
--
2.34.1

2024-06-12 21:19:04

by Jonathan Corbet

Subject: Re: [PATCH] docs/zh_CN: Update dev-tools/index.rst

Dongliang Mu <[email protected]> writes:

> Update to commit 8c88bc5b489e ("docs: dev-tools: Add UAPI checker
> documentation")
>
> Signed-off-by: Dongliang Mu <[email protected]>
> ---
> Documentation/translations/zh_CN/dev-tools/index.rst | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/translations/zh_CN/dev-tools/index.rst b/Documentation/translations/zh_CN/dev-tools/index.rst
> index fa900f5beb68..c540e4a7d5db 100644
> --- a/Documentation/translations/zh_CN/dev-tools/index.rst
> +++ b/Documentation/translations/zh_CN/dev-tools/index.rst
> @@ -20,18 +20,22 @@ Documentation/translations/zh_CN/dev-tools/testing-overview.rst
>
> testing-overview
> sparse
> + kcov
> gcov
> kasan
> - kcov
> ubsan
> kmemleak
> gdb-kernel-debugging
>
> Todolist:
>
> + - checkpatch
> - coccinelle
> + - kmsan
> - kcsan
> - kfence
> - kgdb
> - kselftest
> - kunit/index
> + - ktap
> + - checkuapi

So I have to say that the changelog here is not particularly helpful.
You have *not* updated the translation to that commit, so it doesn't
seem like you should say that you did. "Add several newish documents to
the todo list" is appropriate for something like this.

I've applied the patch, but with the changed commit message.

Thanks,

jon

2024-06-13 06:15:56

by Dongliang Mu

Subject: Re: [PATCH] docs/zh_CN: Update dev-tools/index.rst

On 2024/6/13 05:12, Jonathan Corbet wrote:
> Dongliang Mu <[email protected]> writes:
>
>> Update to commit 8c88bc5b489e ("docs: dev-tools: Add UAPI checker
>> documentation")
>>
>> Signed-off-by: Dongliang Mu <[email protected]>
>> ---
>> Documentation/translations/zh_CN/dev-tools/index.rst | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/translations/zh_CN/dev-tools/index.rst b/Documentation/translations/zh_CN/dev-tools/index.rst
>> index fa900f5beb68..c540e4a7d5db 100644
>> --- a/Documentation/translations/zh_CN/dev-tools/index.rst
>> +++ b/Documentation/translations/zh_CN/dev-tools/index.rst
>> @@ -20,18 +20,22 @@ Documentation/translations/zh_CN/dev-tools/testing-overview.rst
>>
>> testing-overview
>> sparse
>> + kcov
>> gcov
>> kasan
>> - kcov
>> ubsan
>> kmemleak
>> gdb-kernel-debugging
>>
>> Todolist:
>>
>> + - checkpatch
>> - coccinelle
>> + - kmsan
>> - kcsan
>> - kfence
>> - kgdb
>> - kselftest
>> - kunit/index
>> + - ktap
>> + - checkuapi
> So I have to say that the changelog here is not particularly helpful.
> You have *not* updated the translation to that commit, so it doesn't
> seem like you should say that you did. "Add several newish documents to
> the todo list" is appropriate for something like this.


Yes, I should use another commit message to describe what I am doing.


> I've applied the patch, but with the changed commit message.


Thanks very much.


>
> Thanks,
>
> jon