2024-06-13 04:59:32

by David Thompson

Subject: [PATCH v2 1/2] EDAC/bluefield: fix white space in bluefield_edac_mc_probe

The routine bluefield_edac_mc_probe() has an extra empty line,
so it must be removed. This extra line is flagged when running
"scripts/checkpatch --strict":
CHECK: Blank lines aren't necessary before a close brace '}'
#324: FILE: drivers/edac/bluefield_edac.c:324:
+
+}

Signed-off-by: David Thompson <[email protected]>
Reviewed-by: Shravan Kumar Ramani <[email protected]>
---
v2
- Updated commit message per review comments
---
drivers/edac/bluefield_edac.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/edac/bluefield_edac.c b/drivers/edac/bluefield_edac.c
index 5b3164560648..1f6f39a7dbf3 100644
--- a/drivers/edac/bluefield_edac.c
+++ b/drivers/edac/bluefield_edac.c
@@ -320,7 +320,6 @@ static int bluefield_edac_mc_probe(struct platform_device *pdev)
edac_mc_free(mci);

return ret;
-
}

static void bluefield_edac_mc_remove(struct platform_device *pdev)
--
2.30.1

2024-06-13 07:55:22

by Borislav Petkov

Subject: Re: [PATCH v2 1/2] EDAC/bluefield: fix white space in bluefield_edac_mc_probe

On Thu, Jun 13, 2024 at 12:59:01AM -0400, David Thompson wrote:
> The routine bluefield_edac_mc_probe() has an extra empty line,
> so it must be removed. This extra line is flagged when running
> "scripts/checkpatch --strict":
> CHECK: Blank lines aren't necessary before a close brace '}'
> #324: FILE: drivers/edac/bluefield_edac.c:324:
> +
> +}
>
> Signed-off-by: David Thompson <[email protected]>
> Reviewed-by: Shravan Kumar Ramani <[email protected]>
> ---
> v2
> - Updated commit message per review comments
> ---
> drivers/edac/bluefield_edac.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/edac/bluefield_edac.c b/drivers/edac/bluefield_edac.c
> index 5b3164560648..1f6f39a7dbf3 100644
> --- a/drivers/edac/bluefield_edac.c
> +++ b/drivers/edac/bluefield_edac.c
> @@ -320,7 +320,6 @@ static int bluefield_edac_mc_probe(struct platform_device *pdev)
> edac_mc_free(mci);
>
> return ret;
> -
> }
>
> static void bluefield_edac_mc_remove(struct platform_device *pdev)
> --

Did you get my reply to this and did you read it?

https://lore.kernel.org/r/20240612200056.GGZmn-eO15ePolbAPo@fat_crate.local

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette