2024-06-13 13:46:35

by Simon Trimmer

Subject: [PATCH 0/3] ALSA: hda: Component should be unbound before deconstruction

Small chain of fixes to correct hda drivers using the hda component
infrastructure so that they unregister their component before proceeding
to deconstruct the driver.

These three patches been separated from the chain "[PATCH v2 0/7] ALSA:
hda: Improvements to hda_component"

Simon Trimmer (3):
ALSA: hda: cs35l56: Component should be unbound before deconstruction
ALSA: hda: cs35l41: Component should be unbound before deconstruction
ALSA: hda: tas2781: Component should be unbound before deconstruction

sound/pci/hda/cs35l41_hda.c | 4 ++--
sound/pci/hda/cs35l56_hda.c | 4 ++--
sound/pci/hda/tas2781_hda_i2c.c | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)

--
2.34.1

2024-06-13 13:57:36

by Simon Trimmer

Subject: [PATCH 3/3] ALSA: hda: tas2781: Component should be unbound before deconstruction

The interface associated with the hda_component should be deactivated
before the driver is deconstructed during removal.

Fixes: 4e7914eb1dae ("ALSA: hda/tas2781: remove sound controls in unbind")
Signed-off-by: Simon Trimmer <[email protected]>
---
sound/pci/hda/tas2781_hda_i2c.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2c.c
index 75f7674c66ee..fdee6592c502 100644
--- a/sound/pci/hda/tas2781_hda_i2c.c
+++ b/sound/pci/hda/tas2781_hda_i2c.c
@@ -777,11 +777,11 @@ static void tas2781_hda_remove(struct device *dev)
{
struct tas2781_hda *tas_hda = dev_get_drvdata(dev);

+ component_del(tas_hda->dev, &tas2781_hda_comp_ops);
+
pm_runtime_get_sync(tas_hda->dev);
pm_runtime_disable(tas_hda->dev);

- component_del(tas_hda->dev, &tas2781_hda_comp_ops);
-
pm_runtime_put_noidle(tas_hda->dev);

tasdevice_remove(tas_hda->priv);
--
2.34.1

2024-06-14 13:07:15

by Takashi Iwai

Subject: Re: [PATCH 0/3] ALSA: hda: Component should be unbound before deconstruction

On Thu, 13 Jun 2024 15:37:10 +0200,
Simon Trimmer wrote:
>
> Small chain of fixes to correct hda drivers using the hda component
> infrastructure so that they unregister their component before proceeding
> to deconstruct the driver.
>
> These three patches been separated from the chain "[PATCH v2 0/7] ALSA:
> hda: Improvements to hda_component"
>
> Simon Trimmer (3):
> ALSA: hda: cs35l56: Component should be unbound before deconstruction
> ALSA: hda: cs35l41: Component should be unbound before deconstruction
> ALSA: hda: tas2781: Component should be unbound before deconstruction

Applied to for-linus branch now.


thanks,

Takashi