2024-06-13 22:57:46

by Thomas Weißschuh

Subject: [PATCH] watchdog: Make watchdog_class const

Now that the driver core allows for struct class to be in read-only
memory, mark watchdog_class as const.

Signed-off-by: Thomas Weißschuh <[email protected]>
---
drivers/watchdog/watchdog_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c
index e2bd266b1b5b..4190cb800cc4 100644
--- a/drivers/watchdog/watchdog_dev.c
+++ b/drivers/watchdog/watchdog_dev.c
@@ -1004,7 +1004,7 @@ static struct miscdevice watchdog_miscdev = {
.fops = &watchdog_fops,
};

-static struct class watchdog_class = {
+static const struct class watchdog_class = {
.name = "watchdog",
.dev_groups = wdt_groups,
};

---
base-commit: d20f6b3d747c36889b7ce75ee369182af3decb6b
change-id: 20240614-class-const-wdt-3649d0adc431

Best regards,
--
Thomas Weißschuh <[email protected]>

2024-06-13 23:53:38

by Guenter Roeck

Subject: Re: [PATCH] watchdog: Make watchdog_class const

On 6/13/24 15:57, Thomas Weißschuh wrote:
> Now that the driver core allows for struct class to be in read-only
> memory, mark watchdog_class as const.
>
> Signed-off-by: Thomas Weißschuh <[email protected]>

Reviewed-by: Guenter Roeck <[email protected]>

> ---
> drivers/watchdog/watchdog_dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c
> index e2bd266b1b5b..4190cb800cc4 100644
> --- a/drivers/watchdog/watchdog_dev.c
> +++ b/drivers/watchdog/watchdog_dev.c
> @@ -1004,7 +1004,7 @@ static struct miscdevice watchdog_miscdev = {
> .fops = &watchdog_fops,
> };
>
> -static struct class watchdog_class = {
> +static const struct class watchdog_class = {
> .name = "watchdog",
> .dev_groups = wdt_groups,
> };
>
> ---
> base-commit: d20f6b3d747c36889b7ce75ee369182af3decb6b
> change-id: 20240614-class-const-wdt-3649d0adc431
>
> Best regards,