LinuxLists.cc - [PATCH 0/2] ASoC: dt-bindings: Convert realtek CODEC bindings to DT schema

2024-06-14 03:39:03

Subject: [PATCH 0/2] ASoC: dt-bindings: Convert realtek CODEC bindings to DT schema

Hey all,
This patch series converts two of the thirteen realtek audio codec
bindings which are still in txt format to DT schema. I have chosen
these bindings as they have in tree DTS files.

Thanks,
Animesh

Animesh Agarwal (2):
ASoC: dt-bindings: realtek,rt5514: Convert to dtschema
ASoC: dt-bindings: realtek,rt5631: Convert to dtschema

.../bindings/sound/realtek,rt5514.yaml | 60 ++++++++++++++++++
.../bindings/sound/realtek,rt5631.yaml | 63 +++++++++++++++++++
.../devicetree/bindings/sound/rt5514.txt | 37 -----------
.../devicetree/bindings/sound/rt5631.txt | 48 --------------
4 files changed, 123 insertions(+), 85 deletions(-)
create mode 100644 Documentation/devicetree/bindings/sound/realtek,rt5514.yaml
create mode 100644 Documentation/devicetree/bindings/sound/realtek,rt5631.yaml
delete mode 100644 Documentation/devicetree/bindings/sound/rt5514.txt
delete mode 100644 Documentation/devicetree/bindings/sound/rt5631.txt

--
2.45.2

2024-06-14 03:39:22

by Animesh Agarwal

[permalink] [raw]

Subject: [PATCH 1/2] ASoC: dt-bindings: realtek,rt5514: Convert to dtschema

Convert the RT5514 audio CODEC bindings to DT Schema.

Signed-off-by: Animesh Agarwal <[email protected]>
Cc: Daniel Baluta <[email protected]>
---
.../bindings/sound/realtek,rt5514.yaml | 60 +++++++++++++++++++
.../devicetree/bindings/sound/rt5514.txt | 37 ------------
2 files changed, 60 insertions(+), 37 deletions(-)
create mode 100644 Documentation/devicetree/bindings/sound/realtek,rt5514.yaml
delete mode 100644 Documentation/devicetree/bindings/sound/rt5514.txt

diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5514.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5514.yaml
new file mode 100644
index 000000000000..28e5f583fd91
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/realtek,rt5514.yaml
@@ -0,0 +1,60 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/realtek,rt5514.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: RT5514 audio CODEC
+
+description: |
+ This device supports both I2C and SPI.
+
+ Pins on the device (for linking into audio routes) for I2C:
+ * DMIC1L
+ * DMIC1R
+ * DMIC2L
+ * DMIC2R
+ * AMICL
+ * AMICR
+
+maintainers:
+ - Animesh Agarwal <[email protected]>
+
+properties:
+ compatible:
+ const: realtek,rt5514
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ items:
+ - description: Master clock to the CODEC
+
+ clock-names:
+ items:
+ - const: mclk
+
+ interrupts:
+ maxItems: 1
+ description: The interrupt number to the cpu.
+
+ realtek,dmic-init-delay-ms:
+ description: Set the DMIC initial delay (ms) to wait it ready for I2C.
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ codec@57 {
+ compatible = "realtek,rt5514";
+ reg = <0x57>;
+ };
+ };
diff --git a/Documentation/devicetree/bindings/sound/rt5514.txt b/Documentation/devicetree/bindings/sound/rt5514.txt
deleted file mode 100644
index d2cc171f22f2..000000000000
--- a/Documentation/devicetree/bindings/sound/rt5514.txt
+++ /dev/null
@@ -1,37 +0,0 @@
-RT5514 audio CODEC
-
-This device supports both I2C and SPI.
-
-Required properties:
-
-- compatible : "realtek,rt5514".
-
-- reg : the I2C address of the device for I2C, the chip select
- number for SPI.
-
-Optional properties:
-
-- clocks: The phandle of the master clock to the CODEC
-- clock-names: Should be "mclk"
-
-- interrupts: The interrupt number to the cpu. The interrupt specifier format
- depends on the interrupt controller.
-
-- realtek,dmic-init-delay-ms
- Set the DMIC initial delay (ms) to wait it ready for I2C.
-
-Pins on the device (for linking into audio routes) for I2C:
-
- * DMIC1L
- * DMIC1R
- * DMIC2L
- * DMIC2R
- * AMICL
- * AMICR
-
-Example:
-
-rt5514: codec@57 {
- compatible = "realtek,rt5514";
- reg = <0x57>;
-};
--
2.45.2

2024-06-14 03:39:40

by Animesh Agarwal

[permalink] [raw]

Subject: [PATCH 2/2] ASoC: dt-bindings: realtek,rt5631: Convert to dtschema

Convert the ALC5631/RT5631 audio CODEC bindings to DT Schema.

Signed-off-by: Animesh Agarwal <[email protected]>
Cc: Daniel Baluta <[email protected]>
---
.../bindings/sound/realtek,rt5631.yaml | 63 +++++++++++++++++++
.../devicetree/bindings/sound/rt5631.txt | 48 --------------
2 files changed, 63 insertions(+), 48 deletions(-)
create mode 100644 Documentation/devicetree/bindings/sound/realtek,rt5631.yaml
delete mode 100644 Documentation/devicetree/bindings/sound/rt5631.txt

diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5631.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5631.yaml
new file mode 100644
index 000000000000..05b83d907b38
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/realtek,rt5631.yaml
@@ -0,0 +1,63 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/realtek,rt5631.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ALC5631/RT5631 audio CODEC
+
+description: |
+ This device supports I2C only.
+
+ Pins on the device (for linking into audio routes):
+ * SPK_OUT_R_P
+ * SPK_OUT_R_N
+ * SPK_OUT_L_P
+ * SPK_OUT_L_N
+ * HP_OUT_L
+ * HP_OUT_R
+ * AUX_OUT2_LP
+ * AUX_OUT2_RN
+ * AUX_OUT1_LP
+ * AUX_OUT1_RN
+ * AUX_IN_L_JD
+ * AUX_IN_R_JD
+ * MONO_IN_P
+ * MONO_IN_N
+ * MIC1_P
+ * MIC1_N
+ * MIC2_P
+ * MIC2_N
+ * MONO_OUT_P
+ * MONO_OUT_N
+ * MICBIAS1
+ * MICBIAS2
+
+maintainers:
+ - Animesh Agarwal <[email protected]>
+
+properties:
+ compatible:
+ enum:
+ - realtek,alc5631
+ - realtek,rt5631
+
+ reg:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ codec@1a {
+ compatible = "realtek,alc5631";
+ reg = <0x1a>;
+ };
+ };
diff --git a/Documentation/devicetree/bindings/sound/rt5631.txt b/Documentation/devicetree/bindings/sound/rt5631.txt
deleted file mode 100644
index 56bc85232c49..000000000000
--- a/Documentation/devicetree/bindings/sound/rt5631.txt
+++ /dev/null
@@ -1,48 +0,0 @@
-ALC5631/RT5631 audio CODEC
-
-This device supports I2C only.
-
-Required properties:
-
- - compatible : "realtek,alc5631" or "realtek,rt5631"
-
- - reg : the I2C address of the device.
-
-Pins on the device (for linking into audio routes):
-
- * SPK_OUT_R_P
- * SPK_OUT_R_N
- * SPK_OUT_L_P
- * SPK_OUT_L_N
- * HP_OUT_L
- * HP_OUT_R
- * AUX_OUT2_LP
- * AUX_OUT2_RN
- * AUX_OUT1_LP
- * AUX_OUT1_RN
- * AUX_IN_L_JD
- * AUX_IN_R_JD
- * MONO_IN_P
- * MONO_IN_N
- * MIC1_P
- * MIC1_N
- * MIC2_P
- * MIC2_N
- * MONO_OUT_P
- * MONO_OUT_N
- * MICBIAS1
- * MICBIAS2
-
-Example:
-
-alc5631: audio-codec@1a {
- compatible = "realtek,alc5631";
- reg = <0x1a>;
-};
-
-or
-
-rt5631: audio-codec@1a {
- compatible = "realtek,rt5631";
- reg = <0x1a>;
-};
--
2.45.2

2024-06-14 08:32:27

by Krzysztof Kozlowski

[permalink] [raw]

Subject: Re: [PATCH 0/2] ASoC: dt-bindings: Convert realtek CODEC bindings to DT schema

On 14/06/2024 05:38, Animesh Agarwal wrote:
> Hey all,
> This patch series converts two of the thirteen realtek audio codec
> bindings which are still in txt format to DT schema. I have chosen
> these bindings as they have in tree DTS files.

... and the point of DTS is?

To validate the DTS against bindings and see if they match.

You received such feedback already.

Best regards,
Krzysztof

2024-06-14 08:34:50

by Krzysztof Kozlowski

[permalink] [raw]

Subject: Re: [PATCH 2/2] ASoC: dt-bindings: realtek,rt5631: Convert to dtschema

On 14/06/2024 05:38, Animesh Agarwal wrote:
> Convert the ALC5631/RT5631 audio CODEC bindings to DT Schema.
>
> Signed-off-by: Animesh Agarwal <[email protected]>
> Cc: Daniel Baluta <[email protected]>
> ---
> .../bindings/sound/realtek,rt5631.yaml | 63 +++++++++++++++++++
> .../devicetree/bindings/sound/rt5631.txt | 48 --------------
> 2 files changed, 63 insertions(+), 48 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/sound/realtek,rt5631.yaml
> delete mode 100644 Documentation/devicetree/bindings/sound/rt5631.txt
>
> diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5631.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5631.yaml
> new file mode 100644
> index 000000000000..05b83d907b38
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/realtek,rt5631.yaml
> @@ -0,0 +1,63 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/realtek,rt5631.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ALC5631/RT5631 audio CODEC
> +
> +description: |

Please keep the order as in example-schema, so first maintainers then
description. This applies to all your patches.

> + This device supports I2C only.
> +
> + Pins on the device (for linking into audio routes):
> + * SPK_OUT_R_P
> + * SPK_OUT_R_N
> + * SPK_OUT_L_P
> + * SPK_OUT_L_N
> + * HP_OUT_L
> + * HP_OUT_R
> + * AUX_OUT2_LP
> + * AUX_OUT2_RN
> + * AUX_OUT1_LP
> + * AUX_OUT1_RN
> + * AUX_IN_L_JD
> + * AUX_IN_R_JD
> + * MONO_IN_P
> + * MONO_IN_N
> + * MIC1_P
> + * MIC1_N
> + * MIC2_P
> + * MIC2_N
> + * MONO_OUT_P
> + * MONO_OUT_N
> + * MICBIAS1
> + * MICBIAS2
> +
> +maintainers:
> + - Animesh Agarwal <[email protected]>
> +
> +properties:
> + compatible:
> + enum:
> + - realtek,alc5631
> + - realtek,rt5631
> +
> + reg:
> + maxItems: 1

Just open the DTS and immediately you will see it is incomplete.

Best regards,
Krzysztof

2024-06-14 08:44:05

by Krzysztof Kozlowski

[permalink] [raw]

Subject: Re: [PATCH 1/2] ASoC: dt-bindings: realtek,rt5514: Convert to dtschema

On 14/06/2024 05:38, Animesh Agarwal wrote:
> +maintainers:
> + - Animesh Agarwal <[email protected]>

Missing ref to spi peri props.

> +
> +properties:
> + compatible:
> + const: realtek,rt5514
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: Master clock to the CODEC
> +
> + clock-names:
> + items:
> + - const: mclk
> +
> + interrupts:
> + maxItems: 1
> + description: The interrupt number to the cpu.
> +
> + realtek,dmic-init-delay-ms:
> + description: Set the DMIC initial delay (ms) to wait it ready for I2C.

wakeup-source and maybe other properties. I don't think you tested DTS.

unevaluatedProperties: false.

Best regards,
Krzysztof

2024-06-14 18:20:29

by kernel test robot

[permalink] [raw]

Subject: Re: [PATCH 1/2] ASoC: dt-bindings: realtek,rt5514: Convert to dtschema

Hi Animesh,

kernel test robot noticed the following build warnings:

[auto build test WARNING on broonie-sound/for-next]
[also build test WARNING on linus/master v6.10-rc3 next-20240613]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Animesh-Agarwal/ASoC-dt-bindings-realtek-rt5514-Convert-to-dtschema/20240614-114128
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
patch link: https://lore.kernel.org/r/20240614033812.51312-2-animeshagarwal28%40gmail.com
patch subject: [PATCH 1/2] ASoC: dt-bindings: realtek,rt5514: Convert to dtschema
config: arm64-randconfig-051-20240614 (https://download.01.org/0day-ci/archive/20240615/[email protected]/config)
compiler: aarch64-linux-gcc (GCC) 13.2.0
dtschema version: 2024.6.dev1+g833054f
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240615/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

dtcheck warnings: (new ones prefixed by >>)
arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dtb: pcie@0,0: wifi@0,0:interrupts:0:0: 8 is not one of [1, 2, 3, 4]
from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml#
arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dtb: pcie@0,0: wifi@0,0:interrupts:0: [8, 8] is too long
from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml#
arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dtb: usb@fe800000: 'extcon' does not match any of the regexes: '^usb@', 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/usb/rockchip,rk3399-dwc3.yaml#
arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dtb: usb@fe900000: 'extcon' does not match any of the regexes: '^usb@', 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/usb/rockchip,rk3399-dwc3.yaml#
arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dtb: /dp@fec00000: failed to match any schema with compatible: ['rockchip,rk3399-cdn-dp']
>> arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dtb: spi2@0: 'spi-max-frequency', 'wakeup-source' do not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/sound/realtek,rt5514.yaml#
arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dtb: da7219@1a: da7219_aad:dlg,jack-det-rate:0: '32ms_64ms' is not one of ['32_64', '64_128', '128_256', '256_512']
from schema $id: http://devicetree.org/schemas/sound/dialog,da7219.yaml#
arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dtb: /syscon@ff770000/phy@f780: failed to match any schema with compatible: ['rockchip,rk3399-emmc-phy']
arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dtb: /syscon@ff770000/pcie-phy: failed to match any schema with compatible: ['rockchip,rk3399-pcie-phy']
arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dtb: /phy@ff7c0000: failed to match any schema with compatible: ['rockchip,rk3399-typec-phy']
arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dtb: /phy@ff800000: failed to match any schema with compatible: ['rockchip,rk3399-typec-phy']
arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dtb: /ppvar-bigcpu: failed to match any schema with compatible: ['vctrl-regulator']
arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dtb: /ppvar-litcpu: failed to match any schema with compatible: ['vctrl-regulator']
arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dtb: /ppvar-gpu: failed to match any schema with compatible: ['vctrl-regulator']
--
arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dtb: pcie@0,0: wifi@0,0:interrupts:0:0: 8 is not one of [1, 2, 3, 4]
from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml#
arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dtb: pcie@0,0: wifi@0,0:interrupts:0: [8, 8] is too long
from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml#
arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dtb: usb@fe800000: 'extcon' does not match any of the regexes: '^usb@', 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/usb/rockchip,rk3399-dwc3.yaml#
arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dtb: usb@fe900000: 'extcon' does not match any of the regexes: '^usb@', 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/usb/rockchip,rk3399-dwc3.yaml#
arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dtb: /dp@fec00000: failed to match any schema with compatible: ['rockchip,rk3399-cdn-dp']
>> arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dtb: spi2@0: 'spi-max-frequency', 'wakeup-source' do not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/sound/realtek,rt5514.yaml#
arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dtb: da7219@1a: da7219_aad:dlg,jack-det-rate:0: '32ms_64ms' is not one of ['32_64', '64_128', '128_256', '256_512']
from schema $id: http://devicetree.org/schemas/sound/dialog,da7219.yaml#
arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dtb: /syscon@ff770000/phy@f780: failed to match any schema with compatible: ['rockchip,rk3399-emmc-phy']
arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dtb: /syscon@ff770000/pcie-phy: failed to match any schema with compatible: ['rockchip,rk3399-pcie-phy']
arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dtb: /phy@ff7c0000: failed to match any schema with compatible: ['rockchip,rk3399-typec-phy']
arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dtb: /phy@ff800000: failed to match any schema with compatible: ['rockchip,rk3399-typec-phy']
arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dtb: /ppvar-bigcpu: failed to match any schema with compatible: ['vctrl-regulator']
arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dtb: /ppvar-litcpu: failed to match any schema with compatible: ['vctrl-regulator']
arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dtb: /ppvar-gpu: failed to match any schema with compatible: ['vctrl-regulator']

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

2024-06-16 00:41:19

by kernel test robot

[permalink] [raw]