2002-06-05 01:28:00

by Keith Owens

[permalink] [raw]
Subject: 2.5.20 i2c uses nonexistent linux/i2c-old.h

drivers/media/video/adv7175.c:#include <linux/i2c-old.h>
drivers/media/video/bt819.c:#include <linux/i2c-old.h>
drivers/media/video/bt856.c:#include <linux/i2c-old.h>
drivers/media/video/i2c-parport.c:#include <linux/i2c-old.h>
drivers/media/video/i2c-old.c:#include <linux/i2c-old.h>
drivers/media/video/saa7110.c:#include <linux/i2c-old.h>
drivers/media/video/saa7111.c:#include <linux/i2c-old.h>
drivers/media/video/saa7185.c:#include <linux/i2c-old.h>
drivers/media/video/zr36067.c:#include <linux/i2c-old.h>
drivers/media/video/zr36120.h:#include <linux/i2c-old.h>

There is no file called i2c-old.h in 2.5.20. These only build because
they pick up i2c-old.h from /usr/include/linux :(.


2002-06-05 16:43:22

by Alan

[permalink] [raw]
Subject: Re: 2.5.20 i2c uses nonexistent linux/i2c-old.h

On Wed, 2002-06-05 at 02:27, Keith Owens wrote:
> drivers/media/video/adv7175.c:#include <linux/i2c-old.h>
> drivers/media/video/bt819.c:#include <linux/i2c-old.h>
> drivers/media/video/bt856.c:#include <linux/i2c-old.h>
> drivers/media/video/i2c-parport.c:#include <linux/i2c-old.h>
> drivers/media/video/i2c-old.c:#include <linux/i2c-old.h>
> drivers/media/video/saa7110.c:#include <linux/i2c-old.h>
> drivers/media/video/saa7111.c:#include <linux/i2c-old.h>
> drivers/media/video/saa7185.c:#include <linux/i2c-old.h>
> drivers/media/video/zr36067.c:#include <linux/i2c-old.h>
> drivers/media/video/zr36120.h:#include <linux/i2c-old.h>
>
> There is no file called i2c-old.h in 2.5.20. These only build because
> they pick up i2c-old.h from /usr/include/linux :(.

i2c-old was back compatibility for obsolete code from 2.2 into 2.4. Its
dead its gone, and now folks need to go fix the drivers

2002-06-05 17:17:20

by Dave Jones

[permalink] [raw]
Subject: Re: 2.5.20 i2c uses nonexistent linux/i2c-old.h

On Wed, Jun 05, 2002 at 06:35:45PM +0100, Alan Cox wrote:
> > drivers/media/video/i2c-old.c:#include <linux/i2c-old.h>
> > drivers/media/video/saa7110.c:#include <linux/i2c-old.h>
> > drivers/media/video/saa7111.c:#include <linux/i2c-old.h>
> > drivers/media/video/saa7185.c:#include <linux/i2c-old.h>
> > drivers/media/video/zr36067.c:#include <linux/i2c-old.h>
> > drivers/media/video/zr36120.h:#include <linux/i2c-old.h>
> >
> > There is no file called i2c-old.h in 2.5.20. These only build because
> > they pick up i2c-old.h from /usr/include/linux :(.
>
> i2c-old was back compatibility for obsolete code from 2.2 into 2.4. Its
> dead its gone, and now folks need to go fix the drivers

Which makes me wonder why it compiled for Keith.
Why is kbuild2.5 expanding <linux/foo.h> to /usr/include/linux/foo.h ?
If $sourcetree/include/linux/foo.h doesn't exist, it should stop
compiling, not look in /usr/include/ for a (obsolete/wrong) alternative.

Dave.

--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs

2002-06-05 23:41:43

by Keith Owens

[permalink] [raw]
Subject: Re: 2.5.20 i2c uses nonexistent linux/i2c-old.h

On Wed, 5 Jun 2002 19:17:19 +0200,
Dave Jones <[email protected]> wrote:
>Why is kbuild2.5 expanding <linux/foo.h> to /usr/include/linux/foo.h ?
>If $sourcetree/include/linux/foo.h doesn't exist, it should stop
>compiling, not look in /usr/include/ for a (obsolete/wrong) alternative.

The nostdinc code in core-15 was incomplete, it was corrected in
core-16 which then highlighted the missing includes. Just a bug.