2022-01-13 08:55:48

by Jérôme Pouiller

Subject: [PATCH 02/31] staging: wfx: fix HIF API license

From: Jérôme Pouiller <[email protected]>

Apache-2.0 is not allowed in the kernel.

Signed-off-by: Jérôme Pouiller <[email protected]>
---
drivers/staging/wfx/hif_api_cmd.h | 2 +-
drivers/staging/wfx/hif_api_general.h | 2 +-
drivers/staging/wfx/hif_api_mib.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wfx/hif_api_cmd.h b/drivers/staging/wfx/hif_api_cmd.h
index b0aa13b23a51..b1829d01a5d9 100644
--- a/drivers/staging/wfx/hif_api_cmd.h
+++ b/drivers/staging/wfx/hif_api_cmd.h
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: Apache-2.0 */
+/* SPDX-License-Identifier: GPL-2.0-only or Apache-2.0 */
/*
* WF200 hardware interface definitions
*
diff --git a/drivers/staging/wfx/hif_api_general.h b/drivers/staging/wfx/hif_api_general.h
index 5f74f829b7df..3e5c92e12d35 100644
--- a/drivers/staging/wfx/hif_api_general.h
+++ b/drivers/staging/wfx/hif_api_general.h
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: Apache-2.0 */
+/* SPDX-License-Identifier: GPL-2.0-only or Apache-2.0 */
/*
* WF200 hardware interface definitions
*
diff --git a/drivers/staging/wfx/hif_api_mib.h b/drivers/staging/wfx/hif_api_mib.h
index da534f244757..be76e2766880 100644
--- a/drivers/staging/wfx/hif_api_mib.h
+++ b/drivers/staging/wfx/hif_api_mib.h
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: Apache-2.0 */
+/* SPDX-License-Identifier: GPL-2.0-only or Apache-2.0 */
/*
* WF200 hardware interface definitions
*
--
2.34.1

2022-01-13 11:50:33

by Kalle Valo

Subject: Re: [PATCH 02/31] staging: wfx: fix HIF API license

Jerome Pouiller <[email protected]> writes:

> From: Jérôme Pouiller <[email protected]>
>
> Apache-2.0 is not allowed in the kernel.
>
> Signed-off-by: Jérôme Pouiller <[email protected]>
> ---
> drivers/staging/wfx/hif_api_cmd.h | 2 +-
> drivers/staging/wfx/hif_api_general.h | 2 +-
> drivers/staging/wfx/hif_api_mib.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/wfx/hif_api_cmd.h b/drivers/staging/wfx/hif_api_cmd.h
> index b0aa13b23a51..b1829d01a5d9 100644
> --- a/drivers/staging/wfx/hif_api_cmd.h
> +++ b/drivers/staging/wfx/hif_api_cmd.h
> @@ -1,4 +1,4 @@
> -/* SPDX-License-Identifier: Apache-2.0 */
> +/* SPDX-License-Identifier: GPL-2.0-only or Apache-2.0 */

Is the Apache-2.0 license really mandatory? LICENSES/dual/Apache-2.0 is
not really supportive.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2022-01-13 12:16:19

by Jérôme Pouiller

Subject: Re: [PATCH 02/31] staging: wfx: fix HIF API license

On Thursday 13 January 2022 12:50:23 CET Kalle Valo wrote:
> Jerome Pouiller <[email protected]> writes:
>
> > From: J?r?me Pouiller <[email protected]>
> >
> > Apache-2.0 is not allowed in the kernel.
> >
> > Signed-off-by: J?r?me Pouiller <[email protected]>
> > ---
> > drivers/staging/wfx/hif_api_cmd.h | 2 +-
> > drivers/staging/wfx/hif_api_general.h | 2 +-
> > drivers/staging/wfx/hif_api_mib.h | 2 +-
> > 3 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/wfx/hif_api_cmd.h b/drivers/staging/wfx/hif_api_cmd.h
> > index b0aa13b23a51..b1829d01a5d9 100644
> > --- a/drivers/staging/wfx/hif_api_cmd.h
> > +++ b/drivers/staging/wfx/hif_api_cmd.h
> > @@ -1,4 +1,4 @@
> > -/* SPDX-License-Identifier: Apache-2.0 */
> > +/* SPDX-License-Identifier: GPL-2.0-only or Apache-2.0 */
>
> Is the Apache-2.0 license really mandatory? LICENSES/dual/Apache-2.0 is
> not really supportive.

[usual "I am not a lawyer" preamble]

hmm... I don't think it is really mandatory. However, I would more
confident if we could keep the original license also (I think the idea
behind is to not prevent someone to reuse this header in any other
project).


--
J?r?me Pouiller