2021-06-14 16:19:13

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.10 000/130] 5.10.44-rc2 review

This is the start of the stable review cycle for the 5.10.44 release.
There are 130 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.

Responses should be made by Wed, 16 Jun 2021 16:13:59 +0000.
Anything received after that time might be too late.

The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.44-rc2.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <[email protected]>
Linux 5.10.44-rc2

Liangyan <[email protected]>
tracing: Correct the length check which causes memory corruption

Ming Lei <[email protected]>
scsi: core: Only put parent device if host state differs from SHOST_CREATED

Ming Lei <[email protected]>
scsi: core: Put .shost_dev in failure path if host state changes to RUNNING

Ming Lei <[email protected]>
scsi: core: Fix failure handling of scsi_add_host_with_dma()

Ming Lei <[email protected]>
scsi: core: Fix error handling of scsi_host_alloc()

Dai Ngo <[email protected]>
NFSv4: nfs4_proc_set_acl needs to restore NFS_CAP_UIDGID_NOMAP on error.

Trond Myklebust <[email protected]>
NFSv4: Fix second deadlock in nfs4_evict_inode()

Anna Schumaker <[email protected]>
NFS: Fix use-after-free in nfs4_init_client()

Paolo Bonzini <[email protected]>
kvm: fix previous commit for 32-bit builds

Leo Yan <[email protected]>
perf session: Correct buffer copying when peeking events

Trond Myklebust <[email protected]>
NFSv4: Fix deadlock between nfs4_evict_inode() and nfs4_opendata_get_inode()

Dan Carpenter <[email protected]>
NFS: Fix a potential NULL dereference in nfs_get_client()

Alaa Hleihel <[email protected]>
IB/mlx5: Fix initializing CQ fragments buffer

Sean Christopherson <[email protected]>
KVM: x86: Ensure liveliness of nested VM-Enter fail tracepoint message

CodyYao-oc <[email protected]>
x86/nmi_watchdog: Fix old-style NMI watchdog regression on old Intel CPUs

Dietmar Eggemann <[email protected]>
sched/fair: Fix util_est UTIL_AVG_UNCHANGED handling

Vincent Guittot <[email protected]>
sched/fair: Make sure to update tg contrib for blocked load

Vincent Guittot <[email protected]>
sched/fair: Keep load_avg and load_sum synced

Marco Elver <[email protected]>
perf: Fix data race between pin_count increment/decrement

Srinivas Kandagatla <[email protected]>
gpio: wcd934x: Fix shift-out-of-bounds error

Yang Li <[email protected]>
phy: ti: Fix an error code in wiz_probe()

Jerome Brunet <[email protected]>
ASoC: meson: gx-card: fix sound-dai dt schema

Kefeng Wang <[email protected]>
ASoC: core: Fix Null-point-dereference in fmt_single_name()

Wang Wensheng <[email protected]>
phy: cadence: Sierra: Fix error return code in cdns_sierra_phy_probe()

Zhen Lei <[email protected]>
tools/bootconfig: Fix error return code in apply_xbc()

Nathan Chancellor <[email protected]>
vmlinux.lds.h: Avoid orphan section with !SMP

Arnd Bergmann <[email protected]>
ARM: cpuidle: Avoid orphan section warning

Shay Drory <[email protected]>
RDMA/mlx4: Do not map the core_clock page to user space unless enabled

Kamal Heib <[email protected]>
RDMA/ipoib: Fix warning caused by destroying non-initial netns

Jonathan Marek <[email protected]>
drm/msm/a6xx: avoid shadow NULL reference in failure path

Jonathan Marek <[email protected]>
drm/msm/a6xx: update/fix CP_PROTECT initialization

Jonathan Marek <[email protected]>
drm/msm/a6xx: fix incorrectly set uavflagprd_inv field for A650

Linus Walleij <[email protected]>
drm/mcde: Fix off by 10^3 in calculation

Bjorn Andersson <[email protected]>
usb: typec: mux: Fix copy-paste mistake in typec_mux_match

Wesley Cheng <[email protected]>
usb: dwc3: gadget: Disable gadget IRQ during pullup disable

Chen Li <[email protected]>
phy: usb: Fix misuse of IS_ENABLED

Axel Lin <[email protected]>
regulator: rtmv20: Fix .set_current_limit/.get_current_limit callbacks

Axel Lin <[email protected]>
regulator: bd71828: Fix .n_voltages settings

Axel Lin <[email protected]>
regulator: fan53880: Fix missing n_voltages setting

Matti Vaittinen <[email protected]>
regulator: bd718x7: Fix the BUCK7 voltage setting on BD71837

Dmitry Osipenko <[email protected]>
regulator: max77620: Use device_set_of_node_from_dev()

Dmitry Baryshkov <[email protected]>
regulator: core: resolve supply for boot-on/always-on regulators

Li Jun <[email protected]>
usb: typec: tcpm: cancel frs hrtimer when unregister tcpm port

Li Jun <[email protected]>
usb: typec: tcpm: cancel vdm and state machine hrtimer when unregister tcpm port

Maciej Żenczykowski <[email protected]>
usb: fix various gadget panics on 10gbps cabling

Maciej Żenczykowski <[email protected]>
usb: fix various gadgets null ptr deref on 10gbps cabling.

Linyu Yuan <[email protected]>
usb: gadget: eem: fix wrong eem header operation

Stefan Agner <[email protected]>
USB: serial: cp210x: fix alternate function for CP2102N QFN20

Johan Hovold <[email protected]>
USB: serial: quatech2: fix control-request directions

Alexandre GRIVEAUX <[email protected]>
USB: serial: omninet: add device id for Zyxel Omni 56K Plus

George McCollister <[email protected]>
USB: serial: ftdi_sio: add NovaTech OrionMX product ID

Wesley Cheng <[email protected]>
usb: gadget: f_fs: Ensure io_completion_wq is idle during unbind

Andy Shevchenko <[email protected]>
usb: typec: intel_pmc_mux: Add missed error check for devm_ioremap_resource()

Andy Shevchenko <[email protected]>
usb: typec: intel_pmc_mux: Put fwnode in error case during ->probe()

Mayank Rana <[email protected]>
usb: typec: ucsi: Clear PPM capability data in ucsi_init() error path

Andy Shevchenko <[email protected]>
usb: typec: wcove: Use LE to CPU conversion when accessing msg->header

Thomas Petazzoni <[email protected]>
usb: musb: fix MUSB_QUIRK_B_DISCONNECT_99 handling

Marian-Cristian Rotariu <[email protected]>
usb: dwc3: ep0: fix NULL pointer exception

Jack Pham <[email protected]>
usb: dwc3: debugfs: Add and remove endpoint dirs dynamically

Jack Pham <[email protected]>
usb: dwc3: gadget: Bail from dwc3_gadget_exit() if dwc->gadget is NULL

Christophe JAILLET <[email protected]>
usb: dwc3: meson-g12a: Disable the regulator in the error handling path of the probe

Neil Armstrong <[email protected]>
usb: dwc3-meson-g12a: fix usb2 PHY glue init when phy0 is disabled

Kyle Tso <[email protected]>
usb: pd: Set PD_T_SINK_WAIT_CAP to 310ms

Maciej Żenczykowski <[email protected]>
usb: f_ncm: only first packet of aggregate needs to start timer

Maciej Żenczykowski <[email protected]>
USB: f_ncm: ncm_bitrate (speed) is unsigned

Geert Uytterhoeven <[email protected]>
mmc: renesas_sdhi: Fix HS400 on R-Car M3-W+

Wolfram Sang <[email protected]>
mmc: renesas_sdhi: abort tuning when timeout detected

Steven Rostedt (VMware) <[email protected]>
ftrace: Do not blindly read the ip address in ftrace_bug()

Alexander Kuznetsov <[email protected]>
cgroup1: don't allow '\n' in renaming

Nikolay Borisov <[email protected]>
btrfs: promote debugging asserts to full-fledged checks in validate_super

Ritesh Harjani <[email protected]>
btrfs: return value from btrfs_mark_extent_written() in case of error

Xiao Ni <[email protected]>
async_xor: check src_offs is not NULL before updating it

Wenli Looi <[email protected]>
staging: rtl8723bs: Fix uninitialized variables

Paolo Bonzini <[email protected]>
kvm: avoid speculation-based attacks from out-of-range memslot accesses

Lai Jiangshan <[email protected]>
KVM: X86: MMU: Use the correct inherited permissions to get shadow page

Kan Liang <[email protected]>
perf/x86/intel/uncore: Fix M2M event umask for Ice Lake server

Desmond Cheong Zhi Xi <[email protected]>
drm: Lock pointer access in drm_master_release()

Desmond Cheong Zhi Xi <[email protected]>
drm: Fix use-after-free read in drm_getunique()

Zhang Rui <[email protected]>
Revert "ACPI: sleep: Put the FACS table after using it"

Lukas Wunner <[email protected]>
spi: bcm2835: Fix out-of-bounds access with more than 4 slaves

Jeremy Szu <[email protected]>
ALSA: hda/realtek: fix mute/micmute LEDs for HP ZBook Power G8

Jeremy Szu <[email protected]>
ALSA: hda/realtek: fix mute/micmute LEDs for HP EliteBook 840 Aero G8

Jeremy Szu <[email protected]>
ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP EliteBook x360 1040 G8

Jeremy Szu <[email protected]>
ALSA: hda/realtek: fix mute/micmute LEDs and speaker for HP Elite Dragonfly G2

Hui Wang <[email protected]>
ALSA: hda/realtek: headphone and mic don't work on an Acer laptop

Takashi Sakamoto <[email protected]>
ALSA: firewire-lib: fix the context to call snd_pcm_stop_xrun()

Takashi Iwai <[email protected]>
ALSA: seq: Fix race of snd_seq_timer_open()

Chris Packham <[email protected]>
i2c: mpc: implement erratum A-004447 workaround

Chris Packham <[email protected]>
i2c: mpc: Make use of i2c_recover_bus()

Lukas Wunner <[email protected]>
spi: Cleanup on failure of initial setup

Saravana Kannan <[email protected]>
spi: Don't have controller clean up spi device before driver unbind

Chris Packham <[email protected]>
powerpc/fsl: set fsl,i2c-erratum-a004447 flag for P1010 i2c controllers

Chris Packham <[email protected]>
powerpc/fsl: set fsl,i2c-erratum-a004447 flag for P2041 i2c controllers

Sagi Grimberg <[email protected]>
nvmet: fix false keep-alive timeout when a controller is torn down

Sagi Grimberg <[email protected]>
nvme-tcp: remove incorrect Kconfig dep in BLK_DEV_NVME

Jiapeng Chong <[email protected]>
bnx2x: Fix missing error code in bnx2x_iov_init_one()

John Keeping <[email protected]>
dm verity: fix require_signatures module_param permissions

Tiezhu Yang <[email protected]>
MIPS: Fix kernel hang under FUNCTION_GRAPH_TRACER and PREEMPT_TRACER

Hannes Reinecke <[email protected]>
nvme-fabrics: decode host pathing error for connect

George McCollister <[email protected]>
net: dsa: microchip: enable phy errata workaround on 9567

Saubhik Mukherjee <[email protected]>
net: appletalk: cops: Fix data race in cops_probe1

Zong Li <[email protected]>
net: macb: ensure the device is available before accessing GEMGXL control registers

Dmitry Bogdanov <[email protected]>
scsi: target: qla2xxx: Wait for stop_phase1 at WWN removal

Yang Yingliang <[email protected]>
scsi: hisi_sas: Drop free_irq() of devm_request_irq() allocated irq

Matt Wang <[email protected]>
scsi: vmw_pvscsi: Set correct residual data length

Javed Hasan <[email protected]>
scsi: bnx2fc: Return failure if io_req is already in ABTS processing

Íñigo Huguet <[email protected]>
net:sfc: fix non-freed irq in legacy irq mode

Rao Shoaib <[email protected]>
RDS tcp loopback connection can hang

Zheyu Ma <[email protected]>
net/qla3xxx: fix schedule while atomic in ql_sem_spinlock

Sergey Senozhatsky <[email protected]>
wq: handle VM suspension in stall detection

Shakeel Butt <[email protected]>
cgroup: disable controllers at parse time

Dan Carpenter <[email protected]>
net: mdiobus: get rid of a BUG_ON()

Johannes Berg <[email protected]>
netlink: disable IRQs for netlink_lock_table()

Johannes Berg <[email protected]>
bonding: init notify_work earlier to avoid uninitialized use

Zheyu Ma <[email protected]>
isdn: mISDN: netjet: Fix crash in nj_probe:

Li Jun <[email protected]>
usb: chipidea: udc: assign interrupt number to USB gadget structure

Chunyan Zhang <[email protected]>
spi: sprd: Add missing MODULE_DEVICE_TABLE

Zou Wei <[email protected]>
ASoC: sti-sas: add missing MODULE_DEVICE_TABLE

Eric Farman <[email protected]>
vfio-ccw: Serialize FSM IDLE state with I/O completion

Eric Farman <[email protected]>
vfio-ccw: Reset FSM state to IDLE inside FSM

Hans de Goede <[email protected]>
ASoC: Intel: bytcr_rt5640: Add quirk for the Lenovo Miix 3-830 tablet

Hans de Goede <[email protected]>
ASoC: Intel: bytcr_rt5640: Add quirk for the Glavey TM800A550L tablet

Dinghao Liu <[email protected]>
usb: cdns3: Fix runtime PM imbalance on error

Jeimon <[email protected]>
net/nfc/rawsock.c: fix a permission check bug

Jiri Olsa <[email protected]>
bpf: Forbid trampoline attach for functions with variable arguments

Karen Dombroski <[email protected]>
spi: spi-zynq-qspi: Fix stack violation bug

Saravana Kannan <[email protected]>
spi: Fix spi device unregister flow

Vijendar Mukunda <[email protected]>
ASoC: amd: fix for pcm_read() error

Marco Felsch <[email protected]>
ASoC: max98088: fix ni clock divider calculation

Kees Cook <[email protected]>
proc: Track /proc/$pid/attr/ opener mm_struct


-------------

Diffstat:

.../bindings/sound/amlogic,gx-sound-card.yaml | 4 +-
Documentation/virt/kvm/mmu.rst | 4 +-
Makefile | 4 +-
arch/arm/include/asm/cpuidle.h | 5 +-
arch/mips/lib/mips-atomic.c | 12 +-
arch/powerpc/boot/dts/fsl/p1010si-post.dtsi | 8 ++
arch/powerpc/boot/dts/fsl/p2041si-post.dtsi | 16 +++
arch/x86/events/intel/uncore_snbep.c | 3 +-
arch/x86/kernel/cpu/perfctr-watchdog.c | 4 +-
arch/x86/kvm/mmu/paging_tmpl.h | 14 +-
arch/x86/kvm/trace.h | 6 +-
crypto/async_tx/async_xor.c | 3 +-
drivers/acpi/sleep.c | 4 +-
drivers/gpio/gpio-wcd934x.c | 2 +-
drivers/gpu/drm/drm_auth.c | 3 +-
drivers/gpu/drm/drm_ioctl.c | 9 +-
drivers/gpu/drm/mcde/mcde_dsi.c | 2 +-
drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 155 +++++++++++++++------
drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 2 +-
drivers/i2c/busses/i2c-mpc.c | 95 ++++++++++++-
drivers/infiniband/hw/mlx4/main.c | 5 +-
drivers/infiniband/hw/mlx5/cq.c | 9 +-
drivers/infiniband/ulp/ipoib/ipoib_netlink.c | 1 +
drivers/isdn/hardware/mISDN/netjet.c | 1 -
drivers/md/dm-verity-verify-sig.c | 2 +-
drivers/mmc/host/renesas_sdhi_core.c | 9 +-
drivers/net/appletalk/cops.c | 4 +-
drivers/net/bonding/bond_main.c | 2 +-
drivers/net/dsa/microchip/ksz9477.c | 1 +
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 4 +-
drivers/net/ethernet/cadence/macb_main.c | 3 +
drivers/net/ethernet/mellanox/mlx4/fw.c | 3 +
drivers/net/ethernet/mellanox/mlx4/fw.h | 1 +
drivers/net/ethernet/mellanox/mlx4/main.c | 6 +
drivers/net/ethernet/qlogic/qla3xxx.c | 2 +-
drivers/net/ethernet/sfc/nic.c | 1 +
drivers/net/phy/mdio_bus.c | 3 +-
drivers/nvme/host/Kconfig | 3 +-
drivers/nvme/host/fabrics.c | 5 +
drivers/nvme/target/core.c | 15 +-
drivers/nvme/target/nvmet.h | 2 +-
drivers/phy/broadcom/phy-brcm-usb-init.h | 4 +-
drivers/phy/cadence/phy-cadence-sierra.c | 1 +
drivers/phy/ti/phy-j721e-wiz.c | 1 +
drivers/regulator/bd718x7-regulator.c | 2 +-
drivers/regulator/core.c | 6 +
drivers/regulator/fan53880.c | 3 +
drivers/regulator/max77620-regulator.c | 7 +
drivers/regulator/rtmv20-regulator.c | 42 +++++-
drivers/s390/cio/vfio_ccw_drv.c | 12 +-
drivers/s390/cio/vfio_ccw_fsm.c | 1 +
drivers/s390/cio/vfio_ccw_ops.c | 2 -
drivers/scsi/bnx2fc/bnx2fc_io.c | 1 +
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 8 +-
drivers/scsi/hosts.c | 47 ++++---
drivers/scsi/qla2xxx/qla_target.c | 2 +
drivers/scsi/vmw_pvscsi.c | 8 +-
drivers/spi/spi-bcm2835.c | 10 +-
drivers/spi/spi-bitbang.c | 18 ++-
drivers/spi/spi-fsl-spi.c | 4 +
drivers/spi/spi-omap-uwire.c | 9 +-
drivers/spi/spi-omap2-mcspi.c | 33 +++--
drivers/spi/spi-pxa2xx.c | 9 +-
drivers/spi/spi-sprd.c | 1 +
drivers/spi/spi-zynq-qspi.c | 7 +-
drivers/spi/spi.c | 20 ++-
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +-
drivers/usb/cdns3/gadget.c | 4 +-
drivers/usb/chipidea/udc.c | 1 +
drivers/usb/dwc3/debug.h | 3 +
drivers/usb/dwc3/debugfs.c | 21 +--
drivers/usb/dwc3/dwc3-meson-g12a.c | 13 +-
drivers/usb/dwc3/ep0.c | 3 +
drivers/usb/dwc3/gadget.c | 18 ++-
drivers/usb/gadget/config.c | 8 ++
drivers/usb/gadget/function/f_ecm.c | 2 +-
drivers/usb/gadget/function/f_eem.c | 6 +-
drivers/usb/gadget/function/f_fs.c | 3 +
drivers/usb/gadget/function/f_hid.c | 3 +-
drivers/usb/gadget/function/f_loopback.c | 2 +-
drivers/usb/gadget/function/f_ncm.c | 10 +-
drivers/usb/gadget/function/f_printer.c | 3 +-
drivers/usb/gadget/function/f_rndis.c | 2 +-
drivers/usb/gadget/function/f_serial.c | 2 +-
drivers/usb/gadget/function/f_sourcesink.c | 3 +-
drivers/usb/gadget/function/f_subset.c | 2 +-
drivers/usb/gadget/function/f_tcm.c | 3 +-
drivers/usb/musb/musb_core.c | 3 +-
drivers/usb/serial/cp210x.c | 20 ++-
drivers/usb/serial/ftdi_sio.c | 1 +
drivers/usb/serial/ftdi_sio_ids.h | 1 +
drivers/usb/serial/omninet.c | 2 +
drivers/usb/serial/quatech2.c | 6 +-
drivers/usb/typec/mux.c | 2 +-
drivers/usb/typec/mux/intel_pmc_mux.c | 9 +-
drivers/usb/typec/tcpm/tcpm.c | 4 +
drivers/usb/typec/tcpm/wcove.c | 2 +-
drivers/usb/typec/ucsi/ucsi.c | 1 +
fs/btrfs/disk-io.c | 26 ++--
fs/btrfs/file.c | 4 +-
fs/nfs/client.c | 2 +-
fs/nfs/nfs4_fs.h | 1 +
fs/nfs/nfs4client.c | 2 +-
fs/nfs/nfs4proc.c | 29 +++-
fs/proc/base.c | 9 +-
include/asm-generic/vmlinux.lds.h | 1 +
include/linux/kvm_host.h | 10 +-
include/linux/mfd/rohm-bd71828.h | 10 +-
include/linux/mlx4/device.h | 1 +
include/linux/sched.h | 8 ++
include/linux/usb/pd.h | 2 +-
kernel/bpf/btf.c | 12 ++
kernel/cgroup/cgroup-v1.c | 4 +
kernel/cgroup/cgroup.c | 13 +-
kernel/events/core.c | 2 +
kernel/sched/debug.c | 3 +-
kernel/sched/fair.c | 18 +--
kernel/sched/pelt.h | 11 +-
kernel/trace/ftrace.c | 8 +-
kernel/trace/trace.c | 2 +-
kernel/workqueue.c | 12 +-
net/netlink/af_netlink.c | 6 +-
net/nfc/rawsock.c | 2 +-
net/rds/connection.c | 23 ++-
net/rds/tcp.c | 4 +-
net/rds/tcp.h | 3 +-
net/rds/tcp_listen.c | 6 +
sound/core/seq/seq_timer.c | 10 +-
sound/firewire/amdtp-stream.c | 2 +-
sound/pci/hda/patch_realtek.c | 16 +++
sound/soc/amd/raven/acp3x-pcm-dma.c | 10 --
sound/soc/amd/raven/acp3x.h | 1 +
sound/soc/amd/raven/pci-acp3x.c | 15 ++
sound/soc/codecs/max98088.c | 13 +-
sound/soc/codecs/sti-sas.c | 1 +
sound/soc/intel/boards/bytcr_rt5640.c | 25 ++++
sound/soc/soc-core.c | 2 +
tools/bootconfig/main.c | 1 +
tools/perf/util/session.c | 1 +
139 files changed, 882 insertions(+), 309 deletions(-)



2021-06-14 19:04:26

by Fox Chen

[permalink] [raw]
Subject: RE: [PATCH 5.10 000/130] 5.10.44-rc2 review

On Mon, 14 Jun 2021 18:15:07 +0200, Greg Kroah-Hartman <[email protected]> wrote:
> This is the start of the stable review cycle for the 5.10.44 release.
> There are 130 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 16 Jun 2021 16:13:59 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.44-rc2.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>

5.10.44-rc2 Successfully Compiled and booted on my Raspberry PI 4b (8g) (bcm2711)

Tested-by: Fox Chen <[email protected]>

2021-06-14 19:50:13

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/130] 5.10.44-rc2 review

Hi!

> This is the start of the stable review cycle for the 5.10.44 release.
> There are 130 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.

CIP testing did not find any problems here:

https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.10.y

Tested-by: Pavel Machek (CIP) <[email protected]>

Best regards,
Pavel


--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


Attachments:
(No filename) (665.00 B)
signature.asc (201.00 B)
Download all attachments

2021-06-14 20:24:10

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/130] 5.10.44-rc2 review



On 6/14/2021 9:15 AM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.44 release.
> There are 130 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 16 Jun 2021 16:13:59 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.44-rc2.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

On ARCH_BRCMSTB using 32-bit and 64-bit kernels:

Tested-by: Florian Fainelli <[email protected]>On ARCH_BRCMSTB using
32-bit and 64-bit kernels:

Tested-by: Florian Fainelli <[email protected]>
--
Florian

2021-06-14 21:36:53

by Shuah Khan

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/130] 5.10.44-rc2 review

On 6/14/21 10:15 AM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.44 release.
> There are 130 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 16 Jun 2021 16:13:59 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.44-rc2.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>

Compiled and booted on my test system. No dmesg regressions.

Tested-by: Shuah Khan <[email protected]>

thanks,
-- Shuah

2021-06-15 04:13:02

by Naresh Kamboju

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/130] 5.10.44-rc2 review

Hi Greg,

On Mon, 14 Jun 2021 at 21:45, Greg Kroah-Hartman
<[email protected]> wrote:
>
> This is the start of the stable review cycle for the 5.10.44 release.
> There are 130 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 16 Jun 2021 16:13:59 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.44-rc2.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

The following kernel crash reported on stable rc 5.10.44-rc2 arm64 db845c board.

[ 5.127966] dwc3-qcom a6f8800.usb: failed to get usb-ddr path: -517
[ 5.145567] Unable to handle kernel NULL pointer dereference at
virtual address 0000000000000002
[ 5.154451] Mem abort info:
[ 5.157296] ESR = 0x96000004
[ 5.160401] EC = 0x25: DABT (current EL), IL = 32 bits
[ 5.165771] SET = 0, FnV = 0
[ 5.168873] EA = 0, S1PTW = 0
[ 5.172064] Data abort info:
[ 5.174980] ISV = 0, ISS = 0x00000004
[ 5.178860] CM = 0, WnR = 0
[ 5.181872] [0000000000000002] user address but active_mm is swapper
[ 5.188293] Internal error: Oops: 96000004 [#1] PREEMPT SMP
[ 5.193922] Modules linked in:
[ 5.197022] CPU: 4 PID: 57 Comm: kworker/4:3 Not tainted 5.10.44-rc2 #1
[ 5.203697] Hardware name: Thundercomm Dragonboard 845c (DT)
[ 5.204022] ufshcd-qcom 1d84000.ufshc: ufshcd_print_pwr_info:[RX,
TX]: gear=[3, 3], lane[2, 2], pwr[FAST MODE, FAST MODE], rate = 2
[ 5.209434] Workqueue: events deferred_probe_work_func
[ 5.221786] ufshcd-qcom 1d84000.ufshc:
ufshcd_find_max_sup_active_icc_level: Regulator capability was not
set, actvIccLevel=0
[ 5.226541] pstate: 60c00005 (nZCv daif +PAN +UAO -TCO BTYPE=--)
[ 5.226551] pc : inode_permission+0x2c/0x178
[ 5.226559] lr : lookup_one_len_common+0xac/0x100

ref:
https://lkft.validation.linaro.org/scheduler/job/2899138#L2873

Reported-by: Linux Kernel Functional Testing <[email protected]>

There is a crash like this reported and discussed on the mailing thread.
https://lore.kernel.org/linux-usb/[email protected]/

metadata:
git branch: linux-5.10.y
git repo: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc
git commit: 3f05ff8b337097d73b2c408d60befe39dac31bb8
git describe: v5.10.43-131-g3f05ff8b3370
make_kernelversion: 5.10.44-rc2
kernel-config: https://builds.tuxbuild.com/1twkN9cmRWOK3boqZes7Yi1t0OO/config

--
Linaro LKFT
https://lkft.linaro.org

2021-06-15 06:10:23

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/130] 5.10.44-rc2 review

On Tue, Jun 15, 2021 at 09:41:26AM +0530, Naresh Kamboju wrote:
> Hi Greg,
>
> On Mon, 14 Jun 2021 at 21:45, Greg Kroah-Hartman
> <[email protected]> wrote:
> >
> > This is the start of the stable review cycle for the 5.10.44 release.
> > There are 130 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Wed, 16 Jun 2021 16:13:59 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.44-rc2.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
>
> The following kernel crash reported on stable rc 5.10.44-rc2 arm64 db845c board.
>
> [ 5.127966] dwc3-qcom a6f8800.usb: failed to get usb-ddr path: -517
> [ 5.145567] Unable to handle kernel NULL pointer dereference at
> virtual address 0000000000000002
> [ 5.154451] Mem abort info:
> [ 5.157296] ESR = 0x96000004
> [ 5.160401] EC = 0x25: DABT (current EL), IL = 32 bits
> [ 5.165771] SET = 0, FnV = 0
> [ 5.168873] EA = 0, S1PTW = 0
> [ 5.172064] Data abort info:
> [ 5.174980] ISV = 0, ISS = 0x00000004
> [ 5.178860] CM = 0, WnR = 0
> [ 5.181872] [0000000000000002] user address but active_mm is swapper
> [ 5.188293] Internal error: Oops: 96000004 [#1] PREEMPT SMP
> [ 5.193922] Modules linked in:
> [ 5.197022] CPU: 4 PID: 57 Comm: kworker/4:3 Not tainted 5.10.44-rc2 #1
> [ 5.203697] Hardware name: Thundercomm Dragonboard 845c (DT)
> [ 5.204022] ufshcd-qcom 1d84000.ufshc: ufshcd_print_pwr_info:[RX,
> TX]: gear=[3, 3], lane[2, 2], pwr[FAST MODE, FAST MODE], rate = 2
> [ 5.209434] Workqueue: events deferred_probe_work_func
> [ 5.221786] ufshcd-qcom 1d84000.ufshc:
> ufshcd_find_max_sup_active_icc_level: Regulator capability was not
> set, actvIccLevel=0
> [ 5.226541] pstate: 60c00005 (nZCv daif +PAN +UAO -TCO BTYPE=--)
> [ 5.226551] pc : inode_permission+0x2c/0x178
> [ 5.226559] lr : lookup_one_len_common+0xac/0x100
>
> ref:
> https://lkft.validation.linaro.org/scheduler/job/2899138#L2873
>
> Reported-by: Linux Kernel Functional Testing <[email protected]>
>
> There is a crash like this reported and discussed on the mailing thread.
> https://lore.kernel.org/linux-usb/[email protected]/

Is this crash just on shutdown? That's what that commit was fixing, but
it is resolving an error that should not be in the 5.10.y tree.

thanks,

greg k-h

2021-06-15 07:10:53

by Jack Pham

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/130] 5.10.44-rc2 review

Hi Greg,

On Tue, Jun 15, 2021 at 08:05:50AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Jun 15, 2021 at 09:41:26AM +0530, Naresh Kamboju wrote:
> > On Mon, 14 Jun 2021 at 21:45, Greg Kroah-Hartman
> > <[email protected]> wrote:
> > >
> > > This is the start of the stable review cycle for the 5.10.44 release.
> > > There are 130 patches in this series, all will be posted as a response
> > > to this one. If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Wed, 16 Jun 2021 16:13:59 +0000.
> > > Anything received after that time might be too late.
> > >
> > > The whole patch series can be found in one patch at:
> > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.44-rc2.gz
> > > or in the git tree and branch at:
> > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > > and the diffstat can be found below.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > The following kernel crash reported on stable rc 5.10.44-rc2 arm64 db845c board.
> >
> > [ 5.127966] dwc3-qcom a6f8800.usb: failed to get usb-ddr path: -517

Looks like -EPROBE_DEFER happened here due to a not-yet-probed
dependency (interconnect driver). This leads to dwc3_qcom_probe()
unwinding and calling of_platform_depopulate() which triggers the
"child" dwc3's driver remove callback dwc3_remove()...

> > [ 5.145567] Unable to handle kernel NULL pointer dereference at
> > virtual address 0000000000000002
> > [ 5.154451] Mem abort info:
> > [ 5.157296] ESR = 0x96000004
> > [ 5.160401] EC = 0x25: DABT (current EL), IL = 32 bits
> > [ 5.165771] SET = 0, FnV = 0
> > [ 5.168873] EA = 0, S1PTW = 0
> > [ 5.172064] Data abort info:
> > [ 5.174980] ISV = 0, ISS = 0x00000004
> > [ 5.178860] CM = 0, WnR = 0
> > [ 5.181872] [0000000000000002] user address but active_mm is swapper
> > [ 5.188293] Internal error: Oops: 96000004 [#1] PREEMPT SMP
> > [ 5.193922] Modules linked in:
> > [ 5.197022] CPU: 4 PID: 57 Comm: kworker/4:3 Not tainted 5.10.44-rc2 #1
> > [ 5.203697] Hardware name: Thundercomm Dragonboard 845c (DT)
> > [ 5.204022] ufshcd-qcom 1d84000.ufshc: ufshcd_print_pwr_info:[RX,
> > TX]: gear=[3, 3], lane[2, 2], pwr[FAST MODE, FAST MODE], rate = 2
> > [ 5.209434] Workqueue: events deferred_probe_work_func
> > [ 5.221786] ufshcd-qcom 1d84000.ufshc:
> > ufshcd_find_max_sup_active_icc_level: Regulator capability was not
> > set, actvIccLevel=0
> > [ 5.226541] pstate: 60c00005 (nZCv daif +PAN +UAO -TCO BTYPE=--)
> > [ 5.226551] pc : inode_permission+0x2c/0x178
> > [ 5.226559] lr : lookup_one_len_common+0xac/0x100
> >
> > ref:
> > https://lkft.validation.linaro.org/scheduler/job/2899138#L2873
> >
> > Reported-by: Linux Kernel Functional Testing <[email protected]>
> >
> > There is a crash like this reported and discussed on the mailing thread.
> > https://lore.kernel.org/linux-usb/[email protected]/
>
> Is this crash just on shutdown? That's what that commit was fixing, but
> it is resolving an error that should not be in the 5.10.y tree.

Peter reported and fixed it based on reproducing the crash from shutting
down but in my manual testing I found that it could be triggered any
time dwc3_remove() is called, though I surmised it would be a rare
occurence. In this particular case however Naresh is reporting it is
triggered even during bootup since dwc3-qcom would add its
dwc3 child, but because it encounters a probe deferral it has to
subsequently trigger the dwc3 driver remove callback right after it was
just probed.

So I think it would be good if Peter's follow-up change
(2a042767814b in your usb-next branch) can please go into stable as well
as it should help not only for the shutdown/reboot case. Otherwise,
my change "usb: dwc3: debugfs: Add and remove endpoint dirs
dynamically" could be simply be dropped until they can go in together.

Thanks,
Jack
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

2021-06-15 07:13:40

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/130] 5.10.44-rc2 review

On Tue, Jun 15, 2021 at 12:07:47AM -0700, Jack Pham wrote:
> Hi Greg,
>
> On Tue, Jun 15, 2021 at 08:05:50AM +0200, Greg Kroah-Hartman wrote:
> > On Tue, Jun 15, 2021 at 09:41:26AM +0530, Naresh Kamboju wrote:
> > > On Mon, 14 Jun 2021 at 21:45, Greg Kroah-Hartman
> > > <[email protected]> wrote:
> > > >
> > > > This is the start of the stable review cycle for the 5.10.44 release.
> > > > There are 130 patches in this series, all will be posted as a response
> > > > to this one. If anyone has any issues with these being applied, please
> > > > let me know.
> > > >
> > > > Responses should be made by Wed, 16 Jun 2021 16:13:59 +0000.
> > > > Anything received after that time might be too late.
> > > >
> > > > The whole patch series can be found in one patch at:
> > > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.44-rc2.gz
> > > > or in the git tree and branch at:
> > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > > > and the diffstat can be found below.
> > > >
> > > > thanks,
> > > >
> > > > greg k-h
> > >
> > > The following kernel crash reported on stable rc 5.10.44-rc2 arm64 db845c board.
> > >
> > > [ 5.127966] dwc3-qcom a6f8800.usb: failed to get usb-ddr path: -517
>
> Looks like -EPROBE_DEFER happened here due to a not-yet-probed
> dependency (interconnect driver). This leads to dwc3_qcom_probe()
> unwinding and calling of_platform_depopulate() which triggers the
> "child" dwc3's driver remove callback dwc3_remove()...
>
> > > [ 5.145567] Unable to handle kernel NULL pointer dereference at
> > > virtual address 0000000000000002
> > > [ 5.154451] Mem abort info:
> > > [ 5.157296] ESR = 0x96000004
> > > [ 5.160401] EC = 0x25: DABT (current EL), IL = 32 bits
> > > [ 5.165771] SET = 0, FnV = 0
> > > [ 5.168873] EA = 0, S1PTW = 0
> > > [ 5.172064] Data abort info:
> > > [ 5.174980] ISV = 0, ISS = 0x00000004
> > > [ 5.178860] CM = 0, WnR = 0
> > > [ 5.181872] [0000000000000002] user address but active_mm is swapper
> > > [ 5.188293] Internal error: Oops: 96000004 [#1] PREEMPT SMP
> > > [ 5.193922] Modules linked in:
> > > [ 5.197022] CPU: 4 PID: 57 Comm: kworker/4:3 Not tainted 5.10.44-rc2 #1
> > > [ 5.203697] Hardware name: Thundercomm Dragonboard 845c (DT)
> > > [ 5.204022] ufshcd-qcom 1d84000.ufshc: ufshcd_print_pwr_info:[RX,
> > > TX]: gear=[3, 3], lane[2, 2], pwr[FAST MODE, FAST MODE], rate = 2
> > > [ 5.209434] Workqueue: events deferred_probe_work_func
> > > [ 5.221786] ufshcd-qcom 1d84000.ufshc:
> > > ufshcd_find_max_sup_active_icc_level: Regulator capability was not
> > > set, actvIccLevel=0
> > > [ 5.226541] pstate: 60c00005 (nZCv daif +PAN +UAO -TCO BTYPE=--)
> > > [ 5.226551] pc : inode_permission+0x2c/0x178
> > > [ 5.226559] lr : lookup_one_len_common+0xac/0x100
> > >
> > > ref:
> > > https://lkft.validation.linaro.org/scheduler/job/2899138#L2873
> > >
> > > Reported-by: Linux Kernel Functional Testing <[email protected]>
> > >
> > > There is a crash like this reported and discussed on the mailing thread.
> > > https://lore.kernel.org/linux-usb/[email protected]/
> >
> > Is this crash just on shutdown? That's what that commit was fixing, but
> > it is resolving an error that should not be in the 5.10.y tree.
>
> Peter reported and fixed it based on reproducing the crash from shutting
> down but in my manual testing I found that it could be triggered any
> time dwc3_remove() is called, though I surmised it would be a rare
> occurence. In this particular case however Naresh is reporting it is
> triggered even during bootup since dwc3-qcom would add its
> dwc3 child, but because it encounters a probe deferral it has to
> subsequently trigger the dwc3 driver remove callback right after it was
> just probed.
>
> So I think it would be good if Peter's follow-up change
> (2a042767814b in your usb-next branch) can please go into stable as well
> as it should help not only for the shutdown/reboot case. Otherwise,
> my change "usb: dwc3: debugfs: Add and remove endpoint dirs
> dynamically" could be simply be dropped until they can go in together.

That will all have to wait until 5.14-rc1 as these patches are not
queued up to hit Linus's tree until then. I was not aware that this
problem was showing up anywhere except in linux-next.

If we need a fix in 5.13-final before then, please let me know and
submit it so that I can take it in my tree and get it to Linus quickly.

thanks,

greg k-h

2021-06-15 08:17:09

by Jack Pham

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/130] 5.10.44-rc2 review

On Tue, Jun 15, 2021 at 09:11:48AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Jun 15, 2021 at 12:07:47AM -0700, Jack Pham wrote:
> > Hi Greg,
> >
> > On Tue, Jun 15, 2021 at 08:05:50AM +0200, Greg Kroah-Hartman wrote:
> > > On Tue, Jun 15, 2021 at 09:41:26AM +0530, Naresh Kamboju wrote:
> > > > On Mon, 14 Jun 2021 at 21:45, Greg Kroah-Hartman
> > > > <[email protected]> wrote:
> > > > >
> > > > > This is the start of the stable review cycle for the 5.10.44 release.
> > > > > There are 130 patches in this series, all will be posted as a response
> > > > > to this one. If anyone has any issues with these being applied, please
> > > > > let me know.
> > > > >
> > > > > Responses should be made by Wed, 16 Jun 2021 16:13:59 +0000.
> > > > > Anything received after that time might be too late.
> > > > >
> > > > > The whole patch series can be found in one patch at:
> > > > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.44-rc2.gz
> > > > > or in the git tree and branch at:
> > > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > > > > and the diffstat can be found below.
> > > > >
> > > > > thanks,
> > > > >
> > > > > greg k-h
> > > >
> > > > The following kernel crash reported on stable rc 5.10.44-rc2 arm64 db845c board.
> > > >
> > > > [ 5.127966] dwc3-qcom a6f8800.usb: failed to get usb-ddr path: -517
> >
> > Looks like -EPROBE_DEFER happened here due to a not-yet-probed
> > dependency (interconnect driver). This leads to dwc3_qcom_probe()
> > unwinding and calling of_platform_depopulate() which triggers the
> > "child" dwc3's driver remove callback dwc3_remove()...
> >
> > > > [ 5.145567] Unable to handle kernel NULL pointer dereference at
> > > > virtual address 0000000000000002
> > > > [ 5.154451] Mem abort info:
> > > > [ 5.157296] ESR = 0x96000004
> > > > [ 5.160401] EC = 0x25: DABT (current EL), IL = 32 bits
> > > > [ 5.165771] SET = 0, FnV = 0
> > > > [ 5.168873] EA = 0, S1PTW = 0
> > > > [ 5.172064] Data abort info:
> > > > [ 5.174980] ISV = 0, ISS = 0x00000004
> > > > [ 5.178860] CM = 0, WnR = 0
> > > > [ 5.181872] [0000000000000002] user address but active_mm is swapper
> > > > [ 5.188293] Internal error: Oops: 96000004 [#1] PREEMPT SMP
> > > > [ 5.193922] Modules linked in:
> > > > [ 5.197022] CPU: 4 PID: 57 Comm: kworker/4:3 Not tainted 5.10.44-rc2 #1
> > > > [ 5.203697] Hardware name: Thundercomm Dragonboard 845c (DT)
> > > > [ 5.204022] ufshcd-qcom 1d84000.ufshc: ufshcd_print_pwr_info:[RX,
> > > > TX]: gear=[3, 3], lane[2, 2], pwr[FAST MODE, FAST MODE], rate = 2
> > > > [ 5.209434] Workqueue: events deferred_probe_work_func
> > > > [ 5.221786] ufshcd-qcom 1d84000.ufshc:
> > > > ufshcd_find_max_sup_active_icc_level: Regulator capability was not
> > > > set, actvIccLevel=0
> > > > [ 5.226541] pstate: 60c00005 (nZCv daif +PAN +UAO -TCO BTYPE=--)
> > > > [ 5.226551] pc : inode_permission+0x2c/0x178
> > > > [ 5.226559] lr : lookup_one_len_common+0xac/0x100
> > > >
> > > > ref:
> > > > https://lkft.validation.linaro.org/scheduler/job/2899138#L2873
> > > >
> > > > Reported-by: Linux Kernel Functional Testing <[email protected]>
> > > >
> > > > There is a crash like this reported and discussed on the mailing thread.
> > > > https://lore.kernel.org/linux-usb/[email protected]/
> > >
> > > Is this crash just on shutdown? That's what that commit was fixing, but
> > > it is resolving an error that should not be in the 5.10.y tree.
> >
> > Peter reported and fixed it based on reproducing the crash from shutting
> > down but in my manual testing I found that it could be triggered any
> > time dwc3_remove() is called, though I surmised it would be a rare
> > occurence. In this particular case however Naresh is reporting it is
> > triggered even during bootup since dwc3-qcom would add its
> > dwc3 child, but because it encounters a probe deferral it has to
> > subsequently trigger the dwc3 driver remove callback right after it was
> > just probed.
> >
> > So I think it would be good if Peter's follow-up change
> > (2a042767814b in your usb-next branch) can please go into stable as well
> > as it should help not only for the shutdown/reboot case. Otherwise,
> > my change "usb: dwc3: debugfs: Add and remove endpoint dirs
> > dynamically" could be simply be dropped until they can go in together.
>
> That will all have to wait until 5.14-rc1 as these patches are not
> queued up to hit Linus's tree until then. I was not aware that this
> problem was showing up anywhere except in linux-next.
>
> If we need a fix in 5.13-final before then, please let me know and
> submit it so that I can take it in my tree and get it to Linus quickly.

Sure. I just responded to one of your auto-replies about Peter's patch
"usb: dwc3: core: fix kernel panic when do reboot" getting accepted for
usb-next and asked if you can take it for usb-linus for 5.13-final asap
as well. Or did you mean I should submit a new separate patch?

As for this failure in $subject on 5.10.44-rc2, I think the prudent
thing would be to drop my patch "usb: dwc3: debugfs: Add and remove
endpoint dirs dynamically" from the stable queue altogether and revisit
it later (when it can go in along with Peter's fix). I hope it's not
too late to NAK it (at least for now) on stable?

Sorry for the mess.
Jack

2021-06-15 08:54:17

by Zou Wei

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/130] 5.10.44-rc2 review



On 2021/6/15 0:15, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.44 release.
> There are 130 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 16 Jun 2021 16:13:59 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.44-rc2.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>

Tested on arm64 and x86 for 5.10.44-rc2,

Kernel repo:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
Branch: linux-5.10.y
Version: 5.10.44-rc2
Commit: 3f05ff8b337097d73b2c408d60befe39dac31bb8
Compiler: gcc version 7.3.0 (GCC)

arm64:
--------------------------------------------------------------------
Testcase Result Summary:
total: 8906
passed: 8906
failed: 0
timeout: 0
--------------------------------------------------------------------

x86:
--------------------------------------------------------------------
Testcase Result Summary:
total: 8906
passed: 8906
failed: 0
timeout: 0
--------------------------------------------------------------------

Tested-by: Hulk Robot <[email protected]>

2021-06-15 09:47:56

by Sudip Mukherjee

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/130] 5.10.44-rc2 review

Hi Greg,

On Mon, Jun 14, 2021 at 06:15:07PM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.44 release.
> There are 130 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 16 Jun 2021 16:13:59 +0000.
> Anything received after that time might be too late.

Build test:
mips (gcc version 11.1.1 20210523): 63 configs -> no failure
arm (gcc version 11.1.1 20210523): 105 configs -> no new failure
arm64 (gcc version 11.1.1 20210523): 2 configs -> no failure
x86_64 (gcc version 10.2.1 20210110): 2 configs -> no failure

Boot test:
x86_64: Booted on my test laptop. No regression.
x86_64: Booted on qemu. No regression.
arm64: Booted on rpi4b (4GB model). No regression.

Tested-by: Sudip Mukherjee <[email protected]>

--
Regards
Sudip

2021-06-15 10:23:30

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/130] 5.10.44-rc2 review

On Tue, Jun 15, 2021 at 01:16:18AM -0700, Jack Pham wrote:
> On Tue, Jun 15, 2021 at 09:11:48AM +0200, Greg Kroah-Hartman wrote:
> > On Tue, Jun 15, 2021 at 12:07:47AM -0700, Jack Pham wrote:
> > > Hi Greg,
> > >
> > > On Tue, Jun 15, 2021 at 08:05:50AM +0200, Greg Kroah-Hartman wrote:
> > > > On Tue, Jun 15, 2021 at 09:41:26AM +0530, Naresh Kamboju wrote:
> > > > > On Mon, 14 Jun 2021 at 21:45, Greg Kroah-Hartman
> > > > > <[email protected]> wrote:
> > > > > >
> > > > > > This is the start of the stable review cycle for the 5.10.44 release.
> > > > > > There are 130 patches in this series, all will be posted as a response
> > > > > > to this one. If anyone has any issues with these being applied, please
> > > > > > let me know.
> > > > > >
> > > > > > Responses should be made by Wed, 16 Jun 2021 16:13:59 +0000.
> > > > > > Anything received after that time might be too late.
> > > > > >
> > > > > > The whole patch series can be found in one patch at:
> > > > > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.44-rc2.gz
> > > > > > or in the git tree and branch at:
> > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > > > > > and the diffstat can be found below.
> > > > > >
> > > > > > thanks,
> > > > > >
> > > > > > greg k-h
> > > > >
> > > > > The following kernel crash reported on stable rc 5.10.44-rc2 arm64 db845c board.
> > > > >
> > > > > [ 5.127966] dwc3-qcom a6f8800.usb: failed to get usb-ddr path: -517
> > >
> > > Looks like -EPROBE_DEFER happened here due to a not-yet-probed
> > > dependency (interconnect driver). This leads to dwc3_qcom_probe()
> > > unwinding and calling of_platform_depopulate() which triggers the
> > > "child" dwc3's driver remove callback dwc3_remove()...
> > >
> > > > > [ 5.145567] Unable to handle kernel NULL pointer dereference at
> > > > > virtual address 0000000000000002
> > > > > [ 5.154451] Mem abort info:
> > > > > [ 5.157296] ESR = 0x96000004
> > > > > [ 5.160401] EC = 0x25: DABT (current EL), IL = 32 bits
> > > > > [ 5.165771] SET = 0, FnV = 0
> > > > > [ 5.168873] EA = 0, S1PTW = 0
> > > > > [ 5.172064] Data abort info:
> > > > > [ 5.174980] ISV = 0, ISS = 0x00000004
> > > > > [ 5.178860] CM = 0, WnR = 0
> > > > > [ 5.181872] [0000000000000002] user address but active_mm is swapper
> > > > > [ 5.188293] Internal error: Oops: 96000004 [#1] PREEMPT SMP
> > > > > [ 5.193922] Modules linked in:
> > > > > [ 5.197022] CPU: 4 PID: 57 Comm: kworker/4:3 Not tainted 5.10.44-rc2 #1
> > > > > [ 5.203697] Hardware name: Thundercomm Dragonboard 845c (DT)
> > > > > [ 5.204022] ufshcd-qcom 1d84000.ufshc: ufshcd_print_pwr_info:[RX,
> > > > > TX]: gear=[3, 3], lane[2, 2], pwr[FAST MODE, FAST MODE], rate = 2
> > > > > [ 5.209434] Workqueue: events deferred_probe_work_func
> > > > > [ 5.221786] ufshcd-qcom 1d84000.ufshc:
> > > > > ufshcd_find_max_sup_active_icc_level: Regulator capability was not
> > > > > set, actvIccLevel=0
> > > > > [ 5.226541] pstate: 60c00005 (nZCv daif +PAN +UAO -TCO BTYPE=--)
> > > > > [ 5.226551] pc : inode_permission+0x2c/0x178
> > > > > [ 5.226559] lr : lookup_one_len_common+0xac/0x100
> > > > >
> > > > > ref:
> > > > > https://lkft.validation.linaro.org/scheduler/job/2899138#L2873
> > > > >
> > > > > Reported-by: Linux Kernel Functional Testing <[email protected]>
> > > > >
> > > > > There is a crash like this reported and discussed on the mailing thread.
> > > > > https://lore.kernel.org/linux-usb/[email protected]/
> > > >
> > > > Is this crash just on shutdown? That's what that commit was fixing, but
> > > > it is resolving an error that should not be in the 5.10.y tree.
> > >
> > > Peter reported and fixed it based on reproducing the crash from shutting
> > > down but in my manual testing I found that it could be triggered any
> > > time dwc3_remove() is called, though I surmised it would be a rare
> > > occurence. In this particular case however Naresh is reporting it is
> > > triggered even during bootup since dwc3-qcom would add its
> > > dwc3 child, but because it encounters a probe deferral it has to
> > > subsequently trigger the dwc3 driver remove callback right after it was
> > > just probed.
> > >
> > > So I think it would be good if Peter's follow-up change
> > > (2a042767814b in your usb-next branch) can please go into stable as well
> > > as it should help not only for the shutdown/reboot case. Otherwise,
> > > my change "usb: dwc3: debugfs: Add and remove endpoint dirs
> > > dynamically" could be simply be dropped until they can go in together.
> >
> > That will all have to wait until 5.14-rc1 as these patches are not
> > queued up to hit Linus's tree until then. I was not aware that this
> > problem was showing up anywhere except in linux-next.
> >
> > If we need a fix in 5.13-final before then, please let me know and
> > submit it so that I can take it in my tree and get it to Linus quickly.
>
> Sure. I just responded to one of your auto-replies about Peter's patch
> "usb: dwc3: core: fix kernel panic when do reboot" getting accepted for
> usb-next and asked if you can take it for usb-linus for 5.13-final asap
> as well. Or did you mean I should submit a new separate patch?
>
> As for this failure in $subject on 5.10.44-rc2, I think the prudent
> thing would be to drop my patch "usb: dwc3: debugfs: Add and remove
> endpoint dirs dynamically" from the stable queue altogether and revisit
> it later (when it can go in along with Peter's fix). I hope it's not
> too late to NAK it (at least for now) on stable?
>
> Sorry for the mess.

Ick, yeah, that's a mess, we had this commit in two different branches,
and that's what happens when this gets out of sync...

Anyway, I've cherry-picked this commit now to my branch for 5.13-final,
fixed up the "Fixes:" line, and will get it to Linus soon.

I'll also go drop this "dwc3: debugfs:" patch from the stable queue as
it will cause problems for people, and not add it back until I can get
this fix into Linus's tree as well.

thanks,

greg k-h

2021-06-15 14:28:17

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/130] 5.10.44-rc2 review

On Mon, Jun 14, 2021 at 06:15:07PM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.44 release.
> There are 130 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Wed, 16 Jun 2021 16:13:59 +0000.
> Anything received after that time might be too late.
>

Build results:
total: 156 pass: 156 fail: 0
Qemu test results:
total: 455 pass: 455 fail: 0

Tested-by: Guenter Roeck <[email protected]>

Guenter