2024-04-09 19:58:17

by Christophe JAILLET

[permalink] [raw]
Subject: [PATCH] thermal: k3_bandgap: Remove some unused fields in struct k3_bandgap

In "struct k3_bandgap", the 'conf' field is unused.
Remove it.

Found with cppcheck, unusedStructMember.

Signed-off-by: Christophe JAILLET <[email protected]>
---
Compile tested only.

Apparently, it has never been used. It is not a left-over from a
refactoring.
---
drivers/thermal/k3_bandgap.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/thermal/k3_bandgap.c b/drivers/thermal/k3_bandgap.c
index e88192d2afea..2a703770fc91 100644
--- a/drivers/thermal/k3_bandgap.c
+++ b/drivers/thermal/k3_bandgap.c
@@ -78,7 +78,6 @@ static const int k3_adc_to_temp[] = {

struct k3_bandgap {
void __iomem *base;
- const struct k3_bandgap_data *conf;
};

/* common data structures */
--
2.44.0



2024-04-22 16:46:25

by Daniel Lezcano

[permalink] [raw]
Subject: Re: [PATCH] thermal: k3_bandgap: Remove some unused fields in struct k3_bandgap

On 09/04/2024 21:56, Christophe JAILLET wrote:
> In "struct k3_bandgap", the 'conf' field is unused.
> Remove it.
>
> Found with cppcheck, unusedStructMember.
>
> Signed-off-by: Christophe JAILLET <[email protected]>
> ---

Applied, thanks

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog