2015-04-29 19:05:25

by Fabian Frédérick

Subject: [PATCH 1/1 linux-next] iommu/msm: make msm_iommu_lock static

msm_iommu_lock is only used in msm_iommu.c

Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/iommu/msm_iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/msm_iommu.c b/drivers/iommu/msm_iommu.c
index 15a2063..f2a6321 100644
--- a/drivers/iommu/msm_iommu.c
+++ b/drivers/iommu/msm_iommu.c
@@ -47,7 +47,7 @@ __asm__ __volatile__ ( \

static int msm_iommu_tex_class[4];

-DEFINE_SPINLOCK(msm_iommu_lock);
+static DEFINE_SPINLOCK(msm_iommu_lock);

struct msm_priv {
unsigned long *pgtable;
--
1.9.1

2015-05-05 16:11:44

by Joerg Roedel

Subject: Re: [PATCH 1/1 linux-next] iommu/msm: make msm_iommu_lock static

On Wed, Apr 29, 2015 at 09:05:17PM +0200, Fabian Frederick wrote:
> msm_iommu_lock is only used in msm_iommu.c
>
> Signed-off-by: Fabian Frederick <[email protected]>
> ---
> drivers/iommu/msm_iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

This driver is marked BROKEN, I think its more important to get it out
of this stage instead of those random useless cleanups.


Joerg

2015-05-05 17:19:38

by Fabian Frédérick

Subject: Re: [PATCH 1/1 linux-next] iommu/msm: make msm_iommu_lock static

> On 05 May 2015 at 18:03 Joerg Roedel <[email protected]> wrote:
>
>
> On Wed, Apr 29, 2015 at 09:05:17PM +0200, Fabian Frederick wrote:
> > msm_iommu_lock is only used in msm_iommu.c
> >
> > Signed-off-by: Fabian Frederick <[email protected]>
> > ---
> >  drivers/iommu/msm_iommu.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> This driver is marked BROKEN, I think its more important to get it out
> of this stage instead of those random useless cleanups.
Hi Joerg,

    Didn't notice it was broken. Really sorry for the noise.

Regards,
Fabian
>
>
>       Joerg
>