2013-05-28 08:34:40

by Lars Poeschel

[permalink] [raw]
Subject: [PATCH] dts: am33xx: Correct properties on gpmc node

From: Lars Poeschel <[email protected]>

The gpmc driver is actually looking for "gpmc,num-cs" and
"gpmc,num-waitpins" properties in DT. The binding doc also states
this.
Correct the properties in the dts to provide the right values for the
gpmc driver.

Signed-off-by: Lars Poeschel <[email protected]>
---
arch/arm/boot/dts/am33xx.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 1460d9b..8e1248f 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -409,8 +409,8 @@
ti,hwmods = "gpmc";
reg = <0x50000000 0x2000>;
interrupts = <100>;
- num-cs = <7>;
- num-waitpins = <2>;
+ gpmc,num-cs = <7>;
+ gpmc,num-waitpins = <2>;
#address-cells = <2>;
#size-cells = <1>;
status = "disabled";
--
1.7.10.4


2013-05-28 09:50:47

by Peter Korsgaard

[permalink] [raw]
Subject: Re: [PATCH] dts: am33xx: Correct properties on gpmc node

>>>>> "Lars" == Lars Poeschel <[email protected]> writes:

Lars> From: Lars Poeschel <[email protected]>
Lars> The gpmc driver is actually looking for "gpmc,num-cs" and
Lars> "gpmc,num-waitpins" properties in DT. The binding doc also states
Lars> this.
Lars> Correct the properties in the dts to provide the right values for the
Lars> gpmc driver.

Lars> Signed-off-by: Lars Poeschel <[email protected]>

Acked-by: Peter Korsgaard <[email protected]>

--
Bye, Peter Korsgaard

2013-05-30 06:45:12

by Gupta, Pekon

[permalink] [raw]
Subject: RE: [PATCH] dts: am33xx: Correct properties on gpmc node

> >>>>> "Lars" == Lars Poeschel <[email protected]> writes:
>
> Lars> From: Lars Poeschel <[email protected]>
> Lars> The gpmc driver is actually looking for "gpmc,num-cs" and
> Lars> "gpmc,num-waitpins" properties in DT. The binding doc also states
> Lars> this.
> Lars> Correct the properties in the dts to provide the right values for the
> Lars> gpmc driver.
>
> Lars> Signed-off-by: Lars Poeschel <[email protected]>
>
> Acked-by: Peter Korsgaard <[email protected]>
>
Acked-by: Pekon Gupta <[email protected]>

My another patch [V3, 2/3] on same can be dropped, in lieu of this one..
http://www.spinics.net/lists/linux-omap/msg91167.html


with regards, pekon