2014-11-20 22:47:24

by SF Markus Elfring

Subject: [PATCH 1/1] SCSI-bfa: Deletion of an unnecessary check before the function call "vfree"

From: Markus Elfring <[email protected]>
Date: Thu, 20 Nov 2014 23:43:17 +0100

The vfree() function performs also input parameter validation. Thus the test
around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/scsi/bfa/bfad_debugfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/bfa/bfad_debugfs.c b/drivers/scsi/bfa/bfad_debugfs.c
index 8e83d04..a72170f 100644
--- a/drivers/scsi/bfa/bfad_debugfs.c
+++ b/drivers/scsi/bfa/bfad_debugfs.c
@@ -399,8 +399,7 @@ bfad_debugfs_release_fwtrc(struct inode *inode, struct file *file)
if (!fw_debug)
return 0;

- if (fw_debug->debug_buffer)
- vfree(fw_debug->debug_buffer);
+ vfree(fw_debug->debug_buffer);

file->private_data = NULL;
kfree(fw_debug);
--
2.1.3

2014-11-21 04:20:22

by Anil Gurumurthy

Subject: RE: [PATCH 1/1] SCSI-bfa: Deletion of an unnecessary check before the function call "vfree"

Patch looks good.
Thanks!
Acked-by: Anil Gurumurthy <[email protected]>

-----Original Message-----
From: SF Markus Elfring [mailto:[email protected]]
Sent: 21 November 2014 04:17
To: Anil Gurumurthy; James E. J. Bottomley; Sudarsana Kalluru; linux-scsi
Cc: linux-kernel; [email protected]; Julia Lawall
Subject: [PATCH 1/1] SCSI-bfa: Deletion of an unnecessary check before the function call "vfree"

From: Markus Elfring <[email protected]>
Date: Thu, 20 Nov 2014 23:43:17 +0100

The vfree() function performs also input parameter validation. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/scsi/bfa/bfad_debugfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/bfa/bfad_debugfs.c b/drivers/scsi/bfa/bfad_debugfs.c index 8e83d04..a72170f 100644
--- a/drivers/scsi/bfa/bfad_debugfs.c
+++ b/drivers/scsi/bfa/bfad_debugfs.c
@@ -399,8 +399,7 @@ bfad_debugfs_release_fwtrc(struct inode *inode, struct file *file)
if (!fw_debug)
return 0;

- if (fw_debug->debug_buffer)
- vfree(fw_debug->debug_buffer);
+ vfree(fw_debug->debug_buffer);

file->private_data = NULL;
kfree(fw_debug);
--
2.1.3

2015-06-30 12:39:11

by SF Markus Elfring

Subject: Re: [PATCH] SCSI-bfa: Deletion of an unnecessary check before the function call "vfree"

> Patch looks good.
> Thanks!
> Acked-by: Anil Gurumurthy <[email protected]>
>
> -----Original Message-----
> From: SF Markus Elfring [mailto:[email protected]]
> Sent: 21 November 2014 04:17
> To: Anil Gurumurthy; James E. J. Bottomley; Sudarsana Kalluru; linux-scsi
> Cc: linux-kernel; [email protected]; Julia Lawall
> Subject: [PATCH 1/1] SCSI-bfa: Deletion of an unnecessary check before the function call "vfree"
>
> From: Markus Elfring <[email protected]>
> Date: Thu, 20 Nov 2014 23:43:17 +0100
>
> The vfree() function performs also input parameter validation. Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>
> ---
> drivers/scsi/bfa/bfad_debugfs.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/bfa/bfad_debugfs.c b/drivers/scsi/bfa/bfad_debugfs.c index 8e83d04..a72170f 100644
> --- a/drivers/scsi/bfa/bfad_debugfs.c
> +++ b/drivers/scsi/bfa/bfad_debugfs.c
> @@ -399,8 +399,7 @@ bfad_debugfs_release_fwtrc(struct inode *inode, struct file *file)
> if (!fw_debug)
> return 0;
>
> - if (fw_debug->debug_buffer)
> - vfree(fw_debug->debug_buffer);
> + vfree(fw_debug->debug_buffer);
>
> file->private_data = NULL;
> kfree(fw_debug);
> --
> 2.1.3
>

Would you like to integrate this update suggestion
into another source code repository?

Regards,
Markus