2023-10-02 22:31:12

by Philipp Hortmann

[permalink] [raw]
Subject: [PATCH 0/8] staging: rtl8192e: Remove unused functions related to removed reset

Remove unused functions rtl92e_dm_backup_state(),
rtl92e_dm_restore_state() and rtl92e_cam_restore(). Remove unused
variables. Most parts are leftover from the previous patch series.

Tested with rtl8192e (WLL6130-D99) in Mode n (12.5 MB/s)
Transferred this patch over wlan connection of rtl8192e.

Philipp Hortmann (8):
staging: rtl8192e: Remove unused function rtl92e_dm_backup_state()
staging: rtl8192e: Remove unused function rtl92e_dm_restore_state()
staging: rtl8192e: Remove unused function rtl92e_cam_restore()
staging: rtl8192e: Remove unused variable last_ratr
staging: rtl8192e: Remove unused variable rate_adaptive_disabled
staging: rtl8192e: Remove unused variable rfc_txpowertrackingindex
staging: rtl8192e: Remove unused/constant parameter mesh_flag and
shutdown
staging: rtl8192e: Remove constant parameter from
rtllib_stop_protocol()

drivers/staging/rtl8192e/rtl8192e/rtl_cam.c | 63 ---------------
drivers/staging/rtl8192e/rtl8192e/rtl_cam.h | 1 -
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 5 +-
drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 1 -
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 83 --------------------
drivers/staging/rtl8192e/rtl8192e/rtl_dm.h | 2 -
drivers/staging/rtl8192e/rtllib.h | 7 +-
drivers/staging/rtl8192e/rtllib_softmac.c | 22 +++---
drivers/staging/rtl8192e/rtllib_softmac_wx.c | 6 +-
9 files changed, 16 insertions(+), 174 deletions(-)

--
2.42.0


2023-10-02 22:35:43

by Philipp Hortmann

[permalink] [raw]
Subject: [PATCH 6/8] staging: rtl8192e: Remove unused variable rfc_txpowertrackingindex

rfc_txpowertrackingindex is initialized to 0 and unchanged. Remove dead
code.

Signed-off-by: Philipp Hortmann <[email protected]>
---
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 1 -
drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 1 -
2 files changed, 2 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
index c4688c273f4b..1f3a2bee247f 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
@@ -752,7 +752,6 @@ static void _rtl92e_init_priv_variable(struct net_device *dev)
priv->bcck_in_ch14 = false;
priv->cck_present_attn = 0;
priv->rfa_txpowertrackingindex = 0;
- priv->rfc_txpowertrackingindex = 0;
priv->cck_pwr_enl = 6;
memset(priv->rtllib->swcamtable, 0, sizeof(struct sw_cam_table) * 32);
priv->rx_ctr = 0;
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
index deb707dfa443..922231274f4b 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
@@ -344,7 +344,6 @@ struct r8192_priv {
u8 rfa_txpowertrackingindex;
u8 rfa_txpowertrackingindex_real;
u8 rfa_txpowertracking_default;
- u8 rfc_txpowertrackingindex;
bool btxpower_tracking;
bool bcck_in_ch14;

--
2.42.0

2023-10-04 08:19:44

by Dan Carpenter

[permalink] [raw]
Subject: Re: [PATCH 0/8] staging: rtl8192e: Remove unused functions related to removed reset

On Mon, Oct 02, 2023 at 07:53:01PM +0200, Philipp Hortmann wrote:
> Remove unused functions rtl92e_dm_backup_state(),
> rtl92e_dm_restore_state() and rtl92e_cam_restore(). Remove unused
> variables. Most parts are leftover from the previous patch series.
>
> Tested with rtl8192e (WLL6130-D99) in Mode n (12.5 MB/s)
> Transferred this patch over wlan connection of rtl8192e.
>
> Philipp Hortmann (8):
> staging: rtl8192e: Remove unused function rtl92e_dm_backup_state()
> staging: rtl8192e: Remove unused function rtl92e_dm_restore_state()
> staging: rtl8192e: Remove unused function rtl92e_cam_restore()
> staging: rtl8192e: Remove unused variable last_ratr
> staging: rtl8192e: Remove unused variable rate_adaptive_disabled
> staging: rtl8192e: Remove unused variable rfc_txpowertrackingindex
> staging: rtl8192e: Remove unused/constant parameter mesh_flag and
> shutdown
> staging: rtl8192e: Remove constant parameter from
> rtllib_stop_protocol()
>

These all look good.

Reviewed-by: Dan Carpenter <[email protected]>

regards,
dan carpenter