2017-08-21 17:55:58

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH] mfd: da9052: constify spi_device_id

spi_device_id are not supposed to change at runtime. All functions
working with spi_device_id provided by <linux/i2c.h> work with
const spi_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/mfd/da9052-spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/da9052-spi.c b/drivers/mfd/da9052-spi.c
index b9ea1b2..abfb118 100644
--- a/drivers/mfd/da9052-spi.c
+++ b/drivers/mfd/da9052-spi.c
@@ -67,7 +67,7 @@ static int da9052_spi_remove(struct spi_device *spi)
return 0;
}

-static struct spi_device_id da9052_spi_id[] = {
+static const struct spi_device_id da9052_spi_id[] = {
{"da9052", DA9052},
{"da9053-aa", DA9053_AA},
{"da9053-ba", DA9053_BA},
--
2.7.4


2017-08-22 07:41:51

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH] mfd: da9052: constify spi_device_id

On Mon, 21 Aug 2017, Arvind Yadav wrote:

> spi_device_id are not supposed to change at runtime. All functions
> working with spi_device_id provided by <linux/i2c.h> work with
> const spi_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <[email protected]>
> ---
> drivers/mfd/da9052-spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog