On Mon, Sep 11, 2023 at 06:45:34PM +0300, Andy Shevchenko wrote:
> It's rather a gigantic list of heards that is very hard to follow.
> Sorting helps to see what's already included and what's not.
> It improves a maintainability in a long term.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
Hi Andy,
At the risk of bike shedding, the sort function of Vim, when operating
with the C locale, gives a slightly different order, as experssed by
this incremental diff.
I have no objections to your oder, but I'm slightly curious as
to how it came about.
diff --git a/net/core/dev.c b/net/core/dev.c
index d795a6c5a591..770138babf7e 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -92,9 +92,9 @@
#include <linux/if_ether.h>
#include <linux/if_macvlan.h>
#include <linux/if_vlan.h>
+#include <linux/in.h>
#include <linux/indirect_call_wrapper.h>
#include <linux/inetdevice.h>
-#include <linux/in.h>
#include <linux/init.h>
#include <linux/interrupt.h>
#include <linux/ip.h>
@@ -105,9 +105,9 @@
#include <linux/mm.h>
#include <linux/module.h>
#include <linux/mutex.h>
+#include <linux/net_namespace.h>
#include <linux/netdevice.h>
#include <linux/netfilter_netdev.h>
-#include <linux/net_namespace.h>
#include <linux/netpoll.h>
#include <linux/once_lite.h>
#include <linux/pm_runtime.h>
@@ -142,8 +142,8 @@
#include <net/ip.h>
#include <net/iw_handler.h>
#include <net/mpls.h>
-#include <net/netdev_rx_queue.h>
#include <net/net_namespace.h>
+#include <net/netdev_rx_queue.h>
#include <net/pkt_cls.h>
#include <net/pkt_sched.h>
#include <net/sock.h>
On Tue, Sep 12, 2023 at 05:20:31PM +0200, Simon Horman wrote:
> On Mon, Sep 11, 2023 at 06:45:34PM +0300, Andy Shevchenko wrote:
> > It's rather a gigantic list of heards that is very hard to follow.
> > Sorting helps to see what's already included and what's not.
> > It improves a maintainability in a long term.
> >
> > Signed-off-by: Andy Shevchenko <[email protected]>
>
> Hi Andy,
>
> At the risk of bike shedding, the sort function of Vim, when operating
> with the C locale, gives a slightly different order, as experssed by
> this incremental diff.
>
> I have no objections to your oder, but I'm slightly curious as
> to how it came about.
!sort which is external command.
$ locale -k LC_COLLATE
collate-nrules=4
collate-rulesets=""
collate-symb-hash-sizemb=1303
collate-codeset="UTF-8"
--
With Best Regards,
Andy Shevchenko
On Tue, 2023-09-12 at 19:35 +0300, Andy Shevchenko wrote:
> On Tue, Sep 12, 2023 at 05:20:31PM +0200, Simon Horman wrote:
> > On Mon, Sep 11, 2023 at 06:45:34PM +0300, Andy Shevchenko wrote:
> > > It's rather a gigantic list of heards that is very hard to follow.
> > > Sorting helps to see what's already included and what's not.
> > > It improves a maintainability in a long term.
> > >
> > > Signed-off-by: Andy Shevchenko <[email protected]>
> >
> > Hi Andy,
> >
> > At the risk of bike shedding, the sort function of Vim, when operating
> > with the C locale, gives a slightly different order, as experssed by
> > this incremental diff.
> >
> > I have no objections to your oder, but I'm slightly curious as
> > to how it came about.
>
> !sort which is external command.
>
> $ locale -k LC_COLLATE
> collate-nrules=4
> collate-rulesets=""
> collate-symb-hash-sizemb=1303
> collate-codeset="UTF-8"
I'm unsure this change is worthy. It will make any later fix touching
the header list more difficult to backport, and I don't see a great
direct advantage.
Please repost the first patch standalone.
Thanks,
Paolo