2022-02-09 18:42:17

by André Almeida

[permalink] [raw]
Subject: Re: [PATCH 3/3] spi: amd: Add support for version AMDI0062

Às 14:14 de 09/02/22, Mark Brown escreveu:
> On Wed, Feb 09, 2022 at 01:57:33PM -0300, André Almeida wrote:
>
>> @@ -190,6 +237,9 @@ static inline int amd_spi_fifo_xfer(struct amd_spi *amd_spi,
>> message->actual_length = tx_len + rx_len + 1;
>> /* complete the transaction */
>> message->status = 0;
>> +
>> + if (amd_spi->version == AMD_SPI_V2)
>> + amd_spi_clear_chip(amd_spi, message->spi->chip_select);
>> spi_finalize_current_message(master);
>>
>> return 0;
>
> Why is this one not a switch statement - what happens with v3?

A switch statement should work as well, but currently v1 does nothing
and there's no v3 for now. I think we can change for a switch if v3
requires to do something here as well.